February 2016 - Koha-bugs - lists.koha-community.org

[Bug 4941] Can't set branch in staff client when singleBranchMode is enabled
by bugzilla-daemon＠bugs.koha-community.org 26 Feb '16

26 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4941 Kyle M Hall <kyle(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #29 from Kyle M Hall <kyle(a)bywatersolutions.com> --- Pushed to master, thanks Jonathan! Should be in the Koha 3.24 release! -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

1 0

[Bug 4941] Can't set branch in staff client when singleBranchMode is enabled
by bugzilla-daemon＠bugs.koha-community.org 26 Feb '16

26 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4941 --- Comment #28 from Kyle M Hall <kyle(a)bywatersolutions.com> --- Created attachment 48398 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48398&action=ed… Bug 4941 [QA Followup] - Retain singleBranchMode in list of sysprefs passed to XSLT -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.

1 0

[Bug 4941] Can't set branch in staff client when singleBranchMode is enabled
by bugzilla-daemon＠bugs.koha-community.org 26 Feb '16

26 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4941 --- Comment #27 from Kyle M Hall <kyle(a)bywatersolutions.com> --- Created attachment 48397 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48397&action=ed… Bug 4941: Remove the singleBranchMode system preference The singleBranchMode system preference does not make sense. Either the install has only 1 library defined or several. In both case, we can easily guess the behavior to follow. So the idea of this patch is to replace the fetch of this syspref with a call to count the number of libraries defined in DB. Test plan: 1/ From a fresh Koha install, execute the DB entry to remove the pref. 2/ Define only 1 library 3/ Confirm that Koha behaves the same as before (try to change your library, look at the facets) 4/ Create another library (or more) and reinsert the pref and set it: insert into systempreferences (variable, value) values('singleBranchMode', 1); 5/ Execute the DB entry You should get a warning message. 6/ Repeat 3. Signed-off-by: Chris Cormack <chrisc(a)catalyst.net.nz> Does what it says, but will change behaviour for any Koha install that has 2 branches defined, One circulation, and this preference set. If that is an acceptable change, we might need to make sure this is noted well in the release notes. Signed-off-by: Kyle M Hall <kyle(a)bywatersolutions.com> -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

1 0

[Bug 4941] Can't set branch in staff client when singleBranchMode is enabled
by bugzilla-daemon＠bugs.koha-community.org 26 Feb '16

26 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4941 --- Comment #26 from Kyle M Hall <kyle(a)bywatersolutions.com> --- Created attachment 48396 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48396&action=ed… Bug 4940: DB Changes Signed-off-by: Chris Cormack <chrisc(a)catalyst.net.nz> http://bugs.koha-community.org/show_bug.cgi?id=4941 Signed-off-by: Kyle M Hall <kyle(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.

1 0

[Bug 4941] Can't set branch in staff client when singleBranchMode is enabled
by bugzilla-daemon＠bugs.koha-community.org 26 Feb '16

26 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4941 Kyle M Hall <kyle(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48394|0 |1 is obsolete| | --- Comment #25 from Kyle M Hall <kyle(a)bywatersolutions.com> --- Created attachment 48395 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48395&action=ed… Bug 4941: Make tests non DB dependent Signed-off-by: Chris Cormack <chrisc(a)catalyst.net.nz> Signed-off-by: Kyle M Hall <kyle(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.

1 0

[Bug 4941] Can't set branch in staff client when singleBranchMode is enabled
by bugzilla-daemon＠bugs.koha-community.org 26 Feb '16

26 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4941 Kyle M Hall <kyle(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47200|0 |1 is obsolete| | Attachment #47201|0 |1 is obsolete| | Attachment #47202|0 |1 is obsolete| | --- Comment #24 from Kyle M Hall <kyle(a)bywatersolutions.com> --- Created attachment 48394 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48394&action=ed… Bug 4941: Make tests non DB dependent Signed-off-by: Chris Cormack <chrisc(a)catalyst.net.nz> Signed-off-by: Kyle M Hall <kyle(a)bywatersolutions.com> -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

1 0

[Bug 15645] In transit holds do not show as in transit on request.pl
by bugzilla-daemon＠bugs.koha-community.org 26 Feb '16

26 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15645 Julian Maurice <julian.maurice(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice(a)biblibre.com --- Comment #10 from Julian Maurice <julian.maurice(a)biblibre.com> --- Following test plan on 3.22.x, at step 3 I see "Item being transferred to ..." in reserve/request.pl table. Does it mean that this patch is not needed in 3.22 ? -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13871] OverDrive message when user authentication fails
by bugzilla-daemon＠bugs.koha-community.org 26 Feb '16

26 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13871 --- Comment #41 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Will continue QA session here later. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13534] Deleting staff patron will delete tags approved by this patron
by bugzilla-daemon＠bugs.koha-community.org 26 Feb '16

26 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13534 Julian Maurice <julian.maurice(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice(a)biblibre.com Status|Pushed to Master |Pushed to Stable --- Comment #7 from Julian Maurice <julian.maurice(a)biblibre.com> --- Patches pushed to 3.22.x, will be in 3.22.4 -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15891] New: Late night for Brandon :) updatedatabase
by bugzilla-daemon＠bugs.koha-community.org 26 Feb '16

26 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15891 Bug ID: 15891 Summary: Late night for Brandon :) updatedatabase Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt(a)gmail.com Reporter: m.de.rooy(a)rijksmuseum.nl QA Contact: testopia(a)bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes.

1 12