February 2016 - Koha-bugs - lists.koha-community.org

[Bug 13871] OverDrive message when user authentication fails
by bugzilla-daemon＠bugs.koha-community.org 26 Feb '16

26 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13871 --- Comment #32 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 48387 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48387&action=ed… Bug 13871: [TITLE_AMENDED] Additional changes The original perltidy patch from Mason has been amended. The perltidy itself has been moved to a separate patch with the current perltidyrc applied. As noted on Bugzilla, the original perltidy patch included some extra changes: [1] You prefix timestamp with Sip This is not actually needed (it is imported), but if we should prefix it, we should prefix now with C4::SIP::Sip. But you only changed two occurrences (out of 26). So I remove these two changes. [2] You remove the $server parameter from two calls of maybe_add: A closer look at the remaining code tells me that $server is always passed to maybe_add for FID_SCREEN_MSG. So this only left me the current whitespace change. But at least we documented what we did or did not, and why.. Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14821] Don't show item in checked in list, when it wasn't checked in
by bugzilla-daemon＠bugs.koha-community.org 26 Feb '16

26 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14821 Julian Maurice <julian.maurice(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice(a)biblibre.com Status|Pushed to Master |Pushed to Stable -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13871] OverDrive message when user authentication fails
by bugzilla-daemon＠bugs.koha-community.org 26 Feb '16

26 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13871 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45646|0 |1 is obsolete| | Attachment #45647|0 |1 is obsolete| | Attachment #45648|0 |1 is obsolete| | Attachment #45649|0 |1 is obsolete| | --- Comment #31 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 48386 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48386&action=ed… Bug 13871: Adjusted perl tidy on MsgType.pm Run perltidy pro=xt/perltidyrc on the file. Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13871] OverDrive message when user authentication fails
by bugzilla-daemon＠bugs.koha-community.org 26 Feb '16

26 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13871 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy(a)rijksmuseum.nl --- Comment #30 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Some preliminary QA comment on the first patch only: Smart perl tidy: Removing Sip:: and adding $server. If I only had such a smart perl tidy :) Seriously, we should not do ANY changes if we say that a patch is a perltidy patch. Changes should be in another patch! < $resp .= $lang . Sip::timestamp(); > $resp .= $lang . timestamp(); < $resp .= maybe_add( FID_SCREEN_MSG, $patron->screen_msg ); < $resp .= maybe_add( FID_SCREEN_MSG, $patron->{branchcode} ) > $resp .= maybe_add( FID_SCREEN_MSG, $patron->screen_msg, $server ); > $resp .= maybe_add( FID_SCREEN_MSG, $patron->{branchcode}, $server ) < $resp .= 'YYYY' . ( ' ' x 10 ) . $lang . Sip::timestamp(); > $resp .= 'YYYY' . (' ' x 10) . $lang . timestamp(); Interestingly, this cuddled else disappears too. But note that xt/perltidyrc contains a --cuddled-else. Note that I do not like cuddled else, but somewhere in time the community decided that we should use it. (Nothing better than discussion about tabs or curly braces..) - } else { + } + else { Your tidy patch also contains constructs like (variable) instead of the preferred ( variable ). Two simple examples: < foreach my $i ( keys(%handlers) ) { > foreach my $i (keys(%handlers)) { < my ( $class, $msg, $seqno ) = @_; > my ($class, $msg, $seqno) = @_; So, it appears that you did not use the default Koha perltidyrc but some other one. By conclusion, I will add a new perl tidy patch and extract your real changes in a separate patch. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15481] Remove dead code in datatables.js
by bugzilla-daemon＠bugs.koha-community.org 26 Feb '16

26 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15481 --- Comment #9 from Julian Maurice <julian.maurice(a)biblibre.com> --- (In reply to Marcel de Rooy from comment #7) > I am having the impression that some of this dead code was still used. > And this patch broke some datatables functionality. > For instance, look at some tables in Administration: Libraries, Item types. > Where is the search bar? (In reply to Marcel de Rooy from comment #8) > Should we revert this one? If you revert it, does the search bar reappear ? -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15481] Remove dead code in datatables.js
by bugzilla-daemon＠bugs.koha-community.org 26 Feb '16

26 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15481 --- Comment #8 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Should we revert this one? -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15481] Remove dead code in datatables.js
by bugzilla-daemon＠bugs.koha-community.org 26 Feb '16

26 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15481 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy(a)rijksmuseum.nl --- Comment #7 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- I am having the impression that some of this dead code was still used. And this patch broke some datatables functionality. For instance, look at some tables in Administration: Libraries, Item types. Where is the search bar? -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15008] Add custom HTML areas to circulation and reports home pages
by bugzilla-daemon＠bugs.koha-community.org 26 Feb '16

26 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15008 Nick Clemens <nick(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48383|0 |1 is obsolete| | --- Comment #2 from Nick Clemens <nick(a)bywatersolutions.com> --- Created attachment 48384 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48384&action=ed… Bug 15008 - Add custom HTML areas to circulation and reports home pages To test: 1 - Apply patch 2 - run updatedatabase.pl 3 - Add some html to the two new prefs IntranetReportsHomeHTML and IntranetCirculationHomeHTML 4 - View the reports and circulation homepages and confirm your changes show Sponsored by Northeast Kansas Library System, NEKLS (http://nekls.org/) -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15008] Add custom HTML areas to circulation and reports home pages
by bugzilla-daemon＠bugs.koha-community.org 26 Feb '16

26 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15008 Nick Clemens <nick(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15008] Add custom HTML areas to circulation and reports home pages
by bugzilla-daemon＠bugs.koha-community.org 26 Feb '16

26 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15008 Nick Clemens <nick(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|jweaver(a)bywatersolutions.co |nick(a)bywatersolutions.com |m | Patch complexity|--- |Trivial patch CC| |nick(a)bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.

1 0