February 2016 - Koha-bugs - lists.koha-community.org

[Bug 15810] New: Can't create private lists if OpacAllowPublicListCreation is set to #not allow'
by bugzilla-daemon＠bugs.koha-community.org 26 Feb '16

26 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15810 Bug ID: 15810 Summary: Can't create private lists if OpacAllowPublicListCreation is set to #not allow' Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Lists Assignee: gmcharlt(a)gmail.com Reporter: katrin.fischer(a)bsz-bw.de QA Contact: testopia(a)bugs.koha-community.org CC: m.de.rooy(a)rijksmuseum.nl If you try to create a private list from the OPAC and the OpacAllowPublicListCreation is set to 'not allow' public lists to be created by the patron, an error occurs: Koha::Schema::Result::Virtualshelve at /usr/share/koha/lib/Koha/Object.pm line -- You are receiving this mail because: You are watching all bug changes.

1 19

[Bug 15643] Every datepicker on serials expected date column updates top issue
by bugzilla-daemon＠bugs.koha-community.org 26 Feb '16

26 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15643 Julian Maurice <julian.maurice(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |julian.maurice(a)biblibre.com --- Comment #7 from Julian Maurice <julian.maurice(a)biblibre.com> --- Patch pushed to 3.22.x, will be in 3.22.4 -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13871] OverDrive message when user authentication fails
by bugzilla-daemon＠bugs.koha-community.org 26 Feb '16

26 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13871 --- Comment #40 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- And some advanced wrestling with utf8 characters in the commit message (and the git version on Debian 7) -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13871] OverDrive message when user authentication fails
by bugzilla-daemon＠bugs.koha-community.org 26 Feb '16

26 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13871 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48391|0 |1 is obsolete| | --- Comment #39 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 48393 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48393&action=ed… Bug 13871 [QA Followup] - Rename parameter to send_msg_on_invalid_credentials There are likely other services that would use this same feature. Let's name it something a bit more general. Signed-off-by: Kyle M Hall <kyle(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13871] OverDrive message when user authentication fails
by bugzilla-daemon＠bugs.koha-community.org 26 Feb '16

26 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13871 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48390|0 |1 is obsolete| | --- Comment #38 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 48392 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48392&action=ed… Bug 13871 - OverDrive message when user authentication fails NOTE: apply this patch after the additional perltidy patch this patch is basically a small work-around to fix some confusing login text, when users enter incorrect auth details via Overdrive's website with this option disabled (default) there is no change to SIP's behaviour to test... 1/ configure your overdrive account to talk to your Koha's SIP service 2/ start Koha's SIP 3/ enter a correct username and correct password in overdrive see overdrive display '(1) Greetings from Koha' (good) 4/ enter a correct username and *incorrect* password in overdrive see overdrive display '(1) Greetings from Koha' (bad) 5/ enter an incorrect username in overdrive see overdrive display '(1)' (badder) 6/ apply patch, enable 'overdrive-mode' in Koha's SIPConfig.xml example... --------------------- <accounts> <login id="kohasip" password="xxxxx" delimiter="|" error-detect="enabled" institution="YYY" overdrive-mode="1" /> </accounts> --------------------- 7/ restart SIP 8/ enter a correct username and correct password see overdrive display '(1) Greetings from Koha' 9/ enter a correct username and *incorrect* password see overdrive display '(1) Invalid patron or patron password' 10/ enter an incorrect username and incorrect password see overdrive display '(1) Invalid patron or patron password' http://bugs.koha-community.org/show_bug.cgi?id=1387 Signed-off-by: Kyle M Hall <kyle(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13871] OverDrive message when user authentication fails
by bugzilla-daemon＠bugs.koha-community.org 26 Feb '16

26 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13871 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48389|0 |1 is obsolete| | --- Comment #37 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 48391 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48391&action=ed… Bug 13871 [QA Followup] - Rename parameter to send_msg_on_invalid_credentials There are likely other services that would use this same feature. Let's name it something a bit more general. Signed-off-by: Kyle M Hall <kyle(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13871] OverDrive message when user authentication fails
by bugzilla-daemon＠bugs.koha-community.org 26 Feb '16

26 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13871 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48388|0 |1 is obsolete| | --- Comment #36 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 48390 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48390&action=ed… Bug 13871 - OverDrive message when user authentication fails NOTE: apply this patch after the additional perltidy patch this patch is basically a small work-around to fix some confusing login text, when users enter incorrect auth details via Overdrive's website with this option disabled (default) there is no change to SIP's behaviour to test... 1/ configure your overdrive account to talk to your Koha's SIP service 2/ start Koha's SIP 3/ enter a correct username and correct password in overdrive see overdrive display '(1) Greetings from Koha' (good) 4/ enter a correct username and *incorrect* password in overdrive see overdrive display '(1) Greetings from Koha' (bad) 5/ enter an incorrect username in overdrive see overdrive display '(1)' (badder) 6/ apply patch, enable 'overdrive-mode' in Koha's SIPConfig.xml example... --------------------- <accounts> <login id="kohasip" password="xxxxx" delimiter="|" error-detect="enabled" institution="YYY" overdrive-mode="1" /> </accounts> --------------------- 7/ restart SIP 8/ enter a correct username and correct password see overdrive display '(1) Greetings from Koha…' 9/ enter a correct username and *incorrect* password see overdrive display '(1) Invalid patron or patron password' 10/ enter an incorrect username and incorrect password see overdrive display '(1) Invalid patron or patron password' http://bugs.koha-community.org/show_bug.cgi?id=1387 Signed-off-by: Kyle M Hall <kyle(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13871] OverDrive message when user authentication fails
by bugzilla-daemon＠bugs.koha-community.org 26 Feb '16

26 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13871 --- Comment #35 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- I rebased this patch set on the new perltidy. The second patch includes comments on the changes from Mason. This effectively obsoletes the last follow-up from Kyle to fix the namespace; the namespace is not needed. Still have to look at patch 2 and forth. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13871] OverDrive message when user authentication fails
by bugzilla-daemon＠bugs.koha-community.org 26 Feb '16

26 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13871 --- Comment #34 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 48389 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48389&action=ed… Bug 13871 [QA Followup] - Rename parameter to send_msg_on_invalid_credentials There are likely other services that would use this same feature. Let's name it something a bit more general. Signed-off-by: Kyle M Hall <kyle(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13871] OverDrive message when user authentication fails
by bugzilla-daemon＠bugs.koha-community.org 26 Feb '16

26 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13871 --- Comment #33 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 48388 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48388&action=ed… Bug 13871 - OverDrive message when user authentication fails NOTE: apply this patch after the additional perltidy patch this patch is basically a small work-around to fix some confusing login text, when users enter incorrect auth details via Overdrive's website with this option disabled (default) there is no change to SIP's behaviour to test... 1/ configure your overdrive account to talk to your Koha's SIP service 2/ start Koha's SIP 3/ enter a correct username and correct password in overdrive see overdrive display '(1) Greetings from Koha…' (good) 4/ enter a correct username and *incorrect* password in overdrive see overdrive display '(1) Greetings from Koha…' (bad) 5/ enter an incorrect username in overdrive see overdrive display '(1)' (badder) 6/ apply patch, enable 'overdrive-mode' in Koha's SIPConfig.xml example... --------------------- <accounts> <login id="kohasip" password="xxxxx" delimiter="|" error-detect="enabled" institution="YYY" overdrive-mode="1" /> </accounts> --------------------- 7/ restart SIP 8/ enter a correct username and correct password see overdrive display '(1) Greetings from Koha…' 9/ enter a correct username and *incorrect* password see overdrive display '(1) Invalid patron or patron password' 10/ enter an incorrect username and incorrect password see overdrive display '(1) Invalid patron or patron password' http://bugs.koha-community.org/show_bug.cgi?id=1387 Signed-off-by: Kyle M Hall <kyle(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0