February 2016 - Koha-bugs - lists.koha-community.org

[Bug 15600] System preferences broken toolbar looks broken
by bugzilla-daemon＠bugs.koha-community.org 19 Feb '16

19 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15600 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart(a)bugs.koha-c | |ommunity.org --- Comment #11 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Do we need both patches? With both patches applied, the button does not look disabled if nothing has been changed, it's a bit confusing (and the cursor is the cursor is a pointer). With only the following change, I get what is (I think) is expected: diff --git a/koha-tmpl/intranet-tmpl/prog/en/css/staff-global.css b/koha-tmpl/intranet-tmpl/prog/en/css/staff-global.css index b35e6be..06c39c2 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/css/staff-global.css +++ b/koha-tmpl/intranet-tmpl/prog/en/css/staff-global.css @@ -422,7 +422,7 @@ dd { font-weight : normal; } -.btn-toolbar { +div#toolbar, .btn-toolbar { background-color : #EDF4F6; padding: 5px 5px 5px 5px; border-radius: 5px 5px 0 0; -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14941] Subfield defaults: Add information about substitutable values
by bugzilla-daemon＠bugs.koha-community.org 19 Feb '16

19 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14941 Marc Véron <veron(a)veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt(a)gmail.com |nengard(a)gmail.com Component|Cataloging |Documentation --- Comment #1 from Marc Véron <veron(a)veron.ch> --- Changed to 'Documentation' -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13837] Popup "Search for garantor" should not display language menu in footer
by bugzilla-daemon＠bugs.koha-community.org 19 Feb '16

19 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13837 Marc Véron <veron(a)veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |WONTFIX --- Comment #1 from Marc Véron <veron(a)veron.ch> --- Language selection is part of intranet-bottom.inc A fix of this rather cosmetic issue would need to create a separate 'bottom.inc' for such popups. Setting to RESOLVED WONTFIX -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 0

[Bug 13835] Popup "Search for budget owner" should not display language menu in footer
by bugzilla-daemon＠bugs.koha-community.org 19 Feb '16

19 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13835 Marc Véron <veron(a)veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |WONTFIX Status|NEW |RESOLVED --- Comment #1 from Marc Véron <veron(a)veron.ch> --- Language selection is part of intranet-bottom.inc A fix of this rather cosmetic issue would need to create a separate 'bottom.inc' for such popups. Setting to RESOLVED WONTFIX -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 0

[Bug 2669] Radio Buttons where there should be checkboxes on Dictionary
by bugzilla-daemon＠bugs.koha-community.org 19 Feb '16

19 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2669 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=15863 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

1 0

[Bug 13041] Can't add user as manager of basket if name includes a single quote
by bugzilla-daemon＠bugs.koha-community.org 19 Feb '16

19 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13041 Owen Leonard <oleonard(a)myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |NEW -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15463] view_holdsqueue.tt uses a search for cardnumber instead of borrowernumber direct link
by bugzilla-daemon＠bugs.koha-community.org 19 Feb '16

19 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15463 --- Comment #3 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- circ/circulation.pl expects a cardnumber: 246 if ($findborrower) { 247 my $borrower = C4::Members::GetMember( cardnumber => $findborrower ); 248 if ( $borrower ) { 249 $borrowernumber = $borrower->{borrowernumber}; 250 } else { If not found, the script will try and search the $findborrower using the C4::Utils::DataTables::Members::search subroutine. We will have to change all occurrences if we want to change this behavior, not only view_holdsqueue.tt -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 0

[Bug 15376] Edit invoices: Can not change Shipping cost.
by bugzilla-daemon＠bugs.koha-community.org 19 Feb '16

19 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15376 Marc Véron <veron(a)veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |WONTFIX Status|Failed QA |RESOLVED --- Comment #10 from Marc Véron <veron(a)veron.ch> --- Re-tested on current master, I can no longer reproduce the issue. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11844] Additional fields for order lines
by bugzilla-daemon＠bugs.koha-community.org 19 Feb '16

19 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11844 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=15774 -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 5404] C4::Koha::subfield_is_koha_internal_p no longer serves a purpose
by bugzilla-daemon＠bugs.koha-community.org 19 Feb '16

19 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5404 --- Comment #7 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- (In reply to Marcel de Rooy from comment #5) > QA Comment: > I am not sure if this really is a better solution. > I also doubt about the remark in comment 1 "Apparently older versions of > Koha considered a MARC subfield in the frameworks that had a code longer > than one character to be reserved for internal use". To me it just seems to > be a trick to skip the internal fields lib, tab, mandatory and repeatable > (all length>1). > > In terms of design it would have been easier to put all subfields a level > deeper instead of on the same level as lib, etc. > > I understand about not changing the design of the structure here. Yes, that would be a next step. > But now we move the test length<>1 from a subroutine into the code and check > if it is a ref or not. > I probably would like to still have the test in the subroutine (with all > benefits of a subroutine); another name would be fine. Not sure it's needed, as the test is very simple. Where would you move this subroutine? > If someone wants to add some other property to the structure and suppose > that is an arrayref or a hashref or an object, your test would fail. Yes but it works for the moment :) The structure has not changed for years. > I would propose to test (in the sub): > [a] skip if the field name matches lib|tab|mandatory|repeatable Imo, that would make the test less strong and too specific. -- You are receiving this mail because: You are watching all bug changes.

1 0