February 2016 - Koha-bugs - lists.koha-community.org

[Bug 15635] Move the patron images related code to Koha::Patron::Images
by bugzilla-daemon＠bugs.koha-community.org 19 Feb '16

19 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15635 --- Comment #29 from Kyle M Hall <kyle(a)bywatersolutions.com> --- Created attachment 48249 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48249&action=ed… Bug 15635 [QA Followup] - Fix number of unit tests Signed-off-by: Kyle M Hall <kyle(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15635] Move the patron images related code to Koha::Patron::Images
by bugzilla-daemon＠bugs.koha-community.org 19 Feb '16

19 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15635 --- Comment #28 from Kyle M Hall <kyle(a)bywatersolutions.com> --- Created attachment 48248 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48248&action=ed… Bug 15635: Change method type to _type for bug 15446 Signed-off-by: Josef Moravec <josef.moravec(a)gmail.com> Signed-off-by: Kyle M Hall <kyle(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15635] Move the patron images related code to Koha::Patron::Images
by bugzilla-daemon＠bugs.koha-community.org 19 Feb '16

19 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15635 --- Comment #27 from Kyle M Hall <kyle(a)bywatersolutions.com> --- Created attachment 48247 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48247&action=ed… Bug 15635: Koha::Patron::Images - Remove GetPatronImage To retrieve a patron image, we can call Koha::Patron::Images->find or Koha::Patrons->find->image Both will return a Koha::Patron::Image object. Test plan: 1/ From the patron/member module, open all tabs on the left (Checkouts, detail, fines, etc.) The image should be correctly displayed. 2/ At the OPAC, on the patron details page (opac-memberentry.pl) the image should be displayed as well. 3/ Same on the sco module. Signed-off-by: Josef Moravec <josef.moravec(a)gmail.com> Signed-off-by: Kyle M Hall <kyle(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15635] Move the patron images related code to Koha::Patron::Images
by bugzilla-daemon＠bugs.koha-community.org 19 Feb '16

19 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15635 --- Comment #26 from Kyle M Hall <kyle(a)bywatersolutions.com> --- Created attachment 48246 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48246&action=ed… Bug 15635: Koha::Patron::Images - Remove RmPatronImage The C4::Members::RmPatronImage just removed a row in patronimage. This can be accomplished using the delete method of Koha::Patron::Image. Test plan: >From the patron defail page, try to delete the image of a patron. Signed-off-by: Josef Moravec <josef.moravec(a)gmail.com> Signed-off-by: Kyle M Hall <kyle(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15635] Move the patron images related code to Koha::Patron::Images
by bugzilla-daemon＠bugs.koha-community.org 19 Feb '16

19 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15635 --- Comment #25 from Kyle M Hall <kyle(a)bywatersolutions.com> --- Created attachment 48245 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48245&action=ed… Bug 15635: Koha::Patron::Images - Remove PutPatronImage The C4::Members::PutPatronImage inserted/updated the image of a patron. This can be done easily with ->find->set->store or ->new->store Test plan: 1/ Modify the image of a patron from the patron detail page 2/ Add an image to a new patron 3/ Use the "Upload patron images" tools (tools/picture-upload.pl) to add or modify the image of a patron 4/ Use the "Upload patron images" tools (tools/picture-upload.pl) to add or modify the image of several patrons, using a zip file. Stress the script trying to get as many errors as possible (wrong cardnumber, wrong mimetype, file does not exist, etc.) With this patch, if the cardnumber does not exist, you will get a specific error "Image not imported because this patron does not exist in the database" Signed-off-by: Josef Moravec <josef.moravec(a)gmail.com> Signed-off-by: Kyle M Hall <kyle(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15635] Move the patron images related code to Koha::Patron::Images
by bugzilla-daemon＠bugs.koha-community.org 19 Feb '16

19 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15635 Kyle M Hall <kyle(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48243|0 |1 is obsolete| | --- Comment #24 from Kyle M Hall <kyle(a)bywatersolutions.com> --- Created attachment 48244 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48244&action=ed… Bug 15635: Koha::Patron::Images - Add new classes There are 3 subroutines in C4::Members to get, add and delete patron images: - GetPatronImage - PutPatronImage - RmPatronImage By creating these 2 Koha::Patron::Image[s] classes, we could remove them easily. Signed-off-by: Josef Moravec <josef.moravec(a)gmail.com> Signed-off-by: Kyle M Hall <kyle(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15635] Move the patron images related code to Koha::Patron::Images
by bugzilla-daemon＠bugs.koha-community.org 19 Feb '16

19 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15635 Kyle M Hall <kyle(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48136|0 |1 is obsolete| | Attachment #48137|0 |1 is obsolete| | Attachment #48138|0 |1 is obsolete| | Attachment #48139|0 |1 is obsolete| | Attachment #48140|0 |1 is obsolete| | --- Comment #23 from Kyle M Hall <kyle(a)bywatersolutions.com> --- Created attachment 48243 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48243&action=ed… Bug 15635: Koha::Patron::Images - Add new classes There are 3 subroutines in C4::Members to get, add and delete patron images: - GetPatronImage - PutPatronImage - RmPatronImage By creating these 2 Koha::Patron::Image[s] classes, we could remove them easily. Signed-off-by: Josef Moravec <josef.moravec(a)gmail.com> Signed-off-by: Kyle M Hall <kyle(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15635] Move the patron images related code to Koha::Patron::Images
by bugzilla-daemon＠bugs.koha-community.org 19 Feb '16

19 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15635 Kyle M Hall <kyle(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15600] System preferences broken toolbar looks broken
by bugzilla-daemon＠bugs.koha-community.org 19 Feb '16

19 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15600 Héctor Eduardo Castro Avalos <hector.hecaxmmx(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hector.hecaxmmx(a)gmail.com Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15600] System preferences broken toolbar looks broken
by bugzilla-daemon＠bugs.koha-community.org 19 Feb '16

19 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15600 Héctor Eduardo Castro Avalos <hector.hecaxmmx(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48211|0 |1 is obsolete| | --- Comment #10 from Héctor Eduardo Castro Avalos <hector.hecaxmmx(a)gmail.com> --- Created attachment 48242 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48242&action=ed… [SIGNED-OFF]Bug 15600: System preferences broken toolbar looks broken This patch reverts some deletions made to staff-global.css in Bug 11559. The deletions broke the appearance of the floating toolbar in system preferences. To test, apply the patch and clear your browser cache if necessary. - Go to Administration -> System preferences and view a tab with enough content to allow you to scroll and test the appearance of the floating toolbar. Confirm that it looks correct. - Open the advanced cataloging editor and confirm that its toolbar looks correct. - Open the normal cataloging editor and confirm that the floating toolbar looks correct and works correctly. Signed-off-by: Hector Castro <hector.hecaxmmx(a)gmail.com> Works as advertised. Tollbar looks correct -- You are receiving this mail because: You are watching all bug changes.

1 0