February 2016 - Koha-bugs - lists.koha-community.org

[Bug 14507] SIP Authentication broken when LDAP Auth Enabled
by bugzilla-daemon＠bugs.koha-community.org 19 Feb '16

19 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14507 Kyle M Hall <kyle(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14507] SIP Authentication broken when LDAP Auth Enabled
by bugzilla-daemon＠bugs.koha-community.org 19 Feb '16

19 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14507 Kyle M Hall <kyle(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle(a)bywatersolutions.com Attachment #41379|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14457] Integrate LIBRIS spellchecking
by bugzilla-daemon＠bugs.koha-community.org 19 Feb '16

19 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14457 --- Comment #18 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- I am not sure about a preference here as it's a plugin for a specific API (LibrisSpellcheck.pm). -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7560] SIP Self Checkout Ignoring Fines Thresholds for Not Being able to Check Out Books
by bugzilla-daemon＠bugs.koha-community.org 19 Feb '16

19 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7560 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply --- Comment #44 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- I could rebase the first three but then the fourth complained about useless sha1 info on Accounts.t Please rebase and squash all patches. Or at least squash all QA follow-ups. You could add the signoff from Chris (on the first one), but if you do, please add a line that the patch was amended after that. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15126] REST API: Use newer version of Swagger2
by bugzilla-daemon＠bugs.koha-community.org 19 Feb '16

19 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15126 Olli-Antti Kivilahti <olli-antti.kivilahti(a)jns.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47843|0 |1 is obsolete| | Attachment #47844|0 |1 is obsolete| | --- Comment #16 from Olli-Antti Kivilahti <olli-antti.kivilahti(a)jns.fi> --- Created attachment 48226 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48226&action=ed… Newest Swagger-spec validated 100% and pushed to production yay! Includes the swaggerMinifier.pl -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14457] Integrate LIBRIS spellchecking
by bugzilla-daemon＠bugs.koha-community.org 19 Feb '16

19 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14457 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #17 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- QA Comment: Nice addition, Eivin. First I am stumbling over the hardcoded Swedish libris server in the code. Nothing against Sweden btw, but could we put that URL in a pref or config somewhere else? In this case you could add both prefs in one entry like some other prefs are organized (e.g. DefaultLongOverdueLostValue and DefaultLongOverdueDays ). Another small point is: Please add the new pref(s) to sysprefs.sql To test error checking, I changed the URL. Clicking on suggestions gave me: File does not exist: Can't connect to api.libris.kb.nl:80 (Bad hostname) LWP::Protocol::http::Socket: Bad hostname 'api.libris.kb.nl' Could you add some checks around line 34? What is the return value if get does not connect etc? Or when given an expired key? And in terms of security. You get $search from CGI param and directly feed it into LWP. Should we do some sanitizing here? When testing some searches, I always got only one alternative. Do you have examples where I get various results back? And the typo in spellcheking is hilarious. But please correct. Changing status to reflect need for some adjustments. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14457] Integrate LIBRIS spellchecking
by bugzilla-daemon＠bugs.koha-community.org 19 Feb '16

19 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14457 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia(a)bugs.koha-communit |m.de.rooy(a)rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14457] Integrate LIBRIS spellchecking
by bugzilla-daemon＠bugs.koha-community.org 19 Feb '16

19 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14457 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy(a)rijksmuseum.nl --- Comment #16 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- (In reply to David Cook from comment #15) > > + - LIBRIS Spellcheking API key > There is a typo here, but perhaps QA can fix it? Really nice typo at the right spot :) -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8483] Borrower reading history should include deleted items
by bugzilla-daemon＠bugs.koha-community.org 19 Feb '16

19 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8483 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy(a)rijksmuseum.nl Status|Signed Off |Patch doesn't apply --- Comment #31 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- The patch does not apply anymore. Additionally, reading the discussion, how can I generate some performance figures to compare with the different figures given already? -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12598] New misc/import_borrowers.pl command line tool
by bugzilla-daemon＠bugs.koha-community.org 19 Feb '16

19 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes.

1 0