February 2016 - Koha-bugs - lists.koha-community.org

[Bug 5404] C4::Koha::subfield_is_koha_internal_p no longer serves a purpose
by bugzilla-daemon＠bugs.koha-community.org 19 Feb '16

19 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5404 --- Comment #6 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- (In reply to Marcel de Rooy from comment #5) > or [b] proceed if the field is a ref called MARC::Field (instead of testing > if ref is true, we test ref eq ..) Oops. That is not true. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 5404] C4::Koha::subfield_is_koha_internal_p no longer serves a purpose
by bugzilla-daemon＠bugs.koha-community.org 19 Feb '16

19 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5404 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |In Discussion --- Comment #5 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- QA Comment: I am not sure if this really is a better solution. I also doubt about the remark in comment 1 "Apparently older versions of Koha considered a MARC subfield in the frameworks that had a code longer than one character to be reserved for internal use". To me it just seems to be a trick to skip the internal fields lib, tab, mandatory and repeatable (all length>1). In terms of design it would have been easier to put all subfields a level deeper instead of on the same level as lib, etc. I understand about not changing the design of the structure here. But now we move the test length<>1 from a subroutine into the code and check if it is a ref or not. I probably would like to still have the test in the subroutine (with all benefits of a subroutine); another name would be fine. If someone wants to add some other property to the structure and suppose that is an arrayref or a hashref or an object, your test would fail. I would propose to test (in the sub): [a] skip if the field name matches lib|tab|mandatory|repeatable or [b] proceed if the field is a ref called MARC::Field (instead of testing if ref is true, we test ref eq ..) Obviously, I agree with removing the call for a loop on only real subfields. Changing status -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15552] Better wording of intranetreadinghistory syspref
by bugzilla-daemon＠bugs.koha-community.org 19 Feb '16

19 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15552 Julian Maurice <julian.maurice(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice(a)biblibre.com Status|Pushed to Master |Pushed to Stable --- Comment #5 from Julian Maurice <julian.maurice(a)biblibre.com> --- Patch pushed to 3.22.x, will be in 3.22.4 -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15571] reserveforothers permission does not remove Search to hold button from patron account
by bugzilla-daemon＠bugs.koha-community.org 19 Feb '16

19 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15571 Julian Maurice <julian.maurice(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |julian.maurice(a)biblibre.com --- Comment #15 from Julian Maurice <julian.maurice(a)biblibre.com> --- Patches pushed to 3.22.x, will be in 3.22.4 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 0

[Bug 15573] String and translatability fix to Patron Card Creator
by bugzilla-daemon＠bugs.koha-community.org 19 Feb '16

19 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15573 Julian Maurice <julian.maurice(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |julian.maurice(a)biblibre.com --- Comment #10 from Julian Maurice <julian.maurice(a)biblibre.com> --- Patch pushed to 3.22.x, will be in 3.22.4 -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 5404] C4::Koha::subfield_is_koha_internal_p no longer serves a purpose
by bugzilla-daemon＠bugs.koha-community.org 19 Feb '16

19 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5404 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch CC| |m.de.rooy(a)rijksmuseum.nl QA Contact|koha-bugs(a)lists.koha-commun |m.de.rooy(a)rijksmuseum.nl |ity.org | -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

1 0

[Bug 15531] Add support for standing orders
by bugzilla-daemon＠bugs.koha-community.org 18 Feb '16

18 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15531 Liz Rea <liz(a)catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |liz(a)catalyst.net.nz --- Comment #7 from Liz Rea <liz(a)catalyst.net.nz> --- Aleisha, I think I know what your problem may be here, come find me next time you're in. :) Liz -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15163] Patron attributes with branch limiits are not saved when invisible
by bugzilla-daemon＠bugs.koha-community.org 18 Feb '16

18 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15163 --- Comment #15 from Jesse Weaver <jweaver(a)bywatersolutions.com> --- (In reply to Jonathan Druart from comment #11) > Jesse, yes it should be the way to go but.. > I have already tried something and was stuck. I have a wip branch but I > don't remember what was wrong. > > Looking at the diff it seems that I have tried to add a > DeleteBorrowerAttributes subroutines and the code looks quite complicated: > > +sub DeleteBorrowerAttributes { > + my $borrowernumber = shift; > + my $no_branch_limit = @_ ? shift : 0; > + my $branch_limit = $no_branch_limit > + ? 0 > + : C4::Context->userenv ? C4::Context->userenv->{"branch"} : 0; > + > + my $dbh = C4::Context->dbh; > + my $query = q{ > + DELETE FROM borrower_attributes > + }; > + $query .= q{ > + LEFT JOIN borrower_attribute_types_branches ON bat_code = code > + WHERE b_branchcode = ? OR b_branchcode IS NULL > + } if $branch_limit; > + $query .= q{ > + WHERE borrowernumber = ? > + }; > + > + $dbh->do( $query, undef, $branch_limit ? $branch_limit : (), > $borrowernumber ); > +} That honestly looks exactly like what I would have done. Why send the hidden attributes in memberentrygen.tt, though, if DeleteBorrowerAttributes is branch-limited? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 0

[Bug 13738] Add RESTful Borrower service
by bugzilla-daemon＠bugs.koha-community.org 18 Feb '16

18 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13738 Bug 13738 depends on bug 12272, which changed state. Bug 12272 Summary: Refactor C4::Service API into Koha::Service class https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12272 What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |INVALID -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13737] [OMNIBUS] Add Koha RESTful Services
by bugzilla-daemon＠bugs.koha-community.org 18 Feb '16

18 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13737 Bug 13737 depends on bug 12272, which changed state. Bug 12272 Summary: Refactor C4::Service API into Koha::Service class https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12272 What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |INVALID -- You are receiving this mail because: You are watching all bug changes.

1 0