March 2016 - Koha-bugs - lists.koha-community.org

[Bug 16031] New: sitemap.pl shouldn't append protocol to OPACBaseURL
by bugzilla-daemon＠bugs.koha-community.org 14 Mar '16

14 Mar '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16031 Bug ID: 16031 Summary: sitemap.pl shouldn't append protocol to OPACBaseURL Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Command-line Utilities Assignee: gmcharlt(a)gmail.com Reporter: tomascohen(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org CC: robin(a)catalyst.net.nz Right now, the script appends a fixed protocol (HTTP) to the generated URL. This is because the tool was written before bug 5010 was pushed. To reproduce: - Have OPACBaseURL set - Run the script (without the --url parameter) => FAIL: Notice the generated sitemap files contain double protocol specification on the URLs (like in http://http:// or http://https://) -- You are receiving this mail because: You are watching all bug changes.

1 14

[Bug 15968] New: Unnecessary loop in C4::Templates
by bugzilla-daemon＠bugs.koha-community.org 14 Mar '16

14 Mar '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15968 Bug ID: 15968 Summary: Unnecessary loop in C4::Templates Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart(a)bugs.koha-community.org Reporter: jonathan.druart(a)bugs.koha-community.org QA Contact: testopia(a)bugs.koha-community.org >From C4::Templates::output # add variables set via param to $vars for processing for my $k ( keys %{ $self->{VARS} } ) { $vars->{$k} = $self->{VARS}->{$k}; } This loop is not necessary, we could do the same with $vars = { %$vars, %{ $self->{VARS} } }; After a quick benchmark, it gains 100 microseconds when we pass 170 vars to the template. -- You are receiving this mail because: You are watching all bug changes.

1 10

[Bug 15735] New: Audio Alerts editor broken by use of of single quotes in editor
by bugzilla-daemon＠bugs.koha-community.org 14 Mar '16

14 Mar '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15735 Bug ID: 15735 Summary: Audio Alerts editor broken by use of of single quotes in editor Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt(a)gmail.com Reporter: kyle(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org Single quotes audio selector break ability to edit an alert -- You are receiving this mail because: You are watching all bug changes.

1 21

[Bug 4941] Remove singleBranchMode system preference
by bugzilla-daemon＠bugs.koha-community.org 14 Mar '16

14 Mar '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4941 Julian Maurice <julian.maurice(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice(a)biblibre.com Severity|normal |enhancement -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.

1 0

[Bug 16009] New: crash displaying pending offline circulations
by bugzilla-daemon＠bugs.koha-community.org 14 Mar '16

14 Mar '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16009 Bug ID: 16009 Summary: crash displaying pending offline circulations Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs(a)lists.koha-community.org Reporter: gmcharlt(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com Displaying a list of pending offline circulation actions can now fail if the cardnumber is null (as can be the case with a return). The associated crash is: DBD::mysql::st execute failed: called with 1 bind variables when 0 are needed [for Statement "SELECT borrowers.*, categories.category_type, categories.description FROM borrowers LEFT JOIN categories on borrowers.categorycode=categories.categorycode WHERE cardnumber IS NULL"] at /usr/share/koha/lib/C4/Members.pm line 451. This appears to be a consequence of bug 15344; it turns out that GetMemberDetails handled cardnumber => NULL better than GetMember does at present. This looks like it affects master, 3.20.8+, and 3.22.2+ -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 13

[Bug 15545] Optionally require notes when placing a hold
by bugzilla-daemon＠bugs.koha-community.org 14 Mar '16

14 Mar '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15545 --- Comment #10 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Rebased -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15545] Optionally require notes when placing a hold
by bugzilla-daemon＠bugs.koha-community.org 14 Mar '16

14 Mar '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15545 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46689|0 |1 is obsolete| | --- Comment #9 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 49086 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49086&action=ed… Bug 15545: Unit test for IsHoldNoteRequired Adds unit test. Test plan: Run the test t/db../Reserves/IsHoldNoteRequired.t -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15545] Optionally require notes when placing a hold
by bugzilla-daemon＠bugs.koha-community.org 14 Mar '16

14 Mar '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15545 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46688|0 |1 is obsolete| | --- Comment #8 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 49085 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49085&action=ed… Bug 15545: Optionally require notes when placing a hold This report adds three cases where you could want to require a note when placing a hold. Each of these cases may be enabled separately via the system preference HoldNoteReasons. (The hold note itself is triggered by OpacHoldNotes.) These three cases are: [1] serial indication in the leader (called LEADER_SERIAL) [2] collection indication in the leader (LEADER_COLLECTION) [3] MARC 300$a contains an indication of multiple parts/volumes, as identified by a regular expression (MARC300A_PARTS). The new sub IsHoldNoteRequired in Reserves.pm handles these cases. And will be easily extensible. Also this patch removes some unused code in the reserves template for mandatory hold notes reasons. Test plan: [1] Enable OpacHoldNotes. Set HoldNoteReasons to LEADER_SERIAL. [2] In OPAC, place a hold on a serial record (with correct leader). Verify that the hold notes are required. [3] Set HoldNoteReasons to MARC300A_PARTS. Verify that the hold notes are no longer required for the record in the preceding step. (This actually depends on your 300$a..) Cancel the hold you placed. [4] Add "2 vols" to MARC 300$a in the same record. Try to place the hold again. The hold notes should be required again. [5] Place a multiple hold request with the same record and another one. Click Place Hold while more-options is collapsed (blank notes). Is the correct hold note made visible? -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15545] Optionally require notes when placing a hold
by bugzilla-daemon＠bugs.koha-community.org 14 Mar '16

14 Mar '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15545 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46687|0 |1 is obsolete| | --- Comment #7 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 49084 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49084&action=ed… Bug 15545: Database revision for HoldNoteReasons pref Adds a new preference. Test plan: Run the db revision. Check the pref in the interface. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 6473] Test bug for Git-bz
by bugzilla-daemon＠bugs.koha-community.org 14 Mar '16

14 Mar '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6473 --- Comment #184 from sandboxes(a)biblibre.com <sandboxes(a)biblibre.com> --- Created attachment 49083 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49083&action=ed… Bug 6473: just a test https://bugs.koha-community.org/show_bug.cgi?id=6473 Signed-off-by: Julian Maurice <julian.maurice(a)biblibre.com> -- You are receiving this mail because: You are watching all bug changes.

1 0