March 2016 - Koha-bugs - lists.koha-community.org

[Bug 15263] XSLT display fetches sysprefs for every result processed
by bugzilla-daemon＠bugs.koha-community.org 10 Mar '16

10 Mar '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15263 --- Comment #3 from Jacek Ablewicz <abl(a)biblos.pk.edu.pl> --- (In reply to Jonathan Druart from comment #2) > I think this patch would become useless with the patch Bug 11998: Add a L1 > cache for sysprefs Not entirely - it still improves catalogue/search.pl run time by ca 80-100ms (on the fast server): - ~30ms save on eliminating 1100+ redundant syspref() calls, 21*49 string concatenations etc. - 45ms on eliminating 49 redundant C4::Languages::getlanguage() calls -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11998] Syspref caching issues
by bugzilla-daemon＠bugs.koha-community.org 10 Mar '16

10 Mar '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11998 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=15263 -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15263] XSLT display fetches sysprefs for every result processed
by bugzilla-daemon＠bugs.koha-community.org 10 Mar '16

10 Mar '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15263 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=11998 CC| |jonathan.druart(a)bugs.koha-c | |ommunity.org --- Comment #2 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- I think this patch would become useless with the patch Bug 11998: Add a L1 cache for sysprefs -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11998] Syspref caching issues
by bugzilla-daemon＠bugs.koha-community.org 10 Mar '16

10 Mar '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11998 --- Comment #141 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- *** Bug 15973 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15973] New: Do not disable syspref cache for Plack
by bugzilla-daemon＠bugs.koha-community.org 10 Mar '16

10 Mar '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15973 Bug ID: 15973 Summary: Do not disable syspref cache for Plack Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart(a)bugs.koha-community.org Reporter: jonathan.druart(a)bugs.koha-community.org QA Contact: testopia(a)bugs.koha-community.org Depends on: 13805 Bug 13805 fixes an installer bug by disabling the syspref cache. It was not a good idea, it introduced performance issues (see bug 13805 comment 14). Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13805 [Bug 13805] Installer does not work under Plack -- You are receiving this mail because: You are watching all bug changes.

1 7

[Bug 15342] Performance 3.22 - Omnibus
by bugzilla-daemon＠bugs.koha-community.org 10 Mar '16

10 Mar '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15342 Bug 15342 depends on bug 15970, which changed state. Bug 15970 Summary: Plack should not clear syspref cache https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15970 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |RESOLVED Resolution|--- |DUPLICATE -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11998] Syspref caching issues
by bugzilla-daemon＠bugs.koha-community.org 10 Mar '16

10 Mar '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11998 --- Comment #140 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- *** Bug 15970 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15970] New: Plack should not clear syspref cache
by bugzilla-daemon＠bugs.koha-community.org 10 Mar '16

10 Mar '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15970 Bug ID: 15970 Summary: Plack should not clear syspref cache Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart(a)bugs.koha-community.org Reporter: jonathan.druart(a)bugs.koha-community.org QA Contact: testopia(a)bugs.koha-community.org Depends on: 15341, 13815 Just played with nytprof and found something exciting: If I remove the following line: C4::Context->clear_syspref_cache(); from the psgi file, the processing time is divided per 2 (!) With the clear cache: for 15.8s (of 18.6s), executing 2588556 statements and 903720 subroutine calls in 421 source files and 63 string evals. Without the clear cache: for 7.82s (of 8.69s), executing 904432 statements and 262539 subroutine calls in 421 source files and 63 string evals. I have tried to update a pref (NoLoginInstructions): it's saved and displayed correctly. Am I missing something? Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13815 [Bug 13815] plack loose CGI qw(-utf8) flag creating incorrect utf-8 encoding everywhere https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15341 [Bug 15341] Performance - Retrieve all sysprefs at once -- You are receiving this mail because: You are watching all bug changes.

1 11

[Bug 11998] Syspref caching issues
by bugzilla-daemon＠bugs.koha-community.org 10 Mar '16

10 Mar '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11998 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|15970, 15973 | See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=15970 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15970 [Bug 15970] Plack should not clear syspref cache https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15973 [Bug 15973] Do not disable syspref cache for Plack -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11998] Syspref caching issues
by bugzilla-daemon＠bugs.koha-community.org 10 Mar '16

10 Mar '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11998 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |In Discussion --- Comment #139 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- (In reply to Jacek Ablewicz from comment #128) > implementing cache with 2+ levels (1st level being a simple hash or > CHI::Driver::RawMemory for example, and 2nd level - memcache etc.) I really like this idea, I have implemented it in the last 2 patches. I have also moved patches from bug 15970 and bug 15973 to this one (they should be pushed altogether). How do you measure your results? Do you have a script to share? Putting to 'in discussion'. -- You are receiving this mail because: You are watching all bug changes.

1 0