March 2016 - Koha-bugs - lists.koha-community.org

[Bug 11998] Syspref caching issues
by bugzilla-daemon＠bugs.koha-community.org 10 Mar '16

10 Mar '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11998 --- Comment #138 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 48936 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48936&action=ed… Bug 11998: Clear L1 cache from psgi files -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11998] Syspref caching issues
by bugzilla-daemon＠bugs.koha-community.org 10 Mar '16

10 Mar '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11998 --- Comment #137 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 48935 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48935&action=ed… Bug 11998: Add a L1 cache for sysprefs Accessing to the cache for each call to C4::Context->preference might have an impact on performances. To avoid that this patch introduces a L1 cache (simple hashref). It will be populated by accessing the L2 cache (Koha::Cache). If a pref is retrieved 10x, the first one will get the value from the L2 cache, then the L1 cache will be check. To do so we will need to clear the L1 cache every time a page is loaded. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11998] Syspref caching issues
by bugzilla-daemon＠bugs.koha-community.org 10 Mar '16

10 Mar '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11998 --- Comment #136 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 48934 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48934&action=ed… Bug 11998: follow-up for the debian package psgi file -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11998] Syspref caching issues
by bugzilla-daemon＠bugs.koha-community.org 10 Mar '16

10 Mar '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11998 --- Comment #135 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 48933 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48933&action=ed… Bug 11998: Revert "Bug 13805: (Plack) Disable syspref cache" This reverts commit ca00f0ddaeb76106b4aa274fd1848844ae042f58. Bug 13805 fixes an installer bug by disabling the syspref cache. It was not a good idea, it introduced performance issues (see bug 13805 comment 14). Test plan: Test plan: 0/ Create a new database and fill the database entry in the koha conf with its name 1/ Go on the mainpage, you should be redirected to the installer 2/ Try to log in You should not get the login form again. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11998] Syspref caching issues
by bugzilla-daemon＠bugs.koha-community.org 10 Mar '16

10 Mar '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11998 --- Comment #134 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 48932 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48932&action=ed… Bug 11998: Do not clear syspref cache in psgi file This in only in koha.psgi, it has been introduced by bug 13815 but should not have been added by this patch. Removing it should not introduce any changes. Not that it won't impact debian packages. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11998] Syspref caching issues
by bugzilla-daemon＠bugs.koha-community.org 10 Mar '16

10 Mar '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11998 --- Comment #133 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 48931 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48931&action=ed… Bug 11998: Make HoldsQueue.t tests pass [TO REVERT] This patch should not be the way to make these tests pass. The prefs should not be updated using set_preference, it will modify the values in the cache. I have no idea how to make them pass using the correct way, please help :) -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11998] Syspref caching issues
by bugzilla-daemon＠bugs.koha-community.org 10 Mar '16

10 Mar '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11998 --- Comment #132 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 48930 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48930&action=ed… Bug 11998: Use C4::Context->preference in Koha/Schema/Result/Item.pm Otherwise some tests won't pass -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11998] Syspref caching issues
by bugzilla-daemon＠bugs.koha-community.org 10 Mar '16

10 Mar '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11998 --- Comment #131 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 48929 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48929&action=ed… Bug 11998: Use t::lib::Mocks::mock_preference in tests Unless in t/db_dependent/Context.t where we want to test the cache behaviors. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11998] Syspref caching issues
by bugzilla-daemon＠bugs.koha-community.org 10 Mar '16

10 Mar '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11998 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48655|0 |1 is obsolete| | Attachment #48687|0 |1 is obsolete| | Attachment #48688|0 |1 is obsolete| | Attachment #48727|0 |1 is obsolete| | --- Comment #130 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 48928 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48928&action=ed… Bug 11998: Use Koha::Cache to cache sysprefs At the moment, the sysprefs are only cache in the thread memory executing the processus When using Plack, that means we need to clear the syspref cache on each page. To avoid that, we can use Koha::Cache to cache the sysprefs correctly. A big part of the authorship of this patch goes to Robin Sheat. Test plan: 1/ Add/Update/Delete local use prefs 2/ Update pref values and confirm that the changes are correctly taken into account Signed-off-by: Chris <chrisc(a)catalyst.net.nz> Signed-off-by: Josef Moravec <josef.moravec(a)gmail.com> Tested with plack with syspref cache enabled, there is some time between setting the syspref and applying it, but it takes just one reload of page, it shouldn't be problem, should it? -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13238] Improve heading on vendor search when searching for all vendors
by bugzilla-daemon＠bugs.koha-community.org 10 Mar '16

10 Mar '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13238 Aleisha Amohia <aleishaamohia(a)hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48915|0 |1 is obsolete| | --- Comment #8 from Aleisha Amohia <aleishaamohia(a)hotmail.com> --- Created attachment 48917 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48917&action=ed… Bug 13238: Improve heading on vendor search when searching for all vendors To test: 1) Go to Acquisitions and do an empty vendor search 2) Should now read "Vendor search: X results found" 3) Enter a search term and search for vendor 4) Should now read "Vendor search: Y results found for 'search term'" Sponsored-by: Catalyst IT NOTE: two nested if/else/end's could make it result/results, as suggested in comment #3. However, this meets my understanding of the problem as defined in comment #0. Signed-off-by: Mark Tompsett <mtompset(a)hotmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0