March 2016 - Koha-bugs - lists.koha-community.org

[Bug 13238] Improve heading on vendor search when searching for all vendors
by bugzilla-daemon＠bugs.koha-community.org 10 Mar '16

10 Mar '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13238 Aleisha Amohia <aleishaamohia(a)hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48915|0 |1 is obsolete| | --- Comment #8 from Aleisha Amohia <aleishaamohia(a)hotmail.com> --- Created attachment 48917 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48917&action=ed… Bug 13238: Improve heading on vendor search when searching for all vendors To test: 1) Go to Acquisitions and do an empty vendor search 2) Should now read "Vendor search: X results found" 3) Enter a search term and search for vendor 4) Should now read "Vendor search: Y results found for 'search term'" Sponsored-by: Catalyst IT NOTE: two nested if/else/end's could make it result/results, as suggested in comment #3. However, this meets my understanding of the problem as defined in comment #0. Signed-off-by: Mark Tompsett <mtompset(a)hotmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13238] Improve heading on vendor search when searching for all vendors
by bugzilla-daemon＠bugs.koha-community.org 10 Mar '16

10 Mar '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13238 Aleisha Amohia <aleishaamohia(a)hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13238] Improve heading on vendor search when searching for all vendors
by bugzilla-daemon＠bugs.koha-community.org 10 Mar '16

10 Mar '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13238 --- Comment #7 from Aleisha Amohia <aleishaamohia(a)hotmail.com> --- Actually before I make that change, the search heading will never show if there is only one result. It will just show the one vendor. Therefore, it doesn't need the s in brackets because that heading will only show if there is more than one result. So I'll take the brackets out. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13238] Improve heading on vendor search when searching for all vendors
by bugzilla-daemon＠bugs.koha-community.org 10 Mar '16

10 Mar '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13238 --- Comment #6 from Aleisha Amohia <aleishaamohia(a)hotmail.com> --- (In reply to M. Tompsett from comment #5) > NOTE: two nested if/else/end's could make it result/results, > as suggested in comment #3. However, this meets my understanding > of the problem as defined in comment #0. OH! I didn't understand this. Will make that change now. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13238] Improve heading on vendor search when searching for all vendors
by bugzilla-daemon＠bugs.koha-community.org 10 Mar '16

10 Mar '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13238 M. Tompsett <mtompset(a)hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48912|0 |1 is obsolete| | --- Comment #5 from M. Tompsett <mtompset(a)hotmail.com> --- Created attachment 48915 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48915&action=ed… Bug 13238: Improve heading on vendor search when searching for all vendors To test: 1) Go to Acquisitions and do an empty vendor search 2) Should now read "Vendor search: X result(s) found" 3) Enter a search term and search for vendor 4) Should now read "Vendor search: Y result(s) found for 'search term'" Sponsored-by: Catalyst IT NOTE: two nested if/else/end's could make it result/results, as suggested in comment #3. However, this meets my understanding of the problem as defined in comment #0. Signed-off-by: Mark Tompsett <mtompset(a)hotmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13238] Improve heading on vendor search when searching for all vendors
by bugzilla-daemon＠bugs.koha-community.org 10 Mar '16

10 Mar '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13238 M. Tompsett <mtompset(a)hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13238] Improve heading on vendor search when searching for all vendors
by bugzilla-daemon＠bugs.koha-community.org 10 Mar '16

10 Mar '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13238 Aleisha Amohia <aleishaamohia(a)hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48531|0 |1 is obsolete| | --- Comment #4 from Aleisha Amohia <aleishaamohia(a)hotmail.com> --- Created attachment 48912 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48912&action=ed… Bug 13238: Improve heading on vendor search when searching for all vendors To test: 1) Go to Acquisitions and do an empty vendor search 2) Should now read "Vendor search: X result(s) found" 3) Enter a search term and search for vendor 4) Should now read "Vendor search: Y result(s) found for 'search term'" Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13238] Improve heading on vendor search when searching for all vendors
by bugzilla-daemon＠bugs.koha-community.org 10 Mar '16

10 Mar '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13238 M. Tompsett <mtompset(a)hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset(a)hotmail.com --- Comment #3 from M. Tompsett <mtompset(a)hotmail.com> --- (In reply to M. Tompsett from comment #2) > Comment on attachment 48531 [details] [review] > > +<h1>[% count %] result(s) found for 'vendor: [% supplier %]'</h1> ... > http://template-toolkit.org/docs/manual/VMethods.html#section_length And you could even get the result/results nicer too, with a nested if/else/end. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13238] Improve heading on vendor search when searching for all vendors
by bugzilla-daemon＠bugs.koha-community.org 10 Mar '16

10 Mar '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13238 --- Comment #2 from M. Tompsett <mtompset(a)hotmail.com> --- Comment on attachment 48531 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48531 Bug 13238: Improve heading on vendor search when searching for all vendors Review of attachment 48531: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=132…) ----------------------------------------------------------------- This works, but: 2 result(s) found for 'vendor: ' still looks ugly for empty search term case, as mentioned in comment #0. ::: koha-tmpl/intranet-tmpl/prog/en/modules/acqui/booksellers.tt @@ +52,4 @@ > > [% INCLUDE 'acquisitions-toolbar.inc' %] > [% UNLESS ( count == 1 ) %] > +<h1>[% count %] result(s) found for 'vendor: [% supplier %]'</h1> Perhaps an [% IF (supplier.length>0) %] ... [% ELSE % ]<h1>[% count %] result(s) found</h1>[% END %] -- Except with nicer vertical spacing? http://template-toolkit.org/docs/manual/VMethods.html#section_length -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15953] New: Patroncards toolbar is now broken
by bugzilla-daemon＠bugs.koha-community.org 10 Mar '16

10 Mar '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15953 Bug ID: 15953 Summary: Patroncards toolbar is now broken Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: gmcharlt(a)gmail.com Reporter: aleishaamohia(a)hotmail.com QA Contact: testopia(a)bugs.koha-community.org Created attachment 48530 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48530&action=ed… toolbar In Koha version 3.23, the patroncards edit batch toolbar is broken. (Showing toolbar in attachment). Clicking the buttons does nothing. /cgi-bin/koha/patroncards/edit-batch.pl -- You are receiving this mail because: You are watching all bug changes.

1 3