March 2016 - Koha-bugs - lists.koha-community.org

[Bug 15585] Move C4::Passwordrecovery to Koha::Patron::Password::Reset
by bugzilla-daemon＠bugs.koha-community.org 09 Mar '16

09 Mar '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15585 --- Comment #14 from Blou <philippe.blouin(a)inlibro.com> --- Hey, I DID put a smiley :). Should have winked it, I knew it! But *I* do not need the QA on this one. Technically, my patch was #8753, this is just pure generosity toward the QA, actually. :-) (see, again :) Cheers! (Aside: I do believe that a good QA *must* be relentless and dare I say 'obsessive', and Devs must accept some frustration because good QAs are rare and very valuable to any organisation). -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13726] Koha::Acquisition::Bookseller should use Koha::Object
by bugzilla-daemon＠bugs.koha-community.org 09 Mar '16

09 Mar '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13726 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |16017 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16017 [Bug 16017] Currency constraints and poorly named prices -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13323] Change the tax rate on receiving
by bugzilla-daemon＠bugs.koha-community.org 09 Mar '16

09 Mar '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13323 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |16017 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16017 [Bug 16017] Currency constraints and poorly named prices -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15084] Move the currency related code to Koha::Acquisition::Currenc[y|ies]
by bugzilla-daemon＠bugs.koha-community.org 09 Mar '16

09 Mar '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15084 --- Comment #66 from Owen Leonard <oleonard(a)myacpl.org> --- (In reply to Marcel de Rooy from comment #65) > Resetting status Sorry, I assumed that since the status of this bug was "Passed QA" that the patches which git-bz would grab would be patches which were relevant to testing. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15084] Move the currency related code to Koha::Acquisition::Currenc[y|ies]
by bugzilla-daemon＠bugs.koha-community.org 09 Mar '16

09 Mar '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15084 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Passed QA --- Comment #65 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Resetting status -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15084] Move the currency related code to Koha::Acquisition::Currenc[y|ies]
by bugzilla-daemon＠bugs.koha-community.org 09 Mar '16

09 Mar '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15084 Owen Leonard <oleonard(a)myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Patch doesn't apply Blocks| |15962 --- Comment #64 from Owen Leonard <oleonard(a)myacpl.org> --- I tried to apply this in order to test Bug 15962 but there is a conflict: CONFLICT (add/add): Merge conflict in Koha/Acquisition/Currencies.pm Failed to merge in the changes. Patch failed at 0001 Bug 15084: Add Koha::Acquisition::Currenc[y|ies] classes Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15962 [Bug 15962] Currency deletion doesn't correctly identify currencies in use -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15585] Move C4::Passwordrecovery to Koha::Patron::Password::Reset
by bugzilla-daemon＠bugs.koha-community.org 09 Mar '16

09 Mar '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15585 --- Comment #13 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- (In reply to Blou from comment #11) > Still, I don't understand the obsession toward OOing everything, especially > in a non-OO language like Perl. Java created many obsessive behaviors and > even more ugly projects because of its misunderstood OO paradigm. (I'm not > calling our QA as having OCD, btw :-) Obsessive Compulsive Disorder ? Interesting. You still need the QA team on this report btw.. :) -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15084] Move the currency related code to Koha::Acquisition::Currenc[y|ies]
by bugzilla-daemon＠bugs.koha-community.org 09 Mar '16

09 Mar '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15084 --- Comment #63 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- (In reply to Marcel de Rooy from comment #61) > Note that another report should deal with adding missing constraints on > the currency code in suggestions and aqbooksellers. > Also note that the aqorder fields listprice and invoiceprice refer to > currency. Imo these are very poor names for currency codes; you should > never call something a price when you mean a currency code! Opened bug 16017 for Jonathan :) -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15084] Move the currency related code to Koha::Acquisition::Currenc[y|ies]
by bugzilla-daemon＠bugs.koha-community.org 09 Mar '16

09 Mar '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15084 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=16017 -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15084] Move the currency related code to Koha::Acquisition::Currenc[y|ies]
by bugzilla-daemon＠bugs.koha-community.org 09 Mar '16

09 Mar '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15084 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

1 0