March 2016 - Koha-bugs - lists.koha-community.org

[Bug 11998] Syspref caching issues
by bugzilla-daemon＠bugs.koha-community.org 09 Mar '16

09 Mar '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11998 --- Comment #127 from Jacek Ablewicz <abl(a)biblos.pk.edu.pl> --- (In reply to Jacek Ablewicz from comment #121) > C4::Context::read_config_file() is apparently called 2+ times per script run > allready: > > - 1st time when we do 'use Koha::Context;' anywhere > - 2nd time when we intialize the database connection in Koha::Database > via schema() / _new_schema() sub and 3rd time in C4/Auth_with_cas.pm (line 40) -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11998] Syspref caching issues
by bugzilla-daemon＠bugs.koha-community.org 09 Mar '16

09 Mar '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11998 --- Comment #126 from Jacek Ablewicz <abl(a)biblos.pk.edu.pl> --- (In reply to Jonathan Druart from comment #125) > Hi Jacek, > Did you try to profile a "real life" situation? catalogue/search.pl (159 search results, w/ 50 results displayed per page) It calls ->preference() 808 times, fetching 84 different preferences. Total time spent in ->preference() calls (excluding 1st call which triggers DBIx class loading = 250-300ms on this test server) 1) without patch, current master: 98 ms 2) without patch, Bug 13967 reverted: 11 ms 3) with patch & default caching system (Cache::Memory): 98 ms + 70 ms spent in ->get_from_cache() 4) with patch & memcached: 34 ms spent in ->get_from_cache() I have no idea how "typical" is that particular example... I expect that a given script will use somewhere around 50-100 different system preferences, but how many times will ->preference() be called on average is pretty much impossible to estimate (200 ... 1000 ... 2000 ?) Re/ caching system penalty in general - this patch will be probably not the biggest offender though; for example, Bug 11842 had bigger impact on catalogue/search.pl (150-350ms) - deserialising big, complex data structures in perl turns out to be quite expensive (especially if you do it 50 times per script run, like in this case). -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13624] Remove columns branchcode, categorytype from table overduerules_transport_types
by bugzilla-daemon＠bugs.koha-community.org 09 Mar '16

09 Mar '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13624 --- Comment #51 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- I think there should be existing examples for fixes like this - a change to the kohastructure accompanied by a database update. It should ideally check if the column is there already, so people don't get an error on updating in this case. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13624] Remove columns branchcode, categorytype from table overduerules_transport_types
by bugzilla-daemon＠bugs.koha-community.org 09 Mar '16

09 Mar '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13624 --- Comment #50 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- (In reply to Blou from comment #49) > So, we need a patch that corrects the pushed-to-master patch, for future > installations. AND that patch must also provide a fix to those who already > installed? Yes. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15381] Move the authority types related code to Koha::Authority::Type[s] - part 2
by bugzilla-daemon＠bugs.koha-community.org 09 Mar '16

09 Mar '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15381 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |16010 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16010 [Bug 16010] merge_authorities migration script is broken -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10612] Add ability to delete patrons with batch patron deletion tool
by bugzilla-daemon＠bugs.koha-community.org 09 Mar '16

09 Mar '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612 Nick Clemens <nick(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47478|0 |1 is obsolete| | --- Comment #68 from Nick Clemens <nick(a)bywatersolutions.com> --- Created attachment 48833 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48833&action=ed… Bug 10612 - Add ability to delete patrons with batch patron deletion tool This patch adds the ability to select a patron list for deletetion when using the Batch patron deletion/anonymization tool. It also adds buttons to the the patron lists table to access both the batch deletion and batch modification directly from the lists view. This is a squash of previous patches but now adds a patron_list_id parameter to C4::Members::GetBorrowersToExpunge and uses that routine to fetch patrons from a list. Test Plan: 1) Apply this patch 2) Create a list of patrons with the new Patron Lists feature 3) Try using the batch edit link form the lists table 4) Try using the batch delete link from the lists table 5) Verify previous functionality has not changed -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10612] Add ability to delete patrons with batch patron deletion tool
by bugzilla-daemon＠bugs.koha-community.org 09 Mar '16

09 Mar '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612 Nick Clemens <nick(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15331] Sort order breaks at offset=1000 (both OPAC and Intranet)
by bugzilla-daemon＠bugs.koha-community.org 09 Mar '16

09 Mar '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15331 Nick Clemens <nick(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick(a)bywatersolutions.com --- Comment #3 from Nick Clemens <nick(a)bywatersolutions.com> --- Is this valid then, or does sortmax/bug 7041 solve this? -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15642] Batch patron deletion should not delete patrons with issues
by bugzilla-daemon＠bugs.koha-community.org 09 Mar '16

09 Mar '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15642 Nick Clemens <nick(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |INVALID Status|In Discussion |RESOLVED -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12663] SCOUserCSS and SCOUserJS ignored on selfcheck login page.
by bugzilla-daemon＠bugs.koha-community.org 08 Mar '16

08 Mar '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12663 Nick Clemens <nick(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47318|0 |1 is obsolete| | Attachment #47319|0 |1 is obsolete| | --- Comment #16 from Nick Clemens <nick(a)bywatersolutions.com> --- Created attachment 48831 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48831&action=ed… Bug 12663 - SCOUserCSS and SCOUserJS ignored on selfcheck login page Currently if not logged in when browsing to http://YOURCATALOG/cgi-bin/koha/sco/sco-main.pl You are redirected to opac-auth.tt and SCOUserCSS and SCOUserJS are not loaded. This page passes through a parameter to the template to indicate this is an SCO login and appropriate CSS and JS should be loaded. Additionally this patch ensure that when loggin in using the form you are redirected to the sco-main.pl instead of the patron account page for the user. To test: 1 - Verify that normal login works on both staff and opac 2 - Verify that SCO link goes to login page if AutoSelfCheckAllowed is not allowed 3 - Enter changes into SCOUserJS and SCOUserCSS and observe these are present on SOC log in page 4 - Verify that a logged in opac user without permissions cannot access the self-checkout module 5 - Verify that AutoSelfCheckAllowed and associated system preferences function as expected 6 - Verify the AutoSelfCheck user is logged out if they attempt to visit another page -- You are receiving this mail because: You are watching all bug changes.

1 0