March 2016 - Koha-bugs - lists.koha-community.org

[Bug 15084] Move the currency related code to Koha::Acquisition::Currenc[y|ies]
by bugzilla-daemon＠bugs.koha-community.org 09 Mar '16

09 Mar '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15084 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15084] Move the currency related code to Koha::Acquisition::Currenc[y|ies]
by bugzilla-daemon＠bugs.koha-community.org 09 Mar '16

09 Mar '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15084 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15084] Move the currency related code to Koha::Acquisition::Currenc[y|ies]
by bugzilla-daemon＠bugs.koha-community.org 09 Mar '16

09 Mar '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15084 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15084] Move the currency related code to Koha::Acquisition::Currenc[y|ies]
by bugzilla-daemon＠bugs.koha-community.org 09 Mar '16

09 Mar '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15084 --- Comment #62 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- (In reply to Brendan Gallagher from comment #60) > Pushed the last two patches (48772 and 48783) Thanks Thanks. Don't forget the DBIx updates. I added a follow-up for what I discovered after the first kohastructure discrepancy, namely the currency length problem (3 vs 10 chars). I took the liberty to correct the dbrev for the currency constraint in aqorders directly. Also added an atomicupdate for a subsequent dbrev. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15084] Move the currency related code to Koha::Acquisition::Currenc[y|ies]
by bugzilla-daemon＠bugs.koha-community.org 09 Mar '16

09 Mar '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15084 --- Comment #61 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 48858 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48858&action=ed… Bug 15084: [QA Follow-up] Correct field length of currency Bug 15084 added a FK constraint while the fields in the database are not in sync as to length. This will produce errors when using currency codes longer than three characters. Probably you won't, but nobody stopped users from entering EURO or DOLLAR etc. Not to speak about TestBuilder too. This patch corrects the database revision for aqorders in updatedatabase, because we need to change the field length before adding the FK constraint. It also updates other currency fields < 10 chars (via atomicupdate). RM: So please add that dbrev too in updatedatabase. Note that another report should deal with adding missing constraints on the currency code in suggestions and aqbooksellers. Also note that the aqorder fields listprice and invoiceprice refer to currency. Imo these are very poor names for currency codes; you should never call something a price when you mean a currency code! Similar changes are applied to kohastructure. Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> Tested the db revisions. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11998] Syspref caching issues
by bugzilla-daemon＠bugs.koha-community.org 09 Mar '16

09 Mar '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11998 --- Comment #128 from Jacek Ablewicz <abl(a)biblos.pk.edu.pl> --- (In reply to Jacek Ablewicz from comment #126) > 3) with patch & default caching system (Cache::Memory): 98 ms + 70 ms spent > in ->get_from_cache() + 10 ms spent in ->set_in_cache() - sorry, forgot to include that statement run time Conclusion: Cache::Memory is not very efficient when used to store a lot of simple variables - probably because: - it's pure perl (?) - we currently serialize/deserialize all data types (including scalars) with freeze()/thaw() when using Cache::Memory Memcache is better (up to 2x on average) for simple variables - it's XS, and it serializes only complex data structures, but there is (more or less constant) 40usec penalty involved due to network latency/turnaround. Both chache systems are quite terrible for caching big, complex data structures (one MARC framework: 900 kilobytes; Cache::Memory is a bit faster then memcache in this case), mostly because they need to deserialize those structures each time when the data is fetched. We can try to use better serializer (Sereal etc.) - it may help speed up things for memcache (MARC framework storage size will go down to 300-100KB), but there is virtually nothing we can do to improve deserialization time. Instead, one can avoid doing the same expensive operation 50x times per script run, i.e. by implementing cache with 2+ levels (1st level being a simple hash or CHI::Driver::RawMemory for example, and 2nd level - memcache etc.) -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15294] Move the C4::Branch related code to Koha::Libraries - part 1
by bugzilla-daemon＠bugs.koha-community.org 09 Mar '16

09 Mar '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15294 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |16015 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16015 [Bug 16015] Cannot delete a group of libraries -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15887] New: Revise layout and behavior of item search fields management
by bugzilla-daemon＠bugs.koha-community.org 09 Mar '16

09 Mar '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15887 Bug ID: 15887 Summary: Revise layout and behavior of item search fields management Change sponsored?: --- Product: Koha Version: master Hardware: All URL: /cgi-bin/koha/admin/items_search_fields.pl OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard(a)myacpl.org Reporter: oleonard(a)myacpl.org QA Contact: testopia(a)bugs.koha-community.org CC: testopia(a)bugs.koha-community.org The item search fields management page is unusual in that it show the list of existing custom search fields on the same page as an add form. I propose to add some JavaScript to show and hide the add form in order to simplify the interface and give each task better focus. -- You are receiving this mail because: You are watching all bug changes.

1 18

[Bug 15380] Move the authority types related code to Koha::Authority::Type[s] - part 1
by bugzilla-daemon＠bugs.koha-community.org 09 Mar '16

09 Mar '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15380 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |16012 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16012 [Bug 16012] The default authority type is not editable -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 9805] Lost items are un-lost if returned, but not if renewed.
by bugzilla-daemon＠bugs.koha-community.org 09 Mar '16

09 Mar '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9805 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #39 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- t/db_dependent/Circulation/Renewal.t .. 1/7 DBD::mysql::st execute failed: Unknown column 'me.hold_fulfillment_policy' in 'field list' The Schema is wrong, you are adding default_branch_circ_rules.hold_fulfillment_policy, which is not in master. -- You are receiving this mail because: You are watching all bug changes.

1 0