March 2016 - Koha-bugs - lists.koha-community.org

[Bug 6934] New report Cash Register Statistics
by bugzilla-daemon＠bugs.koha-community.org 04 Mar '16

04 Mar '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6934 Héctor Eduardo Castro Avalos <hector.hecaxmmx(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Signed Off -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

1 0

[Bug 6934] New report Cash Register Statistics
by bugzilla-daemon＠bugs.koha-community.org 04 Mar '16

04 Mar '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6934 Héctor Eduardo Castro Avalos <hector.hecaxmmx(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48705|0 |1 is obsolete| | --- Comment #51 from Héctor Eduardo Castro Avalos <hector.hecaxmmx(a)gmail.com> --- Created attachment 48708 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48708&action=ed… [SIGNED-OFF]Bug 6934: second fix to calendars Signed-off-by: Hector Castro <hector.hecaxmmx(a)gmail.com> -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

1 0

[Bug 6934] New report Cash Register Statistics
by bugzilla-daemon＠bugs.koha-community.org 04 Mar '16

04 Mar '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6934 Héctor Eduardo Castro Avalos <hector.hecaxmmx(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48704|0 |1 is obsolete| | --- Comment #50 from Héctor Eduardo Castro Avalos <hector.hecaxmmx(a)gmail.com> --- Created attachment 48707 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48707&action=ed… [SIGNED-OFF]Bug 6934 Fixed Calendar and removed used of unexisting and unused C4::Budgets getCurrency Signed-off-by: Hector Castro <hector.hecaxmmx(a)gmail.com> -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

1 0

[Bug 6934] New report Cash Register Statistics
by bugzilla-daemon＠bugs.koha-community.org 04 Mar '16

04 Mar '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6934 Héctor Eduardo Castro Avalos <hector.hecaxmmx(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48634|0 |1 is obsolete| | --- Comment #49 from Héctor Eduardo Castro Avalos <hector.hecaxmmx(a)gmail.com> --- Created attachment 48706 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48706&action=ed… [SIGNED-OFF]Bug 6934: QA Follow-up Tried to address every single thing that QA mentioned : 1)Removed isNull function 2)Changed datepicker properly 3)We have to fill in two dates not to be flooded with old entries if we don't want to. 4)The first two fieldsets are now in one bigger field set 5)Removed the use of $fullreportname variable 6)Removed the use of dt_from_string when it already recieved a DT. 7)Removed comments starting with "###" in cash_register_stats.pl 8)Used Text::CSV::Encoded to generate the CSV file (used guided_reports.pl as an example) 9)I am not sure if using C4::Reports::Guided is the right choice here. I instead used the same column names as the one recieved by the query in cash_register_stats because this report uses columns from 5 different tables in addition of using both firstname and surname twice. For the ninth point, I would like to know more about C4::Reports::Guided if you still think using it would be a better solution. Thank you! Signed-off-by: Hector Castro <hector.hecaxmmx(a)gmail.com> -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

1 0

[Bug 6934] New report Cash Register Statistics
by bugzilla-daemon＠bugs.koha-community.org 04 Mar '16

04 Mar '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6934 --- Comment #48 from Rémi Mayrand-Provencher <remi.mayrand-provencher(a)inLibro.com> --- Really sorry, it was my mistake, I should have tested it again just before sending my patch. -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.

1 0

[Bug 6934] New report Cash Register Statistics
by bugzilla-daemon＠bugs.koha-community.org 04 Mar '16

04 Mar '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6934 --- Comment #47 from Rémi Mayrand-Provencher <remi.mayrand-provencher(a)inLibro.com> --- Created attachment 48705 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48705&action=ed… bug 6934 - second fix to calendars -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.

1 0

[Bug 6934] New report Cash Register Statistics
by bugzilla-daemon＠bugs.koha-community.org 04 Mar '16

04 Mar '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6934 Héctor Eduardo Castro Avalos <hector.hecaxmmx(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |In Discussion --- Comment #46 from Héctor Eduardo Castro Avalos <hector.hecaxmmx(a)gmail.com> --- (In reply to Rémi Mayrand-Provencher from comment #45) > This bug should be ready to be signed-off now, thank you for noticing that > the calendar weren't functionning as they should have. I Fixed that now. Sorry Rémi but doesn't work The message presented is: Form not submitted because of the following problem(s) ------------------------------------------------------------------- - Dates cannot be empty Probably about this bug: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15084 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

1 0

[Bug 15084] Move the currency related code to Koha::Acquisition::Currenc[y|ies]
by bugzilla-daemon＠bugs.koha-community.org 04 Mar '16

04 Mar '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15084 Héctor Eduardo Castro Avalos <hector.hecaxmmx(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15987 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15987 [Bug 15987] Acq module fails with undefined subroutine &main::GetCurrency -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14362] PEGI 15 Circulation/AgeRestrictionMarkers test fails
by bugzilla-daemon＠bugs.koha-community.org 04 Mar '16

04 Mar '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14362 Chris Cormack <chris(a)bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris(a)bigballofwax.co.nz -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14747] RESTful API with reverse proxy configuration
by bugzilla-daemon＠bugs.koha-community.org 04 Mar '16

04 Mar '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14747 Chris Cormack <chris(a)bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris(a)bigballofwax.co.nz -- You are receiving this mail because: You are watching all bug changes.

1 0