March 2016 - Koha-bugs - lists.koha-community.org

[Bug 15084] Move the currency related code to Koha::Acquisition::Currenc[y|ies]
by bugzilla-daemon＠bugs.koha-community.org 04 Mar '16

04 Mar '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15084 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy(a)rijksmuseum.nl --- Comment #50 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Are we still missing some things here? I see some problems related to aqorder and currency when running TestBuilder.t Looking further, I also saw a foreign key for currency in aqorders that does not appear in kohastructure (although that is not the solution yet). Also we need some DBIx updates for Koha/Schema/Result; is that a RM action? -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15436] Use semicolon between series name and volumne information
by bugzilla-daemon＠bugs.koha-community.org 04 Mar '16

04 Mar '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15436 Nicole C. Engard <nengard(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15436] Use semicolon between series name and volumne information
by bugzilla-daemon＠bugs.koha-community.org 04 Mar '16

04 Mar '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15436 --- Comment #7 from Nicole C. Engard <nengard(a)gmail.com> --- Created attachment 48696 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48696&action=ed… no difference in staff And there is no difference in the staff. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15436] Use semicolon between series name and volumne information
by bugzilla-daemon＠bugs.koha-community.org 04 Mar '16

04 Mar '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15436 Nicole C. Engard <nengard(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard(a)gmail.com --- Comment #6 from Nicole C. Engard <nengard(a)gmail.com> --- Created attachment 48695 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48695&action=ed… opac broken After applying this patch the OPAC display is completely broken. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15565] Place multiple holds at once for the same record
by bugzilla-daemon＠bugs.koha-community.org 04 Mar '16

04 Mar '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 Nick Clemens <nick(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick(a)bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14576] Allow arbitrary automatic update of location on checkin
by bugzilla-daemon＠bugs.koha-community.org 04 Mar '16

04 Mar '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14576 Owen Leonard <oleonard(a)myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #7 from Owen Leonard <oleonard(a)myacpl.org> --- A minor problem: FAIL C4/Circulation.pm OK critic FAIL forbidden patterns forbidden pattern: Data::Dumper::Dumper (line 1870) forbidden pattern: Data::Dumper::Dumper (line 1872) I think this text could be improved: " Item location updated from CART (Not an authorized value) to Fiction shelf " I think that should be "Item shelving location" (since "location" could be confused with "library"). I think the text "Not an authorized value" is not helpful to the user and is potentially scary. Think "UNAUTHOIRZED VALUE!!" I still have an issue with the data-entry aspect of this feature. In testing, I was stopped right away by having not put a space after the colon: 'FIC: CART' works 'FIC:CART' fails silently I don't think it's reasonable to expect the user to know this. For that matter, I don't think it's reasonable to expect the user to know the code for all existing shelving location authorized values. I realize this is an administrative setting, but I think we can do better. At minimum we need: - Text describing explicitly the correct format. - Some way to warn the user if their entry is incorrect. - Text explaining that an "_ALL_" rule overrides all others, or better: - Some way to warn the user if they have set an "_ALL_" rule along with other rules Overall this new patch is a great improvement over the last. But I still think we can do better. I think a separate template is needed, although I wouldn't fail the patch for that unless there was some consensus. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11998] Syspref caching issues
by bugzilla-daemon＠bugs.koha-community.org 04 Mar '16

04 Mar '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11998 --- Comment #111 from Kyle M Hall <kyle(a)bywatersolutions.com> --- This must be a caching issue. If I simply make this change: ok( exists($queue_item->{itype}), 'item type included in queued items list (bug 5825)' ); +warn "TEST: " . C4::Context->preference("StaticHoldsQueueWeight"); The tests begin to fail on master! I think the only reasonable solution is to mock the actual expected value for the time being and write a replacement for HoldsQueue.t from the ground up in time. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11998] Syspref caching issues
by bugzilla-daemon＠bugs.koha-community.org 04 Mar '16

04 Mar '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11998 Kyle M Hall <kyle(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle(a)bywatersolutions.com --- Comment #110 from Kyle M Hall <kyle(a)bywatersolutions.com> --- At some point in the tests, StaticHoldsQueueWeight becomes zero for reasons unknown and the unit tests rely on this bug! t/db_dependent/HoldsQueue.t .. 1..26 ok 1 - use C4::Reserves; ok 2 - use C4::HoldsQueue; 1 SET StaticHoldsQueueWeight: IggZam,xND8TnZydP,lfyZhGooM9 at t/db_dependent/HoldsQueue.t line 74. StaticHoldsQueueWeight: IggZam,xND8TnZydP,lfyZhGooM9 at /home/vagrant/kohaclone/C4/HoldsQueue.pm line 620. ok 3 - take from homebranch (don't use cost matrix) pick up branch ok 4 - take from homebranch (don't use cost matrix) holding branch ok 5 - take from homebranch (use cost matrix) pick up branch ok 6 - take from homebranch (use cost matrix) holding branch StaticHoldsQueueWeight: IggZam,xND8TnZydP,lfyZhGooM9 at /home/vagrant/kohaclone/C4/HoldsQueue.pm line 620. ok 7 - take from holdingbranch (don't use cost matrix) pick up branch ok 8 - take from holdingbranch (don't use cost matrix) holding branch ok 9 - take from holdingbranch (use cost matrix) pick up branch ok 10 - take from holdingbranch (use cost matrix) holding branch StaticHoldsQueueWeight: IggZam,xND8TnZydP,lfyZhGooM9 at /home/vagrant/kohaclone/C4/HoldsQueue.pm line 620. ok 11 - take from lowest cost branch (don't use cost matrix) pick up branch ok 12 - take from lowest cost branch (don't use cost matrix) holding branch ok 13 - take from lowest cost branch (use cost matrix) pick up branch ok 14 - take from lowest cost branch (use cost matrix) holding branch ok 15 - GetHoldsQueueItems ok 16 - item type included in queued items list (bug 5825) ok 17 - C4::HoldsQueue::least_cost_branch returns the local branch if it is in the list of branches to pull from StaticHoldsQueueWeight: 0 at /home/vagrant/kohaclone/C4/HoldsQueue.pm line 620. ok 18 - Holds queue filling correct number for default holds policy 'from home library' ok 19 - Holds queue filling 1st correct hold for default holds policy 'from home library' ok 20 - Holds queue filling 2nd correct hold for default holds policy 'from home library' ok 21 - Is today a holiday for pickup branch StaticHoldsQueueWeight: 0 at /home/vagrant/kohaclone/C4/HoldsQueue.pm line 620. ok 22 - Holds not filled with items from closed libraries StaticHoldsQueueWeight: 0 at /home/vagrant/kohaclone/C4/HoldsQueue.pm line 620. ok 23 - Holds queue filling correct number for holds for default holds policy 'from any library' StaticHoldsQueueWeight: 0 at /home/vagrant/kohaclone/C4/HoldsQueue.pm line 620. ok 24 - Holds not filled with items from closed libraries 2 SET StaticHoldsQueueWeight: wVjTn,QwXVJjV,IhgDeror at t/db_dependent/HoldsQueue.t line 395. StaticHoldsQueueWeight: 0 at /home/vagrant/kohaclone/C4/HoldsQueue.pm line 620. ok 25 - Bug 14297 - Holds Queue building ignoring holds where pickup & home branch don't match and item is not from le ok 26 - Bug 15062 - Holds queue with Transport Cost Matrix will transfer item even if transfers disabled -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14306] Show URL from MARC21 field 555$u in basket and detail
by bugzilla-daemon＠bugs.koha-community.org 04 Mar '16

04 Mar '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14306 --- Comment #31 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- (In reply to Katrin Fischer from comment #30) > Signed-off-by: Katrin Fischer <katrin.fischer.83(a)web.de> Great. Thx -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 6934] New report Cash Register Statistics
by bugzilla-daemon＠bugs.koha-community.org 04 Mar '16

04 Mar '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6934 --- Comment #43 from Héctor Eduardo Castro Avalos <hector.hecaxmmx(a)gmail.com> --- Hi Rémi About my comment 40, i don't know if is that the behavior expected, or, needs to be corrected? Is the patch ready to sign-off? If yes, I'll sign-off immediately. Regards -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.

1 0