March 2016 - Koha-bugs - lists.koha-community.org

[Bug 11998] Syspref caching issues
by bugzilla-daemon＠bugs.koha-community.org 04 Mar '16

04 Mar '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11998 --- Comment #109 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- (In reply to Jonathan Druart from comment #108) > (In reply to Jonathan Druart from comment #105) > > Created attachment 48687 [details] [review] [review] > > Bug 11998: Use t::lib::Mocks::mock_preference in tests > > > > Unless in t/db_dependent/Context.t where we want to test the cache > > behaviors. > > Note that tests in t/db_dependent/HoldsQueue.t do not pass, but I have no > idea why! If you use this file (modified by this patch) and prove it on top of master, they don't pass neither. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11998] Syspref caching issues
by bugzilla-daemon＠bugs.koha-community.org 04 Mar '16

04 Mar '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11998 --- Comment #108 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- (In reply to Jonathan Druart from comment #105) > Created attachment 48687 [details] [review] > Bug 11998: Use t::lib::Mocks::mock_preference in tests > > Unless in t/db_dependent/Context.t where we want to test the cache > behaviors. Note that tests in t/db_dependent/HoldsQueue.t do not pass, but I have no idea why! -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11998] Syspref caching issues
by bugzilla-daemon＠bugs.koha-community.org 04 Mar '16

04 Mar '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11998 --- Comment #107 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- (In reply to Jacek Ablewicz from comment #104) > - bunch of t/* tests (quite o lot of them) is still using ->set_preference() > insted of mock_preference() - they don't commit changes to the database, but > running them may now result in syspref "cache poisoning", affecting > behaviour of the other processes Yes, that is addressed in the last 2 patches. > - remaining code chunks which are dealing with systempreferences table > directly (installer, updatedatabase.pl, some tests and admin/maintenance > scripts); updatedatabase.pl seems to be OK (at least at the 1st glance), not > sure about installer - it does call clear_syspref_cache() 1+ time, but not > necessarily everywhere where it should do it / not at the each and every > step (?) Yes, we should replace them, and avoid to update/insert sysprefs during the update DB process. > - up to now, when a given script retrieved some preference once, it was > guaranted that all subsequent ->preference() calls during the script run > will return the same value; now it will always use the current value instead > - I guess sometimes that will be a good thing, and sometimes not so much - > but probably not very important in practical circumstances Theoretically it could be an issue but, as you said, I don't think it could be a problem in practice. > Also there will be some (hopefully very) little performace hit due to > caching system overheads (and 10 sec deafult expire in case of Cache::Memory > - but it will affect only the long-running scripts) - how little, it remains > to be seen ;) In conjunction with other patches (depending on this bug report), I am expecting a gain. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11998] Syspref caching issues
by bugzilla-daemon＠bugs.koha-community.org 04 Mar '16

04 Mar '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11998 --- Comment #106 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 48688 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48688&action=ed… Bug 11998: Use C4::Context->preference in Koha/Schema/Result/Item.pm Otherwise some tests won't pass -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11998] Syspref caching issues
by bugzilla-daemon＠bugs.koha-community.org 04 Mar '16

04 Mar '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11998 --- Comment #105 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 48687 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48687&action=ed… Bug 11998: Use t::lib::Mocks::mock_preference in tests Unless in t/db_dependent/Context.t where we want to test the cache behaviors. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14306] Show URL from MARC21 field 555$u in basket and detail
by bugzilla-daemon＠bugs.koha-community.org 04 Mar '16

04 Mar '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14306 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46254|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14306] Show URL from MARC21 field 555$u in basket and detail
by bugzilla-daemon＠bugs.koha-community.org 04 Mar '16

04 Mar '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14306 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46253|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14306] Show URL from MARC21 field 555$u in basket and detail
by bugzilla-daemon＠bugs.koha-community.org 04 Mar '16

04 Mar '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14306 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46252|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14306] Show URL from MARC21 field 555$u in basket and detail
by bugzilla-daemon＠bugs.koha-community.org 04 Mar '16

04 Mar '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14306 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46251|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14306] Show URL from MARC21 field 555$u in basket and detail
by bugzilla-daemon＠bugs.koha-community.org 04 Mar '16

04 Mar '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14306 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

1 0