March 2016 - Koha-bugs - lists.koha-community.org

[Bug 13871] OverDrive message when user authentication fails
by bugzilla-daemon＠bugs.koha-community.org 04 Mar '16

04 Mar '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13871 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=15956 -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15653] Updating a guarantor has never updated its guarantees
by bugzilla-daemon＠bugs.koha-community.org 04 Mar '16

04 Mar '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15653 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47265|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 48662 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48662&action=ed… Bug 15653: Remove unused C4::Members::UpdateGuarantees subroutine Looking at the code, there is some broken with the guarantees code. It seems that the expected behavior would be to update address, fax, B_city, mobile, city and phone info of the guarantees when a guarantor is modified. But the code in C4::Members::ModMember is broken: 668 my $borrowercategory= GetBorrowercategory( $data{'category_type'} ); 669 if ( exists $borrowercategory->{'category_type'} && $borrowercategory->{'category_type'} eq ('A' || 'S') ) { 670 # is adult check guarantees; 671 UpdateGuarantees(%data); 672 } First, GetBorrowerCategory expects a categorycode, not a category_type. Then UpdateGuarantees retrieves the param like: 989 sub UpdateGuarantees { 990 my %data = shift; Which means that %data will always be something like ( a_key => undef ) And nothing more. The updateguarantees subroutine (It has been renamed) has been introduced by commit 56825e415fc232e38f0a874dc9a81fa2169ef06b Date: Mon Aug 30 13:48:58 2004 +0000 modularizing (with Members.pm) members management (beginning of...) And the `%data = shift` already existed... This code has never worked and could be removed. See http://lists.koha-community.org/pipermail/koha-devel/2016-January/042241.ht… Test plan: Confirm the previous assertions. Note that I have found this bug working on bug 15631, see patch "Bug 15631: Koha::Cities - remove getidcity and GetCities" Signed-off-by: Hector Castro <hector.hecaxmmx(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11998] Syspref caching issues
by bugzilla-daemon＠bugs.koha-community.org 04 Mar '16

04 Mar '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11998 --- Comment #103 from Josef Moravec <josef.moravec(a)gmail.com> --- It looks like it is just 1 or 2 seconds max, so it is absolutely OK ;) -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 2505] Omnibus: Enable Perl warnings in all modules and scripts
by bugzilla-daemon＠bugs.koha-community.org 04 Mar '16

04 Mar '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2505 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34442|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 2505] Omnibus: Enable Perl warnings in all modules and scripts
by bugzilla-daemon＠bugs.koha-community.org 04 Mar '16

04 Mar '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2505 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |NEW -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 2505] Omnibus: Enable Perl warnings in all modules and scripts
by bugzilla-daemon＠bugs.koha-community.org 04 Mar '16

04 Mar '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2505 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |ASSIGNED CC| |jonathan.druart(a)bugs.koha-c | |ommunity.org --- Comment #26 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Modern::Perl is used in C4::Ris since bug 12357. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14377] Indicate that a record is suppressed in staff client
by bugzilla-daemon＠bugs.koha-community.org 04 Mar '16

04 Mar '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14377 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off --- Comment #37 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Rebase, easy conflict with bug 4941 fixed. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14377] Indicate that a record is suppressed in staff client
by bugzilla-daemon＠bugs.koha-community.org 04 Mar '16

04 Mar '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14377 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46993|0 |1 is obsolete| | --- Comment #36 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 48661 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48661&action=ed… Bug 14377 [QA Followup] - Don't do 942$n processing for UNIMARC -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14377] Indicate that a record is suppressed in staff client
by bugzilla-daemon＠bugs.koha-community.org 04 Mar '16

04 Mar '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14377 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46900|0 |1 is obsolete| | --- Comment #35 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 48660 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48660&action=ed… Bug 14377 [QA Followup] - Add support for NORMARC -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14377] Indicate that a record is suppressed in staff client
by bugzilla-daemon＠bugs.koha-community.org 04 Mar '16

04 Mar '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14377 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45568|0 |1 is obsolete| | --- Comment #34 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 48659 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48659&action=ed… Bug 14377 [QA Followup] - Remove biblionumber, move message to below title for search results -- You are receiving this mail because: You are watching all bug changes.

1 0