March 2016 - Koha-bugs - lists.koha-community.org

[Bug 11998] Syspref caching issues
by bugzilla-daemon＠bugs.koha-community.org 04 Mar '16

04 Mar '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11998 --- Comment #104 from Jacek Ablewicz <abl(a)biblos.pk.edu.pl> --- Code itself looks fine to me, but I'm a bit worried about some potential problems this patch may introduce indirectly. As it would be now possible to set up permanent & shared cache for system preferences (memcache, fastmmap), in such installations we may expect some extra troubles, e.g. with: - bunch of t/* tests (quite o lot of them) is still using ->set_preference() insted of mock_preference() - they don't commit changes to the database, but running them may now result in syspref "cache poisoning", affecting behaviour of the other processes - remaining code chunks which are dealing with systempreferences table directly (installer, updatedatabase.pl, some tests and admin/maintenance scripts); updatedatabase.pl seems to be OK (at least at the 1st glance), not sure about installer - it does call clear_syspref_cache() 1+ time, but not necessarily everywhere where it should do it / not at the each and every step (?) - up to now, when a given script retrieved some preference once, it was guaranted that all subsequent ->preference() calls during the script run will return the same value; now it will always use the current value instead - I guess sometimes that will be a good thing, and sometimes not so much - but probably not very important in practical circumstances Also there will be some (hopefully very) little performace hit due to caching system overheads (and 10 sec deafult expire in case of Cache::Memory - but it will affect only the long-running scripts) - how little, it remains to be seen ;) -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 5404] C4::Koha::subfield_is_koha_internal_p no longer serves a purpose
by bugzilla-daemon＠bugs.koha-community.org 04 Mar '16

04 Mar '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5404 --- Comment #19 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- (In reply to Marcel de Rooy from comment #18) > Created attachment 48675 [details] [review] > Bug 5404: [QA Follow-up] Add test descriptions > > Adding descriptions for changes in t/db_dependent/Biblio.t. Oops forgot that, thanks for the follow-up! -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12606] TestBuilder - Refactoring Acquisition/GetOrdersByBiblionumber.t
by bugzilla-daemon＠bugs.koha-community.org 04 Mar '16

04 Mar '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12606 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart(a)bugs.koha-c | |ommunity.org Status|Patch doesn't apply |RESOLVED Resolution|--- |WONTFIX --- Comment #4 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- This is not needed anymore. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12607] TestBuilder - Refactoring Acquisition/GetBasketsInfosByBookseller.t
by bugzilla-daemon＠bugs.koha-community.org 04 Mar '16

04 Mar '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12607 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |WONTFIX CC| |jonathan.druart(a)bugs.koha-c | |ommunity.org Status|Patch doesn't apply |RESOLVED --- Comment #4 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- This is not needed anymore. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11203] Datatables in acqusitions do not ignore "stopwords" in titles
by bugzilla-daemon＠bugs.koha-community.org 04 Mar '16

04 Mar '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11203 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22818|0 |1 is obsolete| | --- Comment #13 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 48677 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48677&action=ed… Bug 11203 - Datatables in acqusitions do not ignore "stopwords" in titles Sorting by the "summary" column does not produce the preferred results. Title beginning with 'a', 'an', or 'the' are sorted using those articles. Test plan: 1) Place an order for 2 items with the titles "Alpha" and "The Alpha", along with some other records with titles starting with something between 'a' and 't', and 't' and 'z' 2) Sort the "pending orders" table, note the incorrect sorting 3) Receive all the items 4) Sort the "already received" table, note the incorrect sorting 5) Apply the patch 6) Repeat steps 1-4, note the corrected sorting 7) Check acqui/basket.pl for correct sorting 8) Check acqui/invoice.pl for correct sorting JD: Disclaimer: I have not tested this patch, just rebased it. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11203] Datatables in acqusitions do not ignore "stopwords" in titles
by bugzilla-daemon＠bugs.koha-community.org 04 Mar '16

04 Mar '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11203 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10697] Revert from using GetReserveStatus to use CheckReserves
by bugzilla-daemon＠bugs.koha-community.org 04 Mar '16

04 Mar '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10697 --- Comment #13 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Comment on attachment 20164 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20164 Bug 10697 - Adding more unit tests to CheckReserves Review of attachment 20164: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=106…) ----------------------------------------------------------------- Is it still valid? ::: t/db_dependent/Reserves.t @@ +130,5 @@ > + $constraint, $bibitems, $priority, $resdate, $expdate, $notes, > + $title, undef, $found); > + > +($status, $reserve, $all_reserves) = CheckReserves($itemnumber2); > +is($status,"Reserved", "Reserved - title level hold, still on shelf"); Why are we expecting "Reserved"? If I understand correctly the tests, there is not hold at this point. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 5404] C4::Koha::subfield_is_koha_internal_p no longer serves a purpose
by bugzilla-daemon＠bugs.koha-community.org 04 Mar '16

04 Mar '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5404 --- Comment #18 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 48675 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48675&action=ed… Bug 5404: [QA Follow-up] Add test descriptions Adding descriptions for changes in t/db_dependent/Biblio.t. Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 5404] C4::Koha::subfield_is_koha_internal_p no longer serves a purpose
by bugzilla-daemon＠bugs.koha-community.org 04 Mar '16

04 Mar '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5404 --- Comment #17 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 48674 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48674&action=ed… Bug 5404: Move the test to a new IsMarcStructureInternal sub Signed-off-by: Josef Moravec <josef.moravec(a)gmail.com> Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 5404] C4::Koha::subfield_is_koha_internal_p no longer serves a purpose
by bugzilla-daemon＠bugs.koha-community.org 04 Mar '16

04 Mar '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5404 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48099|0 |1 is obsolete| | Attachment #48478|0 |1 is obsolete| | --- Comment #16 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 48673 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48673&action=ed… Bug 5404: C4::Koha - remove subfield_is_koha_internal_p The commit b5ecefd485a75d54a5fa26fff5a0cc890541e2c3 Date: Mon Feb 3 18:46:00 2003 +0000 had a funny description: Added function to check if a MARC subfield name is "koha-internal" (instead of checking it for 'lib' and 'tag' everywhere); temporarily added to Koha.pm "Temporarily", since 2003, everything is relative, isn't it? :) The thing is that GetMarcStructure returns hash like field_200 => { subfield_a => { %attributes_of_subfield_a }, %attributes_of_field_200 } The attributes for field_200 can be 'repeatable', 'mandatory', 'tag', 'lib'. We don't want to loop on these values when looping on subfields. Since there are just { k => v } with v is a scalar (string), it's easier to test if we are processing a subfield testing the reference. At some places, we don't need to test that, we are looping on values from MARC::Field->subfields which are always valid subfields. Test plan: 1/ Edit items using the batch item mod tool 2/ display and edit items via the cataloguing module. You should not see any changes between before and after the patch applied. Tech notes: We need to check what we are processing when we loop on 'subfields' from GetMarcStructure, not from MARC::Field->subfields. Signed-off-by: Josef Moravec <josef.moravec(a)gmail.com> Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

1 0