March 2016 - Koha-bugs - lists.koha-community.org

[Bug 5404] C4::Koha::subfield_is_koha_internal_p no longer serves a purpose
by bugzilla-daemon＠bugs.koha-community.org 04 Mar '16

04 Mar '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5404 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13871] OverDrive message when user authentication fails
by bugzilla-daemon＠bugs.koha-community.org 04 Mar '16

04 Mar '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13871 --- Comment #49 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 48672 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48672&action=ed… Bug 13871: [QA Follow-up] Add $server for FID_SCREEN_MSG When you are ready, you still see that small detail. Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13871] OverDrive message when user authentication fails
by bugzilla-daemon＠bugs.koha-community.org 04 Mar '16

04 Mar '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13871 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch QA Contact|testopia(a)bugs.koha-communit |m.de.rooy(a)rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13871] OverDrive message when user authentication fails
by bugzilla-daemon＠bugs.koha-community.org 04 Mar '16

04 Mar '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13871 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #48 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- QA Comment: Since this patch waited much too long, I have been working somewhat more on it to get it thru QA. My main concerns were: [1] Change of behavior when sending correct card number but invalid password. We should get patron info with BL=Y and CQ=N. Your patch changed the if-structure and handled this situation similar to wrong card number. So no patron information. Handled in a followup. [2] Adding a SIPconfig attribute like overdrivemode or msg_invalid_credentials is not really needed. If we can prevent adding such "prefs", the code will be simpler. Although the response contains BL and CQ to inform about the checked credentials, we could just send "Invalid card number" if there is no card (add AF here). If the card is OK and the pw is not, we could add Invalid pw to the existing AF. This does not harm anyone. Handled in a followup. [3] We should have a look at Patron Info too. Added a followup. Added a new report for additional unit tests for changes in Patron Status/Patron Info. Passed QA -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13871] OverDrive message when user authentication fails
by bugzilla-daemon＠bugs.koha-community.org 04 Mar '16

04 Mar '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13871 --- Comment #47 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 48671 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48671&action=ed… Bug 13871: [QA Follow-up] Adjust Patron Info Request Conform QA comment, Patron Info request is slightly adjusted to be consistent with changes to Patron Status request. If the cardnumber is ok and the password is wrong, BL=N is reported but also add 'Invalid password' in AF. Additionally, an invalid card number is reported in AF. Test plan: [1] Send patron info request for invalid card. [2] Idem for valid card, no password. [3] Idem for valid card, good password. [4] Idem for valid card, wrong password. Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> Verified by telnetting SIP server. And tested additionally with the new unit test of bug 15956. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13871] OverDrive message when user authentication fails
by bugzilla-daemon＠bugs.koha-community.org 04 Mar '16

04 Mar '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13871 --- Comment #46 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 48670 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48670&action=ed… Bug 13871: [QA Follow-up] Adjust Patron Status Request Conform QA comment on Bugzilla, we do this: [1] Attribute for overdrive mode/invalid credentials is not really needed. We can always pass a screen message that card or password is invalid. [2] If the cardnumber is correct and the password is wrong, we should still honour the request. The bad password is recognized by BLN and an additional message in AF. Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> Verified by telnetting SIP server. And tested additionally with the new unit test of bug 15956. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13871] OverDrive message when user authentication fails
by bugzilla-daemon＠bugs.koha-community.org 04 Mar '16

04 Mar '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13871 --- Comment #45 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 48669 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48669&action=ed… Bug 13871 - OverDrive message when user authentication fails NOTE: apply this patch after the additional perltidy patch this patch is basically a small work-around to fix some confusing login text, when users enter incorrect auth details via Overdrive's website with this option disabled (default) there is no change to SIP's behaviour to test... 1/ configure your overdrive account to talk to your Koha's SIP service 2/ start Koha's SIP 3/ enter a correct username and correct password in overdrive see overdrive display '(1) Greetings from Koha' (good) 4/ enter a correct username and *incorrect* password in overdrive see overdrive display '(1) Greetings from Koha' (bad) 5/ enter an incorrect username in overdrive see overdrive display '(1)' (badder) 6/ apply patch, enable 'overdrive-mode' in Koha's SIPConfig.xml example... --------------------- <accounts> <login id="kohasip" password="xxxxx" delimiter="|" error-detect="enabled" institution="YYY" overdrive-mode="1" /> </accounts> --------------------- 7/ restart SIP 8/ enter a correct username and correct password see overdrive display '(1) Greetings from Koha' 9/ enter a correct username and *incorrect* password see overdrive display '(1) Invalid patron or patron password' 10/ enter an incorrect username and incorrect password see overdrive display '(1) Invalid patron or patron password' http://bugs.koha-community.org/show_bug.cgi?id=1387 Signed-off-by: Kyle M Hall <kyle(a)bywatersolutions.com> Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13871] OverDrive message when user authentication fails
by bugzilla-daemon＠bugs.koha-community.org 04 Mar '16

04 Mar '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13871 --- Comment #44 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 48668 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48668&action=ed… Bug 13871: [TITLE_AMENDED] Additional changes The original perltidy patch from Mason has been amended. The perltidy itself has been moved to a separate patch with the current perltidyrc applied. As noted on Bugzilla, the original perltidy patch included some extra changes: [1] You prefix timestamp with Sip This is not actually needed (it is imported), but if we should prefix it, we should prefix now with C4::SIP::Sip. But you only changed two occurrences (out of 26). So I remove these two changes. [2] You remove the $server parameter from two calls of maybe_add: A closer look at the remaining code tells me that $server is always passed to maybe_add for FID_SCREEN_MSG. So this only left me the current whitespace change. But at least we documented what we did or did not, and why.. Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13871] OverDrive message when user authentication fails
by bugzilla-daemon＠bugs.koha-community.org 04 Mar '16

04 Mar '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13871 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48386|0 |1 is obsolete| | Attachment #48387|0 |1 is obsolete| | Attachment #48392|0 |1 is obsolete| | Attachment #48393|0 |1 is obsolete| | --- Comment #43 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 48667 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48667&action=ed… Bug 13871: Adjusted perl tidy on MsgType.pm Run perltidy pro=xt/perltidyrc on the file. Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13871] OverDrive message when user authentication fails
by bugzilla-daemon＠bugs.koha-community.org 04 Mar '16

04 Mar '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13871 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15956 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15956 [Bug 15956] Rearranging some SIP unit tests (test without SIP server) -- You are receiving this mail because: You are watching all bug changes.

1 0