April 2016 - Koha-bugs - lists.koha-community.org

[Bug 15263] XSLT display fetches sysprefs for every result processed
by bugzilla-daemon＠bugs.koha-community.org 21 Apr '16

21 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15263 Tomás Cohen Arazi <tomascohen(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #50474|0 |1 is obsolete| | --- Comment #19 from Tomás Cohen Arazi <tomascohen(a)gmail.com> --- Created attachment 50506 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50506&action=ed… Bug 15263: (QA followup) Use the new XSLTParse4Display everywhere Edit: fixed catalogue/detail.pl and opac/opac-detail.pl so they use the right XSLT syspref. Signed-off-by: Tomas Cohen Arazi <tomascohen(a)theke.io> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15263] XSLT display fetches sysprefs for every result processed
by bugzilla-daemon＠bugs.koha-community.org 21 Apr '16

21 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15263 Tomás Cohen Arazi <tomascohen(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 16287] New: Can't accept list share invitation
by bugzilla-daemon＠bugs.koha-community.org 21 Apr '16

21 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16287 Bug ID: 16287 Summary: Can't accept list share invitation Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Lists Assignee: gmcharlt(a)gmail.com Reporter: oleonard(a)myacpl.org QA Contact: testopia(a)bugs.koha-community.org CC: m.de.rooy(a)rijksmuseum.nl Steps to reproduce: 1. Create a private list. 2. Enable the OpacAllowSharingPrivateLists system preference. 3. Log into the OPAC and share your private list with an email address which corresponds to a patron in Koha. 4. Process your message queue if necessary. 5. Check the email account you shared the list with. Copy the the link in the message. 6. Log into the OPAC using the account corresponding to that email address. 7. Paste the link you copied from the email. An error will be triggered: DBIx::Class::Storage::DBI::_dbh_execute(): Unknown column 'sharedate desc' in 'order clause' at Koha/Objects.pm line 150 -- You are receiving this mail because: You are watching all bug changes.

1 1

[Bug 10459] borrowers should have a timestamp
by bugzilla-daemon＠bugs.koha-community.org 21 Apr '16

21 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10459 --- Comment #30 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- (In reply to M. Tompsett from comment #29) > Because while thinking about that very problem, I found: > DROP TABLE IF EXISTS `borrower_debarments`; > CREATE TABLE borrower_debarments ( -- tracks restrictions on the patron's > record > borrower_debarment_id int(11) NOT NULL AUTO_INCREMENT, -- unique key for > the restriction > borrowernumber int(11) NOT NULL, -- foreign key for > borrowers.borrowernumber for patron who is restricted > expiration date DEFAULT NULL, -- expiration date of the restriction > `type` enum('SUSPENSION','OVERDUES','MANUAL','DISCHARGE') NOT NULL DEFAULT > 'MANUAL', -- type of restriction > `comment` text, -- comments about the restriction > manager_id int(11) DEFAULT NULL, -- foreign key for > borrowers.borrowernumber for the librarian managing the restriction > created timestamp NOT NULL DEFAULT CURRENT_TIMESTAMP ON UPDATE > CURRENT_TIMESTAMP, -- date the restriction was added > updated timestamp NULL DEFAULT NULL, -- date the restriction was updated > PRIMARY KEY (borrower_debarment_id), > KEY borrowernumber (borrowernumber), > CONSTRAINT `borrower_debarments_ibfk_1` FOREIGN KEY (`borrowernumber`) > REFERENCES `borrowers` (`borrowernumber`) > ON DELETE CASCADE ON UPDATE CASCADE > ) ENGINE=InnoDB DEFAULT CHARSET=utf8 COLLATE=utf8_unicode_ci; > > I think there is a logic error on the created timestamp. That is, I think > the ON UPDATE clause should be on the updated timestamp. Good catch. Proving at the same time that we did not adhere to just timestamp everywhere in Koha :) And I am not saying that we should, but others did.. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10459] borrowers should have a timestamp
by bugzilla-daemon＠bugs.koha-community.org 21 Apr '16

21 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10459 --- Comment #29 from M. Tompsett <mtompset(a)hotmail.com> --- (In reply to Marcel de Rooy from comment #27) > Thanks for reviving this. > The reason I left this pending however, is probably as valid as then. > If you call the field timestamp, we will have clashes in SQL joins here and > there in the codebase where another table also has the same field timestamp. > Especially think about the SELECT * statements with timestamp in another > clause as well. So to prevent the ambiguous column name errors, we need to > track these cases, test.. and hope we found them all. > An older alternative to add bortimestamp, introducing a new name, did not > meet much approval. The problem is there are so many already with timestamp, I was thinking a "rename the timestamp fields" bug would be a reasonable next step. I don't see an immediate need to push this through right now. If there is a this bug blocks that renaming bug, that would be a good next step. Part of the discussion needs to be how to name timestamps. Because while thinking about that very problem, I found: DROP TABLE IF EXISTS `borrower_debarments`; CREATE TABLE borrower_debarments ( -- tracks restrictions on the patron's record borrower_debarment_id int(11) NOT NULL AUTO_INCREMENT, -- unique key for the restriction borrowernumber int(11) NOT NULL, -- foreign key for borrowers.borrowernumber for patron who is restricted expiration date DEFAULT NULL, -- expiration date of the restriction `type` enum('SUSPENSION','OVERDUES','MANUAL','DISCHARGE') NOT NULL DEFAULT 'MANUAL', -- type of restriction `comment` text, -- comments about the restriction manager_id int(11) DEFAULT NULL, -- foreign key for borrowers.borrowernumber for the librarian managing the restriction created timestamp NOT NULL DEFAULT CURRENT_TIMESTAMP ON UPDATE CURRENT_TIMESTAMP, -- date the restriction was added updated timestamp NULL DEFAULT NULL, -- date the restriction was updated PRIMARY KEY (borrower_debarment_id), KEY borrowernumber (borrowernumber), CONSTRAINT `borrower_debarments_ibfk_1` FOREIGN KEY (`borrowernumber`) REFERENCES `borrowers` (`borrowernumber`) ON DELETE CASCADE ON UPDATE CASCADE ) ENGINE=InnoDB DEFAULT CHARSET=utf8 COLLATE=utf8_unicode_ci; I think there is a logic error on the created timestamp. That is, I think the ON UPDATE clause should be on the updated timestamp. In short, timestamps that do exist in Koha are messy. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15263] XSLT display fetches sysprefs for every result processed
by bugzilla-daemon＠bugs.koha-community.org 21 Apr '16

21 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15263 Mirko Tietgen <mirko(a)abunchofthings.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #18 from Mirko Tietgen <mirko(a)abunchofthings.net> --- The last followup uses OPACXSLTResultsDisplay for the details page, that should probably be OPACXSLTDetailsDisplay? -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15126] REST API: Use newer version of Swagger2
by bugzilla-daemon＠bugs.koha-community.org 21 Apr '16

21 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15126 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy(a)rijksmuseum.nl Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15263] XSLT display fetches sysprefs for every result processed
by bugzilla-daemon＠bugs.koha-community.org 21 Apr '16

21 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15263 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |master -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15263] XSLT display fetches sysprefs for every result processed
by bugzilla-daemon＠bugs.koha-community.org 21 Apr '16

21 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15263 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy(a)rijksmuseum.nl Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13597] Amazon 'no image' element needs a 'no-image' class, in the staff client
by bugzilla-daemon＠bugs.koha-community.org 21 Apr '16

21 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13597 Marc Véron <veron(a)veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Trivial patch CC| |veron(a)veron.ch -- You are receiving this mail because: You are watching all bug changes.

1 0