April 2016 - Koha-bugs - lists.koha-community.org

[Bug 11592] opac detail scripts do not respect MARC tag visibility
by bugzilla-daemon＠bugs.koha-community.org 21 Apr '16

21 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11592 --- Comment #107 from M. Tompsett <mtompset(a)hotmail.com> --- Comment on attachment 50489 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50489 Bug 11592: MARCView and ISBD followup Review of attachment 50489: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=115…) ----------------------------------------------------------------- ::: opac/opac-ISBDdetail.pl @@ +92,4 @@ > } > } > > +my $record_unfiltered = GetMarcBiblio($biblionumber,1); This is because GetMarcBiblio was previously called in C4::Biblio::GetISBDView with ,1 which includes embedded items. ::: opac/opac-MARCdetail.pl @@ +108,5 @@ > my ($bt_tag,$bt_subtag) = GetMarcFromKohaField('biblio.title',$itemtype); > $template->param( > bibliotitle => $biblio->{title}, > +) if $tagslib->{$bt_tag}->{$bt_subtag}->{hidden} <= 0 && # <=0 OPAC visible. > + $tagslib->{$bt_tag}->{$bt_subtag}->{hidden} > -8; # except -8; Forgot the -8 (flagged) case. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14957] Write protecting MARC fields based on source of import
by bugzilla-daemon＠bugs.koha-community.org 21 Apr '16

21 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957 Magnus Enger <magnus(a)libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |magnus(a)libriotech.no --- Comment #5 from Magnus Enger <magnus(a)libriotech.no> --- Just confirming the patches do not apply. Here is the error: $ git bz apply 14957 Bug 14957 - Write protecting MARC fields based on source of import 44056 - Bug 14957: Rule based permission for MARC fields 44057 - Bug 14957: Database changes 44058 - Bug 14957: Add filters to relevant scripts Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 14957: Rule based permission for MARC fields Using index info to reconstruct a base tree... M C4/Biblio.pm M koha-tmpl/intranet-tmpl/prog/en/modules/admin/admin-home.tt M koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/cataloguing.pref Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/cataloguing.pref Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/admin/admin-home.tt CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/admin/admin-home.tt Auto-merging C4/Biblio.pm CONFLICT (content): Merge conflict in C4/Biblio.pm Failed to merge in the changes. Patch failed at 0001 Bug 14957: Rule based permission for MARC fields The copy of the patch that failed is found in: /home/magnus/scripts/kohaclone/.git/rebase-apply/patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-14957-Rule-based-permission-for-MARC-fields-IZUxzW.patch -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13438] Convert normarc framework plugins to new style (see also 10480)
by bugzilla-daemon＠bugs.koha-community.org 21 Apr '16

21 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13438 --- Comment #6 from Magnus Enger <magnus(a)libriotech.no> --- I might be missing something, but when I run the test thingy I get errors: $ sudo koha-shell -c "prove t/db_dependent/FrameworkPlugin.t -incl cataloguing/value_builder/normarc*.pl" kohadev [sudo] password for magnus: Feil. Prøv igjen. [sudo] password for magnus: t/db_dependent/FrameworkPlugin.t ................ 1/5 substr outside of string at /home/magnus/scripts/kohaclone/cataloguing/value_builder/marc21_field_007.pl line 73. substr outside of string at /home/magnus/scripts/kohaclone/cataloguing/value_builder/marc21_field_007.pl line 74. [...] substr outside of string at /home/magnus/scripts/kohaclone/cataloguing/value_builder/marc21_field_007.pl line 92. Use of uninitialized value $f3 in concatenation (.) or string at /home/magnus/scripts/kohaclone/cataloguing/value_builder/marc21_field_007.pl line 99. [...] Use of uninitialized value $f22 in concatenation (.) or string at /home/magnus/scripts/kohaclone/cataloguing/value_builder/marc21_field_007.pl line 99. oAuth error: Unsupported Use attribute (114) authtype Bib-1 DBIx::Class::Schema::resultset(): resultset() expects a source name at /usr/share/koha/lib/Koha/Objects.pm line 237 # Child (Test05 -- tests with build and launch for default plugins) exited without calling finalize() t/db_dependent/FrameworkPlugin.t ................ 5/5 # Failed test 'Test05 -- tests with build and launch for default plugins' # at /usr/local/share/perl/5.18.2/Test/Builder.pm line 279. # Looks like you failed 1 test of 5. # Looks like your test exited with 255 just after 5. t/db_dependent/FrameworkPlugin.t ................ Dubious, test returned 255 (wstat 65280, 0xff00) Failed 1/5 subtests Cannot detect source of '-incl'! at /usr/local/share/perl/5.18.2/TAP/Parser/IteratorFactory.pm line 261. TAP::Parser::IteratorFactory::detect_source('TAP::Parser::IteratorFactory=HASH(0x27879b0)', 'TAP::Parser::Source=HASH(0x2787aa0)') called at /usr/local/share/perl/5.18.2/TAP/Parser/IteratorFactory.pm line 211 TAP::Parser::IteratorFactory::make_iterator('TAP::Parser::IteratorFactory=HASH(0x27879b0)', 'TAP::Parser::Source=HASH(0x2787aa0)') called at /usr/local/share/perl/5.18.2/TAP/Parser.pm line 470 TAP::Parser::_initialize('TAP::Parser=HASH(0x2787ae8)', 'HASH(0x25da478)') called at /usr/local/share/perl/5.18.2/TAP/Object.pm line 55 TAP::Object::new('TAP::Parser', 'HASH(0x25da478)') called at /usr/local/share/perl/5.18.2/TAP/Object.pm line 130 TAP::Object::_construct('TAP::Harness=HASH(0x22f38e8)', 'TAP::Parser', 'HASH(0x25da478)') called at /usr/local/share/perl/5.18.2/TAP/Harness.pm line 852 TAP::Harness::make_parser('TAP::Harness=HASH(0x22f38e8)', 'TAP::Parser::Scheduler::Job=HASH(0x25da658)') called at /usr/local/share/perl/5.18.2/TAP/Harness.pm line 651 TAP::Harness::_aggregate_single('TAP::Harness=HASH(0x22f38e8)', 'TAP::Parser::Aggregator=HASH(0x23f7770)', 'TAP::Parser::Scheduler=HASH(0x25da6d0)') called at /usr/local/share/perl/5.18.2/TAP/Harness.pm line 743 TAP::Harness::aggregate_tests('TAP::Harness=HASH(0x22f38e8)', 'TAP::Parser::Aggregator=HASH(0x23f7770)', 't/db_dependent/FrameworkPlugin.t', '-incl', 'cataloguing/value_builder/normarc_field_007.pl', 'cataloguing/value_builder/normarc_field_008.pl', 'cataloguing/value_builder/normarc_leader.pl') called at /usr/local/share/perl/5.18.2/TAP/Harness.pm line 558 TAP::Harness::__ANON__() called at /usr/local/share/perl/5.18.2/TAP/Harness.pm line 571 TAP::Harness::runtests('TAP::Harness=HASH(0x22f38e8)', 't/db_dependent/FrameworkPlugin.t', '-incl', 'cataloguing/value_builder/normarc_field_007.pl', 'cataloguing/value_builder/normarc_field_008.pl', 'cataloguing/value_builder/normarc_leader.pl') called at /usr/local/share/perl/5.18.2/App/Prove.pm line 546 App::Prove::_runtests('App::Prove=HASH(0x1e852c8)', 'HASH(0x22c42f0)', 't/db_dependent/FrameworkPlugin.t', '-incl', 'cataloguing/value_builder/normarc_field_007.pl', 'cataloguing/value_builder/normarc_field_008.pl', 'cataloguing/value_builder/normarc_leader.pl') called at /usr/local/share/perl/5.18.2/App/Prove.pm line 504 App::Prove::run('App::Prove=HASH(0x1e852c8)') called at /usr/local/bin/prove line 12 I have replaced some repeated errors with [...] This is on a gitified package install. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14144] Silence warnings t/db_dependent/Auth_with_ldap.t
by bugzilla-daemon＠bugs.koha-community.org 21 Apr '16

21 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14144 Héctor Eduardo Castro Avalos <hector.hecaxmmx(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |hector.hecaxmmx(a)gmail.com -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14144] Silence warnings t/db_dependent/Auth_with_ldap.t
by bugzilla-daemon＠bugs.koha-community.org 21 Apr '16

21 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14144 Héctor Eduardo Castro Avalos <hector.hecaxmmx(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #49886|0 |1 is obsolete| | --- Comment #11 from Héctor Eduardo Castro Avalos <hector.hecaxmmx(a)gmail.com> --- Created attachment 50540 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50540&action=ed… [SIGNED-OFF]Bug 14144: Clean ups and refactors perltidy old new calls to new call format attrType -> attr_type (perlcritic friendlier) double quotes to single quotes '' combinations to q{} (perlcritic friendlier) refactored parameters to mock_net_ldap_search into a HASH This piece is not necessary, but I think it is nicer. Signed-off-by: Hector Castro <hector.hecaxmmx(a)gmail.com> Works as expected. No koha-qa erros -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14144] Silence warnings t/db_dependent/Auth_with_ldap.t
by bugzilla-daemon＠bugs.koha-community.org 21 Apr '16

21 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14144 Héctor Eduardo Castro Avalos <hector.hecaxmmx(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #49885|0 |1 is obsolete| | --- Comment #10 from Héctor Eduardo Castro Avalos <hector.hecaxmmx(a)gmail.com> --- Created attachment 50539 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50539&action=ed… [SIGNED-OFF]Bug 14144: Silence warnings t/db_dependent/Auth_with_ldap.t Revisiting this bug, I noticed that C4::Context->config() was mocked poorly. I expanded the mock function a little and have quieted the test which seemed to be working in a broken manner before. TEST PLAN --------- 1) prove t/db_dependend/Auth_with_ldap.t -- shibboleth noise 2) apply this patch 3) prove t/db_dependend/Auth_with_ldap.t -- no noise 4) run koha qa test tools Signed-off-by: Hector Castro <hector.hecaxmmx(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14144] Silence warnings t/db_dependent/Auth_with_ldap.t
by bugzilla-daemon＠bugs.koha-community.org 21 Apr '16

21 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14144 Héctor Eduardo Castro Avalos <hector.hecaxmmx(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38836|0 |1 is obsolete| | --- Comment #9 from Héctor Eduardo Castro Avalos <hector.hecaxmmx(a)gmail.com> --- Created attachment 50538 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50538&action=ed… [SIGNED-OFF]Bug 14144: Silence warnings in t/db_dependent/Auth_with_ldap.t TEST PLAN ---------- 1) prove t/db_dependent/Auth_with_ldap.t -- there is a shibboleth related warning 2) apply patch 3) prove t/db_dependent/Auth_with_ldap.t -- now there is not. 4) koha qa test tools. NOTE: Further investigation determined this would merely delay it, as the function is not called by this test. A delay is better than nothing. Signed-off-by: Hector Castro <hector.hecaxmmx(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12478] Elasticsearch support for Koha
by bugzilla-daemon＠bugs.koha-community.org 21 Apr '16

21 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12478 Tomás Cohen Arazi <tomascohen(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |16248 Depends on|16248 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16248 [Bug 16248] ModZebra doesn't update zebraqueue if ES is enabled -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12787] Unit test files should be better organized
by bugzilla-daemon＠bugs.koha-community.org 21 Apr '16

21 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12787 --- Comment #11 from Kyle M Hall <kyle(a)bywatersolutions.com> --- Created attachment 50524 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50524&action=ed… Bug 12787 [QA Followup] - Retain change to Reports_Guided.t Adds change from Bug 16224: Fix t/db_dependent/Reports_Guided.t (08017f89f150394b6224fafb64fe8d12fc146ff1) to Reports/Guided.t Signed-off-by: Kyle M Hall <kyle(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12787] Unit test files should be better organized
by bugzilla-daemon＠bugs.koha-community.org 21 Apr '16

21 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12787 --- Comment #10 from Kyle M Hall <kyle(a)bywatersolutions.com> --- Created attachment 50523 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50523&action=ed… Bug 12787: (QA followup) small QA fixes Signed-off-by: Tomas Cohen Arazi <tomascohen(a)unc.edu.ar> Signed-off-by: Kyle M Hall <kyle(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0