April 2016 - Koha-bugs - lists.koha-community.org

[Bug 15534] Add the ability to prevent a patron from placing a hold on a record with available items
by bugzilla-daemon＠bugs.koha-community.org 18 Apr '16

18 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15534 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart(a)bugs.koha-c | |ommunity.org --- Comment #19 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Kyle, Not sure the following makes sense :) Should not we check the "Reserved" status? Why don't we call CanItemBeReserved in addition of the existing checks? The test coverage is quite light, but it is not easy to provide a full test coverage for this kind of changes, there are too many possibilities. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15303] Letsencrypt option for Debian package installations
by bugzilla-daemon＠bugs.koha-community.org 18 Apr '16

18 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15303 Mirko Tietgen <mirko(a)abunchofthings.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #50313|0 |1 is obsolete| | --- Comment #59 from Mirko Tietgen <mirko(a)abunchofthings.net> --- Created attachment 50324 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50324&action=ed… Bug 15303 Followup: If install LE dependencies from backports on Jessie On Debian Jessie, apt needs to be told it should get the dependencies for the LE package from backports, or it will error. We check if we are on Jessie and do that automatically so users don't need to set priorities manually in apt. Changed to lsb_release -c -s. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8483] Borrower reading history should include deleted items
by bugzilla-daemon＠bugs.koha-community.org 18 Apr '16

18 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8483 --- Comment #51 from Kyle M Hall <kyle(a)bywatersolutions.com> --- I need someone to tell me what needs changed in order to for this to pqa. All of these changes are internal to Koha::Object and it's children. Taking advantage of the underlying DBIC object should not be an issue. Can someone please tell me specifically what needs to be changed? -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10612] Add ability to delete patrons with batch patron deletion tool
by bugzilla-daemon＠bugs.koha-community.org 18 Apr '16

18 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612 --- Comment #91 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- We need to fix these tests ASAP, a bug may be hidden. I have managed to reproduce the failure on my local install once, but cannot anymore. It would be good to see several fellow trying to: 1. backup the DB 2. prove t/db_dependent/Members.t If the tests fail, keep the backup safe! Reinsert the data and try to recreate the failure. And then debug :) I don't understand the following lines: 295 $builder->build({ 296 source => 'OldIssue', 297 value => { 298 borrowernumber => $bor2inlist, 299 timestamp => '2016-01-01', 300 }, 301 }); Why do we need an entry in the old_issues table? I have commented them but the tests keep passing. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 5572] Improve C4::AuthoritiesMarc->merge() + syspref AuthCleanBiblios
by bugzilla-daemon＠bugs.koha-community.org 18 Apr '16

18 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5572 --- Comment #41 from Jacek Ablewicz <abl(a)biblos.pk.edu.pl> --- (In reply to Jonathan Druart from comment #40) > So it should be moved on its own bug report, that's what you mean? Not really, it's more like (yet another) good reason for upping priority to P1 for this one ;). It would be really nice to have this bug included in the next release IMO - preferably as a whole or at least as much of it as possible; merge() has a lot of issues in current master - some of them are (partially) dealt with in the other reports, but this implementation is most comprehensive and most beneficial so far. Splitting it to separate bugs may help a bit, but it's not necessary in may opinion. Different fixes, enhancements and improvements it provides, if done in separate patches, would vastly improve it's readability though (in particular, code indentation related changes are making the other changes harder to evaluate). -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 6906] show 'Borrower has previously issued $ITEM' alert on checkout
by bugzilla-daemon＠bugs.koha-community.org 18 Apr '16

18 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6906 Alex Sassmannshausen <alex.sassmannshausen(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.

1 0

[Bug 6906] show 'Borrower has previously issued $ITEM' alert on checkout
by bugzilla-daemon＠bugs.koha-community.org 18 Apr '16

18 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6906 Alex Sassmannshausen <alex.sassmannshausen(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #50286|0 |1 is obsolete| | --- Comment #28 from Alex Sassmannshausen <alex.sassmannshausen(a)ptfs-europe.com> --- Created attachment 50323 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50323&action=ed… Post-QA, specifically avoid Serials Hi Radek, Thanks for your interest in this feature! You are quite right in your assessment of the current situation, and I can also see that the use case you describe is a valid one. Unfortunately I cannot currently invest the time to implement these additional checks. As a compromise, here a revised patch that I believe should take serials out of the loop entirely. Best wishes Alex -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.

1 0

[Bug 5572] Improve C4::AuthoritiesMarc->merge() + syspref AuthCleanBiblios
by bugzilla-daemon＠bugs.koha-community.org 18 Apr '16

18 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5572 --- Comment #40 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- So it should be moved on its own bug report, that's what you mean? -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15303] Letsencrypt option for Debian package installations
by bugzilla-daemon＠bugs.koha-community.org 18 Apr '16

18 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15303 --- Comment #58 from Mirko Tietgen <mirko(a)abunchofthings.net> --- Oh, great catch! :D I blindly copied it from something I wrote a while ago. I will make a change. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15303] Letsencrypt option for Debian package installations
by bugzilla-daemon＠bugs.koha-community.org 18 Apr '16

18 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15303 --- Comment #57 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Comment on attachment 50313 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50313 Bug 15303 Followup: If install LE dependencies from backports on Jessie Review of attachment 50313: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=153…) ----------------------------------------------------------------- ::: debian/scripts/koha-create @@ +338,4 @@ > if [ $aptcacheshow -eq 0 ]; then > read -r -p "The letsencrypt package is not installed. Do it now? [y/N] " response > if [[ $response =~ ^([yY][eE][sS]|[yY])$ ]]; then > + local debrelease="$(lsb_release -c | sed 's|.*\W$.*$|\1|')" lsb-release -c -s seems to be the way to do :) -- You are receiving this mail because: You are watching all bug changes.

1 0