April 2016 - Koha-bugs - lists.koha-community.org

[Bug 3669] Create a template for circ/add_message.pl
by bugzilla-daemon＠bugs.koha-community.org 18 Apr '16

18 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3669 --- Comment #21 from Marc Véron <veron(a)veron.ch> --- (In reply to Aleisha Amohia from comment #20) > (In reply to Owen Leonard from comment #19) > > The redirect is failing for me on circulation.pl if I arrive at the page via > > a form submission. It works if I come to the page via > > circulation.pl?borrowernumber=X or circulation.pl?findborrower=X. > > > > The same is true for the batch checkout page. If I click the batch checkout > > link, then try to add a message the redirect works. If I perform a batch > > checkout and then try to add a message the redirect fails. > > > > In by cases what I mean by "fails" is that I'm returned to a "blank" > > circulation.pl with no patron loaded. > > > > This is true of paycollect.pl too, so I assume it's true for any page which > > loads the patron record via a POST operation. > > I'm a bit confused - the button works fine for me from the paycollect page > etc. Not sure what's going wrong for you! To reproduce: - Go to Batch check out page - Enter some barcodes, click "Check out" - On the next page, instead of "Confirm Check out" click "Add message" - Enter a message and click "Save" Result: Redirection to /cgi-bin/koha/circ/circulation.pl with text "This patron does not exist. Find another patron?" -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15566] Update API to allow to reserve first available item from a group of titles
by bugzilla-daemon＠bugs.koha-community.org 18 Apr '16

18 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15566 Julian Maurice <julian.maurice(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Needs Signoff Assignee|koha-bugs(a)lists.koha-commun |julian.maurice(a)biblibre.com |ity.org | --- Comment #4 from Julian Maurice <julian.maurice(a)biblibre.com> --- I don't remember why I changed the status to BLOCKED. All dependencies are Signed Off, so we can change it back to Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 0

[Bug 14769] Authorities merge: Set correct indicators in biblio field
by bugzilla-daemon＠bugs.koha-community.org 18 Apr '16

18 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14769 Jacek Ablewicz <abl(a)biblos.pk.edu.pl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |abl(a)biblos.pk.edu.pl -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8483] Borrower reading history should include deleted items
by bugzilla-daemon＠bugs.koha-community.org 18 Apr '16

18 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8483 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #50 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- I think we can agree that the feature itself would be good to have, hope we can agree about implementation too :) Moving this to 'failed qa' (unit tests) for now - please take a look at the comments and feel free to bring it up at the next dev meeting if you think this will help moving it forward. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15541] Prevent normalization during matching/import process
by bugzilla-daemon＠bugs.koha-community.org 18 Apr '16

18 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15541 --- Comment #12 from David Cook <dcook(a)prosentient.com.au> --- Thanks for your comments, Marcel! I appreciate you taking the time to look at the patch. (In reply to Marcel de Rooy from comment #11) > QA Comment: > Thanks for your patch, David. > BTW This is imo not a trivial patch or something to signoff for an academy > user, new to Koha. Fair enough. I think perhaps the patch grew with time and I forgot to remove the Academy keyword. > [1] Although your changes in SimpleSearch are very small, it would probably > help if you would add a test case in t/db_dependent/Search.t. (It seems to > fail some tests currently, separate from your patch.) Hmm, also fair enough. I'll look at doing that. > [2] The source_normalizer or norms just lead me to two FIXMEs: > # FIXME normalize, substr > # FIXME - default normalizer > You introduce none and raw in the regex while this field actually does > nothing (and should not have been there in this stage). Your patch starts > using this field, while the only thing you want is not running _normalize > for (mainly?) URLs. If we do not really solve the problem of this unused > field, I think we should not touch it. BTW What would be the difference > between raw and none? The regex suggests more than what we offer. I'm not sure what you mean here... so I'll look at the code again. I think Kyle was having problems with normalization, so it's possible that he removed _normalize() in a different patch? > [3] I have some doubts about this new condition: > if ($QParser && $matchpoint->{'index'} !~ m/\w,\w/) { > Somehow you managed to bump in another unfinished area here too :) > I would rather leave the condition as it was. In the QParser branch you > could choose to ignore/remove the second specifier word with a similar regex. > Hmm, I don't think that's a good idea. You don't want to ignore/remove the second qualifier; it's important that the qualifier is in the query. You want to use it, but I don't think the QParser can do it. I think I lifted this condition from a different part of the Koha code to make the behaviour a bit more consistent. Perhaps it would be smarter to add a more universal "can_query_parse()" or something to test if the query is parseable by QParser... > Changing status for now. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 3669] Create a template for circ/add_message.pl
by bugzilla-daemon＠bugs.koha-community.org 18 Apr '16

18 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3669 --- Comment #20 from Aleisha Amohia <aleishaamohia(a)hotmail.com> --- (In reply to Owen Leonard from comment #19) > The redirect is failing for me on circulation.pl if I arrive at the page via > a form submission. It works if I come to the page via > circulation.pl?borrowernumber=X or circulation.pl?findborrower=X. > > The same is true for the batch checkout page. If I click the batch checkout > link, then try to add a message the redirect works. If I perform a batch > checkout and then try to add a message the redirect fails. > > In by cases what I mean by "fails" is that I'm returned to a "blank" > circulation.pl with no patron loaded. > > This is true of paycollect.pl too, so I assume it's true for any page which > loads the patron record via a POST operation. I'm a bit confused - the button works fine for me from the paycollect page etc. Not sure what's going wrong for you! -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13287] Add a system preference to define the number of days used in purge_suggestions.pl
by bugzilla-daemon＠bugs.koha-community.org 17 Apr '16

17 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13287 Marc Véron <veron(a)veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |16280 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16280 [Bug 16280] purge_suggestions.pl: Cron job log should tell number of days used -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13287] Add a system preference to define the number of days used in purge_suggestions.pl
by bugzilla-daemon＠bugs.koha-community.org 17 Apr '16

17 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13287 Marc Véron <veron(a)veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Component|Reports |System Administration CC| |gmcharlt(a)gmail.com -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13287] Add a system preference to define the number of days used in purge_suggestions.pl
by bugzilla-daemon＠bugs.koha-community.org 17 Apr '16

17 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13287 Marc Véron <veron(a)veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13287] Add a system preference to define the number of days used in purge_suggestions.pl
by bugzilla-daemon＠bugs.koha-community.org 17 Apr '16

17 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13287 Marc Véron <veron(a)veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48324|0 |1 is obsolete| | --- Comment #25 from Marc Véron <veron(a)veron.ch> --- Created attachment 50297 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50297&action=ed… Bug 13287: QA Follow up Added missing upgrade SQL system preference. Corrected system preference screen message Fixes on purge_suggestions.pl - perlcritic friendlier - address $PERL5LIB comment by using $PROGRAM_NAME (comment #10) - used STDERR (comment #10) - perltidy TEST PLAN --------- $ ./installer/data/mysql/updatedatabase.pl -- should run upgrade and generate new systempreference in table $ ./misc/cronjobs/purge_suggestions.pl --help -- should give help with a real path used instead of $PERL5LIB. $ ./misc/cronjobs/purge_suggestions.pl -days -1 -- should give error message as expected $ ./misc/cronjobs/purge_suggestions.pl -days 0 -- should give error message as expected Go to OPAC system preferences tab and check the PurgeSuggestionsOlderThan system preference -- message should be as expected (see comment #9) run koha qa test tools -- all should pass Signed-off-by: Marc Véron <veron(a)veron.ch> -- You are receiving this mail because: You are watching all bug changes.

1 0