April 2016 - Koha-bugs - lists.koha-community.org

[Bug 5572] Improve C4::AuthoritiesMarc->merge() + syspref AuthCleanBiblios
by bugzilla-daemon＠bugs.koha-community.org 18 Apr '16

18 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5572 Jacek Ablewicz <abl(a)biblos.pk.edu.pl> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P3 |P1 - high -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 5572] Improve C4::AuthoritiesMarc->merge() + syspref AuthCleanBiblios
by bugzilla-daemon＠bugs.koha-community.org 18 Apr '16

18 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5572 --- Comment #39 from Jacek Ablewicz <abl(a)biblos.pk.edu.pl> --- Note that - apart from the new feature, various performance enhancements, code clenups etc., - attachment in comment #30 introduces one pretty important bugfix: - $marcrecord->delete_field($field); - $marcrecord->insert_grouped_field($field_to); + $field->replace_with($field_to); Thanks to that, merge() does not mess up field order in biblio records anymore. This ("merge() messing up field order in biblio records") is a long standing issue (since commit efc64f44241efcc8a02ee0a8549a5346cdd026b0, Sat Aug 9 10:53:14 2008 -0500, "Bug fix : use delete_field/insert_grouped_field rather than replace_with") witch may cause severe data loss in some setups. Quite a nasty one, not always easy to spot (unless everybody & their dog is using MARC preview very often in a given setup). I was under the impression that it got already fixed somewhere around 3.20, but nope, that particular insert_grouped_field() call is still there in the current master. I guess technically it's a critical bug (if not a blocker). -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13287] Add a system preference to define the number of days used in purge_suggestions.pl
by bugzilla-daemon＠bugs.koha-community.org 18 Apr '16

18 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13287 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart(a)bugs.koha-c | |ommunity.org Status|Signed Off |Failed QA --- Comment #26 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Suggestions: What about moving all the cronjob prefs to a new "cronjob" tab? What about a new pref to turn all of these prefs on/off? Review: 1/ Change in the behavior if the script is called without parameter (help is not displayed anymore). I think we should add a confirm flag if the pref will be used and --days is not given. 2/ +use English qw( -no_match_vars ); why that? 3/ It would have been good to use Pod2usage Failing QA for 1. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15009] Planning dropdown button in aqbudget can have empty line
by bugzilla-daemon＠bugs.koha-community.org 18 Apr '16

18 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15009 --- Comment #19 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 50317 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50317&action=ed… Bug 15009: QA follow-up This patch adds a test to check the unicity of auth cats, simplify the GetBudgetAuthCats subroutine and make it return an arrayref of scalar instead of an arrayref of hashref with only 1 key. Signed-off-by: Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15009] Planning dropdown button in aqbudget can have empty line
by bugzilla-daemon＠bugs.koha-community.org 18 Apr '16

18 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15009 --- Comment #18 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 50316 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50316&action=ed… Bug 15009: Correctly populate planning filter The filter for planning values was populated with empty strings. Note that it's not caused by previous patches. Signed-off-by: Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15009] Planning dropdown button in aqbudget can have empty line
by bugzilla-daemon＠bugs.koha-community.org 18 Apr '16

18 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15009 --- Comment #17 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 50315 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50315&action=ed… Bug 15009 - Adds unit tests for C4::Budget::GetBudgetAuthCats Signed-off-by: Marc Véron <veron(a)veron.ch> Signed-off-by: Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15009] Planning dropdown button in aqbudget can have empty line
by bugzilla-daemon＠bugs.koha-community.org 18 Apr '16

18 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15009 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44262|0 |1 is obsolete| | Attachment #50293|0 |1 is obsolete| | --- Comment #16 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 50314 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50314&action=ed… Bug 15009 - Planning dropdown button in aqbudget can have empty line When displaying a budget, the Planning button in the admin toolbar displays Plan by months Plan by libraries Plan by item types Plan by The last one is empty, due to C4::Budgets::GetBudgetAuthCats returning an empty field if the budget has no sort defined. This prevents returning an array with empty element(s) TEST: 1) Admin -> Budgets 2) Select a budget a) you must have '' (empty) in your aqbudgets.sort1_authcat field. b) edit the budget (direct DB or interface) to get that. 3) Click on Planning dropdown, see the "Plan by <nothing> " entry. 4) apply the patch, revalidate. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel(a)gmail.com> No more empty option No errors Signed-off-by: Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15009] Planning dropdown button in aqbudget can have empty line
by bugzilla-daemon＠bugs.koha-community.org 18 Apr '16

18 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15009 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15303] Letsencrypt option for Debian package installations
by bugzilla-daemon＠bugs.koha-community.org 18 Apr '16

18 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15303 --- Comment #56 from Mirko Tietgen <mirko(a)abunchofthings.net> --- Created attachment 50313 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50313&action=ed… Bug 15303 Followup: If install LE dependencies from backports on Jessie On Debian Jessie, apt needs to be told it should get the dependencies for the LE package from backports, or it will error. We check if we are on Jessie and do that automatically so users don't need to set priorities manually in apt. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15303] Letsencrypt option for Debian package installations
by bugzilla-daemon＠bugs.koha-community.org 18 Apr '16

18 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15303 --- Comment #55 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- (In reply to Mirko Tietgen from comment #48) > > If you are a liar and the symlink does not exist, you get a weird error from > > adduser (adduser: Please enter a username matching the regular expression > > configured) > > That was actually due to a too short instance name. You get the same if you > do it without --letsencrypt. No, it's because I used uppercase characters. -- You are receiving this mail because: You are watching all bug changes.

1 0