April 2016 - Koha-bugs - lists.koha-community.org

[Bug 13287] Add a system preference to define the number of days used in purge_suggestions.pl
by bugzilla-daemon＠bugs.koha-community.org 17 Apr '16

17 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13287 Marc Véron <veron(a)veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13287] Add a system preference to define the number of days used in purge_suggestions.pl
by bugzilla-daemon＠bugs.koha-community.org 17 Apr '16

17 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13287 Marc Véron <veron(a)veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48324|0 |1 is obsolete| | --- Comment #25 from Marc Véron <veron(a)veron.ch> --- Created attachment 50297 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50297&action=ed… Bug 13287: QA Follow up Added missing upgrade SQL system preference. Corrected system preference screen message Fixes on purge_suggestions.pl - perlcritic friendlier - address $PERL5LIB comment by using $PROGRAM_NAME (comment #10) - used STDERR (comment #10) - perltidy TEST PLAN --------- $ ./installer/data/mysql/updatedatabase.pl -- should run upgrade and generate new systempreference in table $ ./misc/cronjobs/purge_suggestions.pl --help -- should give help with a real path used instead of $PERL5LIB. $ ./misc/cronjobs/purge_suggestions.pl -days -1 -- should give error message as expected $ ./misc/cronjobs/purge_suggestions.pl -days 0 -- should give error message as expected Go to OPAC system preferences tab and check the PurgeSuggestionsOlderThan system preference -- message should be as expected (see comment #9) run koha qa test tools -- all should pass Signed-off-by: Marc Véron <veron(a)veron.ch> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13287] Add a system preference to define the number of days used in purge_suggestions.pl
by bugzilla-daemon＠bugs.koha-community.org 17 Apr '16

17 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13287 Marc Véron <veron(a)veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44312|0 |1 is obsolete| | --- Comment #24 from Marc Véron <veron(a)veron.ch> --- Created attachment 50296 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50296&action=ed… Bug13287 - Add a system preference to define the number of days used in purge_suggestions.pl The system preferences value is used whenever purge_suggestions.pl is called without the 'days' parameter. This patch uses the preference description suggested by comment #9. This version should now be cleanly applicable. I Apply the patch II Run updatedatabase.pl a) Run purge_suggestions.pl without the days parameter - validate that there is an error message b) Run purge_suggestions.pl with the days parameter - validate that there is no error message c) Insert a number of days in the system variable PurgeSuggestionsOlderThan d) Run purge_suggestions.pl without the days parameter - validate that there is no error message Signed-off-by: Liz Rea <liz(a)catalyst.net.nz> Tested per plan, all tests pass. Signed-off-by: Marc Véron <veron(a)veron.ch> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13287] Add a system preference to define the number of days used in purge_suggestions.pl
by bugzilla-daemon＠bugs.koha-community.org 17 Apr '16

17 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13287 Marc Véron <veron(a)veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |16104 --- Comment #23 from Marc Véron <veron(a)veron.ch> --- Related to Bug 16104 Warnings "used only once: possible typo" should be removed Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16104 [Bug 16104] Warnings "used only once: possible typo" should be removed -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13287] Add a system preference to define the number of days used in purge_suggestions.pl
by bugzilla-daemon＠bugs.koha-community.org 17 Apr '16

17 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13287 --- Comment #22 from Marc Véron <veron(a)veron.ch> --- (In reply to Marc Véron from comment #21) > misc/cronjobs/purge_suggestions.pl -days -1 > OK > > misc/cronjobs/purge_suggestions.pl -days 0 > OK > > misc/cronjobs/purge_suggestions.pl -days 10 > > Result: > > Name "Tie::Hash::FIELDS" used only once: possible typo at > /usr/share/perl/5.14/fields.pm line 135. > Name "Cache::RemovalStrategy::FIELDS" used only once: possible typo at > /usr/share/perl/5.14/fields.pm line 135. > Name "Cache::RemovalStrategy::LRU::FIELDS" used only once: possible typo at > /usr/share/perl/5.14/fields.pm line 135. > Use of uninitialized value $_[0] in lc at /usr/share/perl5/Cache.pm line 485. Ah, it happens with and without patch... -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13287] Add a system preference to define the number of days used in purge_suggestions.pl
by bugzilla-daemon＠bugs.koha-community.org 17 Apr '16

17 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13287 --- Comment #21 from Marc Véron <veron(a)veron.ch> --- misc/cronjobs/purge_suggestions.pl -days -1 OK misc/cronjobs/purge_suggestions.pl -days 0 OK misc/cronjobs/purge_suggestions.pl -days 10 Result: Name "Tie::Hash::FIELDS" used only once: possible typo at /usr/share/perl/5.14/fields.pm line 135. Name "Cache::RemovalStrategy::FIELDS" used only once: possible typo at /usr/share/perl/5.14/fields.pm line 135. Name "Cache::RemovalStrategy::LRU::FIELDS" used only once: possible typo at /usr/share/perl/5.14/fields.pm line 135. Use of uninitialized value $_[0] in lc at /usr/share/perl5/Cache.pm line 485. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12528] Enable staff to deny message setting access to patrons on the OPAC
by bugzilla-daemon＠bugs.koha-community.org 17 Apr '16

17 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12528 Marc Véron <veron(a)veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #57 from Marc Véron <veron(a)veron.ch> --- Does not apply: Auto-merging koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-messaging.tt Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/patrons.pref Auto-merging installer/data/mysql/sysprefs.sql Applying: Bug 12528 - fix problem when insert OPACEnhancedMessagingPreferences Applying: Bug 12528: Bug 9254: Followup - Rename pref to EnhancedMessagingPreferencesOPAC fatal: sha1 information is lacking or useless (installer/data/mysql/sysprefs.sql). Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge. Patch failed at 0001 Bug 12528: Bug 9254: Followup - Rename pref to EnhancedMessagingPreferencesOPAC -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12395] Save order line's creator
by bugzilla-daemon＠bugs.koha-community.org 17 Apr '16

17 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12395 Marc Véron <veron(a)veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron(a)veron.ch -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12027] Shibboleth authentication for staff client
by bugzilla-daemon＠bugs.koha-community.org 17 Apr '16

17 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12027 Marc Véron <veron(a)veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron(a)veron.ch -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12026] Shibboleth auto-provisioning
by bugzilla-daemon＠bugs.koha-community.org 17 Apr '16

17 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12026 Marc Véron <veron(a)veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron(a)veron.ch -- You are receiving this mail because: You are watching all bug changes.

1 0