April 2016 - Koha-bugs - lists.koha-community.org

[Bug 15165] REST API routes to list, edit and pay borrower's accountlines
by bugzilla-daemon＠bugs.koha-community.org 13 Apr '16

13 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15165 Julian Maurice <julian.maurice(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44806|0 |1 is obsolete| | --- Comment #9 from Julian Maurice <julian.maurice(a)biblibre.com> --- Created attachment 50191 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50191&action=ed… Bug 15165 - Add API routes to pay accountlines Rebased on master -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15165] REST API routes to list, edit and pay borrower's accountlines
by bugzilla-daemon＠bugs.koha-community.org 13 Apr '16

13 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15165 Julian Maurice <julian.maurice(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44805|0 |1 is obsolete| | --- Comment #8 from Julian Maurice <julian.maurice(a)biblibre.com> --- Created attachment 50190 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50190&action=ed… Bug 15165 - Add API route to edit accoulines Rebased on master -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15165] REST API routes to list, edit and pay borrower's accountlines
by bugzilla-daemon＠bugs.koha-community.org 13 Apr '16

13 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15165 Julian Maurice <julian.maurice(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44804|0 |1 is obsolete| | --- Comment #7 from Julian Maurice <julian.maurice(a)biblibre.com> --- Created attachment 50189 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50189&action=ed… Bug 15165 - Add API route to list accountlines Rebased on master Renamed Koha::Acountline(s)::type to _type -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14305] Public way to look at the Opac of different branches
by bugzilla-daemon＠bugs.koha-community.org 13 Apr '16

13 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14305 --- Comment #17 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 50188 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50188&action=ed… Bug 14305: RSS message correction follow-up If a user is not logged in but requests a specific branch, the RSS feed message fails to mention the branch. TEST PLAN --------- 1) Apply first patch 2) go to OPAC's opac-main.pl?branch={some branch with specific news} -- notice bad RSS message 3) Apply this patch 4) Repeat step 2 -- notice branch is properly shown. 5) koha qa test tools Signed-off-by: Mark Tompsett <mtompset(a)hotmail.com> Signed-off-by: Owen Leonard <oleonard(a)myacpl.org> Signed-off-by: Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14305] Public way to look at the Opac of different branches
by bugzilla-daemon＠bugs.koha-community.org 13 Apr '16

13 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14305 --- Comment #16 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 50187 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50187&action=ed… Bug 14305: View arbitrary branch's news This patch adds an input named 'branch' to opac-main.pl that allows overriding the home library to view news from any branch. This is part of the 'Use Koha as a CMS' development. To reviewers: Does this create any security implications? The column is text; it is possbile to push SQL statemens into the DB via the opac-membership.pl page, but all the code there seems to use DBIx::Class and prepared statements. When attemped, accepting the changes were rejected because of the foreign key constraint placed on the main borrowers table. It is recommended to use this patch in conjunction with 11584 which adds a WYSIWYG editor to System Preferences. Test plan: * Make sure your Koha installation has multiple branches: * Log in to the Staff interface and select 'Koha administration' * Select 'Libraries and groups', the first item in the list * Add an extra branch named 'BRANCH1': * Press the 'New library' button * Set 'Library code' to 'BRANCH1' * Enter an arbitrary name * Press 'Submit' * Add at least two news items with different branches: * Log in to the Staff interface and select 'Tools' * Under 'Additional tools' select 'News' * On the 'Koha news' page, create a news item for all libraries: * Press the 'New entry' button * Set 'Library' to 'All libraries' and enter a title. * Press 'Submit' * On the 'Koha news' page, create a news item for one library: * Press the 'New entry' button * Set 'Library' to 'BRANCH1' and enter a title * Press 'Submit' * Add links to OPAC to select branch: * Select 'System preferences' and then the 'OPAC' tab * Scroll down to the 'OpacNav' preference and click 'Click to Edit' * Create two hyperlinks with a parameter named 'branch': * '<a href="?branch=BRANCH1">BRANCH1</a>' * '<a href="?branch=">none</a>' * Click 'Save all OPAC preferences' * Test OPAC: * By default, global news and news for home branch should show. * When clicking the 'BRANCH1' link, you should see global news plus news for the BRANCH1 branch. * When the parameter 'branch' is set but has no value, news from the home branch should be shown. Issues: Tricky to create a link to the same page which removes existing paramters. The user normally has a home branch set. We can override it with the parameter. If undefined, the home branch should be shown. Sponsored-by: Halland County Library http://bugs.koha-community.org/show_bug.cgi?id=14305 Changed 2015-12-14: Whitespace fix Signed-off-by: Mark Tompsett <mtompset(a)hotmail.com> Signed-off-by: Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14305] Public way to look at the Opac of different branches
by bugzilla-daemon＠bugs.koha-community.org 13 Apr '16

13 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14305 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #49918|0 |1 is obsolete| | Attachment #49919|0 |1 is obsolete| | Attachment #50152|0 |1 is obsolete| | --- Comment #15 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 50186 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50186&action=ed… Bug 14305: View arbitrary branch's news, RSS fix This fix changes the RSS link to reflect the URL paramter override. This is less elegant than the existing solution which uses the Branches TT module, perhaps there is a better way? Sponsored-By: Halland County Library Test plan: * Follow instructions in the original patch but also check the URLs and contents of the RSS link at the bottom the OPAC page. Signed-off-by: Mark Tompsett <mtompset(a)hotmail.com> Signed-off-by: Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14305] Public way to look at the Opac of different branches
by bugzilla-daemon＠bugs.koha-community.org 13 Apr '16

13 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14305 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15451] Move the CSV related code to Koha::CsvProfile[s]
by bugzilla-daemon＠bugs.koha-community.org 13 Apr '16

13 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15451 --- Comment #24 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 50185 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50185&action=ed… Bug 15451: Do not considered a Resultset as a Result The previous calls were wrong, but there is something bad with the DB structure: export_format.profile should be a unique key. This patch fixes the previous calls and add a FIXME not to forget to fix the DB structure. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15451] Move the CSV related code to Koha::CsvProfile[s]
by bugzilla-daemon＠bugs.koha-community.org 13 Apr '16

13 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15451 --- Comment #23 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 50184 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50184&action=ed… Bug 15451: Koha::CsvProfiles - Remove the residue This patch erase all traces of C4::Csv since it's not used anymore. All occurrences have been replaced by previous patches to use Koha::CsvProfiles. Note that GetMarcFieldsForCsv was not used prior this patch set. Test plan: git grep 'C4::Csv' should not return any result. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15451] Move the CSV related code to Koha::CsvProfile[s]
by bugzilla-daemon＠bugs.koha-community.org 13 Apr '16

13 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15451 --- Comment #22 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 50183 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50183&action=ed… Bug 15451: Koha::CsvProfiles - Remove GetCsvProfile This subroutine just returned a csv profile for a given id. It is replaced in this patch by a call to Koha::CsvProfiles->find. There is nothing to test here, these changes have been tested in previous patches. -- You are receiving this mail because: You are watching all bug changes.

1 0