April 2016 - Koha-bugs - lists.koha-community.org

[Bug 15451] Move the CSV related code to Koha::CsvProfile[s]
by bugzilla-daemon＠bugs.koha-community.org 13 Apr '16

13 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15451 --- Comment #21 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 50182 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50182&action=ed… Bug 15451: Koha::CsvProfiles - Remove GetCsvProfileId This subroutine returned the export_format_id for a given profile name. This can be done easily with the Koha::CsvProfiles->search method. Test plan: Export records using the misc/export_records.pl script and the export tool. If you are exporting using the MARC format, the profile filled in the pref ExportWithCsvProfile will be used (or the one passed in parameter of misc/export_records.pl). If you are exporting using the CSV format, you can choose a profile in the dropdown list. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15451] Move the CSV related code to Koha::CsvProfile[s]
by bugzilla-daemon＠bugs.koha-community.org 13 Apr '16

13 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15451 --- Comment #20 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 50181 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50181&action=ed… Bug 15451: Koha::CsvProfiles - Remove GetCsvProfiles This subroutine did the same job as GetCsvProfilesLoop, so this patch applies the same changes as the previous patch. Test plan: 1/ Claim some serials, sql profiles should be listed 2/ Export records using the export tool. MARC profiles should be listed. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15451] Move the CSV related code to Koha::CsvProfile[s]
by bugzilla-daemon＠bugs.koha-community.org 13 Apr '16

13 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15451 --- Comment #19 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 50180 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50180&action=ed… Bug 15451: Koha::CsvProfiles - Remove GetCsvProfilesLoop This subroutine returned the csv profiles for a given type. This could be done easily with the new Koha::CsvProfiles->search method. Test plan: To do at the OPAC and staff interface! 1/ Export a list using a CSV profile 2/ Export your CART using a CSV profile Note that only MARC profiles should be available. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15451] Move the CSV related code to Koha::CsvProfile[s]
by bugzilla-daemon＠bugs.koha-community.org 13 Apr '16

13 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15451 --- Comment #18 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 50179 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50179&action=ed… Bug 15451: Rewrite the csv profile tool script This page was inconsistent with the other admin and tool pages. The 2 tabs 'New profile' and 'Edit existing profile' were useless, the ergonomic needs to be revisited. This patch applies the same script/page structure as others: by default a table containing all csv profiles is displayed with 2 action links: edit and delete. Test plan: 1/ Create 1+ CSV profiles, with different types (marc and sql) 2/ Update some values using the Edit link 3/ Delete a CSV profile Note: When deleting a CSV profile, it would be great to warn the user if it is used. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15451] Move the CSV related code to Koha::CsvProfile[s]
by bugzilla-daemon＠bugs.koha-community.org 13 Apr '16

13 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15451 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46108|0 |1 is obsolete| | Attachment #46109|0 |1 is obsolete| | Attachment #46110|0 |1 is obsolete| | Attachment #46111|0 |1 is obsolete| | Attachment #46112|0 |1 is obsolete| | Attachment #46113|0 |1 is obsolete| | Attachment #46114|0 |1 is obsolete| | Attachment #46306|0 |1 is obsolete| | --- Comment #17 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 50178 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50178&action=ed… Bug 15451: Add the 2 new modules Koha::CsvProfile[s] There are based on Koha::Objets. Tests provided. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15451] Move the CSV related code to Koha::CsvProfile[s]
by bugzilla-daemon＠bugs.koha-community.org 13 Apr '16

13 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15451 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12478] Elasticsearch support for Koha
by bugzilla-daemon＠bugs.koha-community.org 13 Apr '16

13 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12478 --- Comment #226 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- (In reply to Chris Cormack from comment #224) > Have you tried with bug 16249! I was talking about t/Koha_ElasticSearch_Indexer.t, t/Koha_ElasticSearch_Search.t and t/Koha_ElasticSearch.t -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15407] Move the patron categories related code to Koha::Patron::Categories - part 2
by bugzilla-daemon＠bugs.koha-community.org 13 Apr '16

13 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15407 --- Comment #35 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 50174 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50174&action=ed… Bug 15407: Koha::Patron::Categories - replace GetborCatFromCatType This unnecessary complicated subroutine returned an arrayref and an hashref of the patron categories available for the logged in user, for a given category_type, ordered by categorycode. This can now be done with the search_limited method. Test plan: - Same prerequisite as before For the following pages, you should not see patron categories limited to other libraries. They should be ordered as before this patch, by categorycode. - Add/edit a patron, change his/her patron category value. - On the 3 following reports: reports/bor_issues_top.pl reports/borrowers_out.pl reports/cat_issues_top.pl The display for these 3 reports are different than the 2 from the first patch (borrowers_stats.pl issues_avg_stats.pl): they are ordered by categorycode and the ones limited to other libraries are not displayed (should certainly be fixed). Note that the big part of this patch has already been tested before (update child related: CATCODE_MULTI). -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15407] Move the patron categories related code to Koha::Patron::Categories - part 2
by bugzilla-daemon＠bugs.koha-community.org 13 Apr '16

13 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15407 --- Comment #34 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 50173 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50173&action=ed… Bug 15407: Koha::Patron::Categories - replace GetBorrowercategoryList C4::Members::GetBorrowercategoryList returned all the patron categories, ordered by description. This can be done using the search method of the Koha::Patron::Categories module. Test plan: - Same prerequisite as before For the following pages, you should not see patron categories limited to other libraries. They should be ordered as before this patch, by description. - On the "patron attribute types" admin page (admin/patron-attr-types.pl). - On the "Batch patron deletion/anonymization" (tools/cleanborrowers.pl), the dropdown list should be filled correctly. - On the import patron tool - On the following report: reports/reserves_stats.pl Confirm that the patron categories are displayed and that the report still works as before. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15407] Move the patron categories related code to Koha::Patron::Categories - part 2
by bugzilla-daemon＠bugs.koha-community.org 13 Apr '16

13 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15407 --- Comment #33 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 50172 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50172&action=ed… Bug 15407: Koha::Patron::Categories - replace GetBorrowercategory The purpose of C4::Members::GetBorrowercategory was to return the patron category for a given categorycode. This can be done easily with the Koha::Patron::Categories->find method. Test plan: - Same prerequisite as before - Edit a guarantor and confirm the information will be updated for his/her guarantee(s). - Update a child to adult patron (Note: Should not we hide the patron categories limited to others libraries? If yes, it must be done on another bug report). There is a special behavior if there is only 1 adult category, the user does not need to select a category. So the same as before with only 1 adult patron category. - Import a patron with a category_code which does not exist. You should be warned. - Modify some patron using the batch patron modification tool. The patron category descriptions should correctly be displayed. Note that the overduerules page has already been tested in a previous patch. -- You are receiving this mail because: You are watching all bug changes.

1 0