April 2016 - Koha-bugs - lists.koha-community.org

[Bug 14686] New menu option and permission for file uploading
by bugzilla-daemon＠bugs.koha-community.org 04 Apr '16

04 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14686 --- Comment #27 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 49853 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49853&action=ed… Bug 14686: Add Upload to Tools menu This patch makes sure that the added granular permissions work as advertised. Note: The field owner was not included in the Koha::Upload->get response. The code to verify if a user is allowed to delete an upload, is concentrated in the template now. When get returns a Koha::Object, this check could be relocated. Test plan: [1] Verify that the current user has permission for tools, or has at least upload_general_files. [2] Do you see Upload in the Tools menu? Follow the link. [3] Upload a permanent file (with a category). [4] Do you see the Delete button in the results form? [5] Make sure that another user has no permission to upload. [6] Login as that user and check the Tools menu. Try the URL [yourserver]/cgi-bin/koha/tools/upload.pl You should have no access to the upload form. [7] Enable upload_general_files for this user. Go to upload and search for the upload from step 3. You should not see a Delete button. [8] Enable upload_manage for this user. Search for the upload again. Delete the upload. [9] Go to upload via the Cataloguing editor (856$u plugin) or add parameter "plugin=1" to the URL. You should not see the Tools menu. Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> Signed-off-by: Mirko Tietgen <mirko(a)abunchofthings.net> Signed-off-by: Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14686] New menu option and permission for file uploading
by bugzilla-daemon＠bugs.koha-community.org 04 Apr '16

04 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14686 --- Comment #26 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 49852 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49852&action=ed… Bug 14686: Add two granular permission for upload under tools [1] Upload_general_files This will allow you to access the tools/upload form via the Tools menu. And it will also allow you to add permanent uploads. [2] Upload_manage It will allow you to delete uploads from other users. Note that anyone may delete his own uploads. It is not meant to include upload_general_files. In order to not disturb existing users that now have edit_catalogue and are using the plugin (read: added at least one record to uploaded_files), we will add the first permission for them. New users will need to be authorized in the usual way thereafter. Note: If you only have one of the other permissions checked in allows_add_by, e.g. stage_marc_import, you can add temporary uploads, but not permanent uploads. Test plan: We are only testing the dbrev here, not if the perm works as advertised. [1] Run the dbrev and check that you see the perms with a description on the Patron/Set permissions page. [2] If you had records in uploaded_files and a user with edit_catalogue *only*, verify that this user now also has upload_general_files. Signed-off-by: Mirko Tietgen <mirko(a)abunchofthings.net> Signed-off-by: Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14686] New menu option and permission for file uploading
by bugzilla-daemon＠bugs.koha-community.org 04 Apr '16

04 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14686 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #49552|0 |1 is obsolete| | Attachment #49553|0 |1 is obsolete| | Attachment #49835|0 |1 is obsolete| | Attachment #49836|0 |1 is obsolete| | --- Comment #25 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 49851 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49851&action=ed… Bug 14686: Add allows_add_by to check permissions for uploading The three permissions in tools/upload-file.pl are moved to a custom routine in DBIx's UploadedFile.pm. An additional granular permission upload_general_files is added. (The dbrev patch will contain it too.) At some point in time this could be moved to a Koha::Object class. The routine is tested in Upload.t. Test plan: [1] Run t/db_dependent/Upload.t [2] If you only apply this patch, you can also test uploading with a user that has edit_catalogue but does not have tools or circulate. Upload status should say: Denied. Signed-off-by: Mirko Tietgen <mirko(a)abunchofthings.net> Signed-off-by: Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14686] New menu option and permission for file uploading
by bugzilla-daemon＠bugs.koha-community.org 04 Apr '16

04 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14686 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14633] apache2-mpm-itk depencency makes Koha uninstallable on Debian Stretch
by bugzilla-daemon＠bugs.koha-community.org 04 Apr '16

04 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14633 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt(a)gmail.com |John.Seymour(a)nal.gov.au -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7736] Edifact QUOTE and ORDER functionality
by bugzilla-daemon＠bugs.koha-community.org 04 Apr '16

04 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7736 Tomás Cohen Arazi <tomascohen(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #158 from Tomás Cohen Arazi <tomascohen(a)gmail.com> --- Brendan, please push the last followup so xt/tt_valid.t gets fixed. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7736] Edifact QUOTE and ORDER functionality
by bugzilla-daemon＠bugs.koha-community.org 04 Apr '16

04 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7736 Tomás Cohen Arazi <tomascohen(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7736] Edifact QUOTE and ORDER functionality
by bugzilla-daemon＠bugs.koha-community.org 04 Apr '16

04 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7736 Tomás Cohen Arazi <tomascohen(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11999] Add two checks in CanBookBeReserved and CanItemBeReserved
by bugzilla-daemon＠bugs.koha-community.org 04 Apr '16

04 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11999 Alex Arnaud <alex.arnaud(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7736] Edifact QUOTE and ORDER functionality
by bugzilla-daemon＠bugs.koha-community.org 04 Apr '16

04 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7736 Tomás Cohen Arazi <tomascohen(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen(a)gmail.com Status|Pushed to Master |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.

1 0