April 2016 - Koha-bugs - lists.koha-community.org

[Bug 7736] Edifact QUOTE and ORDER functionality
by bugzilla-daemon＠bugs.koha-community.org 04 Apr '16

04 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7736 --- Comment #157 from Tomás Cohen Arazi <tomascohen(a)gmail.com> --- Created attachment 49850 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49850&action=ed… Bug 7736: (QA followup) Add missing body id and class Signed-off-by: Tomas Cohen Arazi <tomascohen(a)theke.io> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14686] New menu option and permission for file uploading
by bugzilla-daemon＠bugs.koha-community.org 04 Apr '16

04 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14686 --- Comment #24 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- (In reply to Jonathan Druart from comment #23) > Yes but it's a change in the behavior, would not it better to set it for > existing installs? We add upload_general for active existing installs. I would rather not add the manage permission because it is meant to 'protect' against such deletes. Note that someone with all tools or superlibrarians can. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11844] Additional fields for order lines
by bugzilla-daemon＠bugs.koha-community.org 04 Apr '16

04 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11844 --- Comment #21 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- >> b) why have the datatable search field below the table instead of above? I >> know we have other places where it's like this, but it always irritates me - >> the search is most useful for a big table and this will require you to >> scroll all the way to the end of the table first. >It's the same behaviour as for serials, so I'd say it's expected. Still doesn't make sense :) But not a blocker. I think Jesse wanted to take a look at this - so I didn't test further. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14686] New menu option and permission for file uploading
by bugzilla-daemon＠bugs.koha-community.org 04 Apr '16

04 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14686 --- Comment #23 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- (In reply to Marcel de Rooy from comment #22) > (In reply to Jonathan Druart from comment #21) > > Why does upload_manage is not set by default? > > Before this patch I was able to delete uploads, now I need the permission. > > You should be able to delete your own uploads, not the other ones. Yes but it's a change in the behavior, would not it better to set it for existing installs? -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11844] Additional fields for order lines
by bugzilla-daemon＠bugs.koha-community.org 04 Apr '16

04 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11844 --- Comment #20 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- (In reply to Katrin Fischer from comment #19) > Just some first notes on this: > > 1) New "add order line fields" page > > a) Test plan calls for adding fields with AV category and MARC field, but > this always results in this error message for me: > You cannot select an authorised value category and a marcfield Yes, the test plan is wrong: you cannot define both. > b) why have the datatable search field below the table instead of above? I > know we have other places where it's like this, but it always irritates me - > the search is most useful for a big table and this will require you to > scroll all the way to the end of the table first. It's the same behaviour as for serials, so I'd say it's expected. > d) it would be nice, if the table could use the new buttons we for Edit and > Delete as introduced for a lot of other tables recently to match the new > design pattern. Could be done by bug 15774 which create a new page to configure all of these additional fields. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14686] New menu option and permission for file uploading
by bugzilla-daemon＠bugs.koha-community.org 04 Apr '16

04 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14686 --- Comment #22 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- (In reply to Jonathan Druart from comment #21) > Why does upload_manage is not set by default? > Before this patch I was able to delete uploads, now I need the permission. You should be able to delete your own uploads, not the other ones. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14686] New menu option and permission for file uploading
by bugzilla-daemon＠bugs.koha-community.org 04 Apr '16

04 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14686 --- Comment #21 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Why does upload_manage is not set by default? Before this patch I was able to delete uploads, now I need the permission. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15126] REST API: Use newer version of Swagger2
by bugzilla-daemon＠bugs.koha-community.org 04 Apr '16

04 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15126 --- Comment #27 from Olli-Antti Kivilahti <olli-antti.kivilahti(a)jns.fi> --- (In reply to Benjamin Rokseth from comment #24) > Created attachment 49846 [details] [review] > Bug 15126: x-mojo-controller deprecation > > Remove the use of soon to be deprecated x-mojo-controller from our > specification and replace with the recommended operationId format. > > Signed-off-by: Benjamin Rokseth <benjamin.rokseth(a)kul.oslo.kommune.no> Also be advised that the new model of inferring the correct controller-subroutine -pair from the operationId is not without it's problems. Tho if you are willing to accept some clunkiness with the operationId, you can get by without the x-mojo-controller. One issue I found out is that the operationId "getStory" doesn't translate to Stories::Get, but it translates to something like Storys::Get, which might be rather confusing. This is not a stopper tho Just saying, be careful. use a lot of export SWAGGER2_DEBUG=1 :) -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14686] New menu option and permission for file uploading
by bugzilla-daemon＠bugs.koha-community.org 04 Apr '16

04 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14686 --- Comment #20 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- (In reply to Marcel de Rooy from comment #15) > (In reply to Marcel de Rooy from comment #13) > > So I am not convinced that we should move it. But if you really insist, I'd > > rather move it to Upload.pm or so? > > No reply is also an answer. > Jesse: I moved it. Please finish QA now. ok seen! -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14686] New menu option and permission for file uploading
by bugzilla-daemon＠bugs.koha-community.org 04 Apr '16

04 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14686 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart(a)bugs.koha-c | |ommunity.org --- Comment #19 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- (In reply to Jesse Weaver from comment #12) > I strongly believe that for consistency with the rest of Koha (and due to > frustrations that changing the autogenerated schema files causes), that the > sub allows_add_by should be moved to a Koha:: module. The code has no tie to > the uploaded_files table anyway. > > Koha::UploadedFiles might be a good name, as that could later easily become > a Koha::Objects subclass, but that's just a suggestion. I agree with Jesse, you are adding a new way to do something where we already have one. For instance, on Koha::Virtualshelf, there are several can_* methods taking a borrowernumber in parameter. It seems that it's exactly what you are achieving here. It would be better to stick on the current form or to suggest and move everything to another one. -- You are receiving this mail because: You are watching all bug changes.

1 0