April 2016 - Koha-bugs - lists.koha-community.org

[Bug 14686] New menu option and permission for file uploading
by bugzilla-daemon＠bugs.koha-community.org 04 Apr '16

04 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14686 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart(a)bugs.koha-c | |ommunity.org --- Comment #19 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- (In reply to Jesse Weaver from comment #12) > I strongly believe that for consistency with the rest of Koha (and due to > frustrations that changing the autogenerated schema files causes), that the > sub allows_add_by should be moved to a Koha:: module. The code has no tie to > the uploaded_files table anyway. > > Koha::UploadedFiles might be a good name, as that could later easily become > a Koha::Objects subclass, but that's just a suggestion. I agree with Jesse, you are adding a new way to do something where we already have one. For instance, on Koha::Virtualshelf, there are several can_* methods taking a borrowernumber in parameter. It seems that it's exactly what you are achieving here. It would be better to stick on the current form or to suggest and move everything to another one. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15126] REST API: Use newer version of Swagger2
by bugzilla-daemon＠bugs.koha-community.org 04 Apr '16

04 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15126 --- Comment #26 from Olli-Antti Kivilahti <olli-antti.kivilahti(a)jns.fi> --- (In reply to Julian Maurice from comment #17) > I just tested minifySwagger.pl and something bothers me : it resolves all > "$ref", meaning the "minified" file will be larger than the sum of all files > it comes from if the same "$ref" is used at least twice. > > Is it possible resolve only "$ref" that point to different files ? So we > keep the idea of a (small) single minified file and let the client resolve > the other refs. There are some issue with this approach. Firstly, if you want to have reusable reference contents, they probably must reside under the "Definitions Object", and the "Definitions Object" only accepts Schemas/Objects, so we cannot define reusable primitive data types, such as biblionumber. { type => 'String', description => 'descr' } Atleast I didn't figure out how to do it. Maybe you could add an extra level of nesting under the "Definitions Object" "x-primitive-definitions": { "biblionumber": { type => 'Integer', description => 'descr' } } but that might break any automatic Swagger2-tools. Also the way references are dereferenced is part of the core Mojolicious::Plugin::Swagger2-functionality and I am not so sure how the original author will like that change. I guess it would be nice to have and even doable, but it might be a really difficult algorithm to implement, which makes a complex system even more complex. The reason I implemented this approach is that external Swagger2-tools (like Swagger2 UI) doesn't resolve those references well, or was it that they dont reference at all (at the point of writing). I am not concerned about any repetition in the Swagger2-definition in Koha, tho you never know how it might affect us in the future. Anyway. I am currently working on implementing CORS-support for the Swagger2-API, because we need it now. This certainly is a challenge :) Also. We moved the /definitions/index.json to /definitions.json When you reference a definition, you had to write the reference like this: "$ref": "/definitions/index.json#/borrowernumber" now you can write the reference more easy: "$ref": "/definitions.json#/borrowernumber" Anyway you can find our newest Swagger2-definition from here: https://github.com/KohaSuomi/kohasuomi/tree/kohasuomi3.16/api/v1/swagger https://renki.vaarakirjastot.fi/api/v1/doc/ It took us quite some time to refactor to that model + a lot of testing :) But we are more interested in following the community model. However our API is a product of months of work and continuous self-improvement so I can say with confidence that we are taking the right route. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13669] Webinstaller fails on MySQL 5.6
by bugzilla-daemon＠bugs.koha-community.org 04 Apr '16

04 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13669 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=16094 -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13669] Webinstaller fails on MySQL 5.6
by bugzilla-daemon＠bugs.koha-community.org 04 Apr '16

04 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13669 --- Comment #6 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- (In reply to Humberto Blanco from comment #5) > Tomás, > I have similar problem with mysql enterprise end i need to modify the > database structure.so: > > ALTER TABLE aqorders ALTER COLUMN budgetgroup_id SET DEFAULT 0; This column does not seem to be used and could be removed. In the meanwhile it would be better to set it to NULL (and remove the NOT NULL constraint) instead of set it to 0 (which does not make sense). -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15126] REST API: Use newer version of Swagger2
by bugzilla-daemon＠bugs.koha-community.org 04 Apr '16

04 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15126 Benjamin Rokseth <benjamin.rokseth(a)kul.oslo.kommune.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15126] REST API: Use newer version of Swagger2
by bugzilla-daemon＠bugs.koha-community.org 04 Apr '16

04 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15126 Benjamin Rokseth <benjamin.rokseth(a)kul.oslo.kommune.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #49783|0 |1 is obsolete| | --- Comment #25 from Benjamin Rokseth <benjamin.rokseth(a)kul.oslo.kommune.no> --- Created attachment 49847 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49847&action=ed… Bug 15126: Update dependencies Signed-off-by: Benjamin Rokseth <benjamin.rokseth(a)kul.oslo.kommune.no> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15126] REST API: Use newer version of Swagger2
by bugzilla-daemon＠bugs.koha-community.org 04 Apr '16

04 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15126 Benjamin Rokseth <benjamin.rokseth(a)kul.oslo.kommune.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #49782|0 |1 is obsolete| | --- Comment #24 from Benjamin Rokseth <benjamin.rokseth(a)kul.oslo.kommune.no> --- Created attachment 49846 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49846&action=ed… Bug 15126: x-mojo-controller deprecation Remove the use of soon to be deprecated x-mojo-controller from our specification and replace with the recommended operationId format. Signed-off-by: Benjamin Rokseth <benjamin.rokseth(a)kul.oslo.kommune.no> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15126] REST API: Use newer version of Swagger2
by bugzilla-daemon＠bugs.koha-community.org 04 Apr '16

04 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15126 Benjamin Rokseth <benjamin.rokseth(a)kul.oslo.kommune.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #49781|0 |1 is obsolete| | --- Comment #23 from Benjamin Rokseth <benjamin.rokseth(a)kul.oslo.kommune.no> --- Created attachment 49845 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49845&action=ed… Bug 15126: Refactor spec file Spreading the specification over multiple files should lead to a more manageable specification long term Signed-off-by: Benjamin Rokseth <benjamin.rokseth(a)kul.oslo.kommune.no> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13903] Add API routes to list, create, update, delete reserves
by bugzilla-daemon＠bugs.koha-community.org 04 Apr '16

04 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13903 Benjamin Rokseth <benjamin.rokseth(a)kul.oslo.kommune.no> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |benjamin.rokseth(a)kul.oslo.k | |ommune.no Status|Needs Signoff |Signed Off --- Comment #15 from Benjamin Rokseth <benjamin.rokseth(a)kul.oslo.kommune.no> --- Rebased again on top of #15126, since #15126 had to be rebased on top of changes pushed to master. Tests updated and passing. API routes working as notified. Two small comments: - edit reserve requires both priority AND branchcode to update holding branch. This is probably some issue in C4::Reserves::ModReserve rather. - it would be nice to be able to reserve from barcode as alternative, but I see this needs support in modules first Setting to signed off as it works according to plan. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13903] Add API routes to list, create, update, delete reserves
by bugzilla-daemon＠bugs.koha-community.org 04 Apr '16

04 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13903 Benjamin Rokseth <benjamin.rokseth(a)kul.oslo.kommune.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45842|0 |1 is obsolete| | --- Comment #14 from Benjamin Rokseth <benjamin.rokseth(a)kul.oslo.kommune.no> --- Created attachment 49843 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49843&action=ed… Bug 13903: Add API routes to list, create, update, delete reserves GET /reserves?borrowernumber=X (list) POST /reserves (create) PUT /reserves/{reserve_id} (update) DELETE /reserves/{reserve_id} (delete) Unit tests in t/db_dependent/api/v1/reserves.t Test plan: 1. Apply patch 2. Run unit tests 3. Play with the API with your favorite REST client, using documentation in the swagger.json file 4. Try to make reserves until the maximum number of reserves for a user is reached (you should have a 403 error) Depends on bug 15126 Signed-off-by: Benjamin Rokseth <benjamin.rokseth(a)kul.oslo.kommune.no> -- You are receiving this mail because: You are watching all bug changes.

1 0