April 2016 - Koha-bugs - lists.koha-community.org

[Bug 14598] itemtype is not set on statistics by C4::Circulation::AddReturn
by bugzilla-daemon＠bugs.koha-community.org 01 Apr '16

01 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14598 Tomás Cohen Arazi <tomascohen(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47109|0 |1 is obsolete| | --- Comment #70 from Tomás Cohen Arazi <tomascohen(a)gmail.com> --- Created attachment 49798 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49798&action=ed… Bug 14598: Make C4::Circulation::AddReturn store the right itemtype This patch makes C4::Circulation::AddReturn correctly store the itemtype on the 'statistics' table. To reproduce: - Checkout master. - Make a checkout. - Check the 'statistics' table and notice the itemtype is correctly set > SELECT * FROM statistics; - Check the item in. - Check the 'statistics' table and notice the itemtype is not set > SELECT * FROM statistics WHERE type="return"; => FAIL: itemtype is set to NULL To test: - Apply the regression tests patch - Run the tests: $ prove t/db_dependent/Circulation/Returns.t => FAIL: Tests fail - Apply this patch - Run the regression tests: $ prove t/db_dependent/Circulation/Returns.t => SUCCESS: Tests now pass. - Repeat the 'To reproduce' steps => SUCCESS: itemtype is now correctly set (in real life) - Happily sign off :-D Sponsored-by: Universidad Empresarial Siglo 21 Signed-off-by: Kyle M Hall <kyle(a)bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14598] itemtype is not set on statistics by C4::Circulation::AddReturn
by bugzilla-daemon＠bugs.koha-community.org 01 Apr '16

01 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14598 Tomás Cohen Arazi <tomascohen(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47108|0 |1 is obsolete| | --- Comment #69 from Tomás Cohen Arazi <tomascohen(a)gmail.com> --- Created attachment 49797 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49797&action=ed… Bug 14598: (regression tests) AddReturn should store itemtype on 'statistics' table This patch adds tests for C4::Circulation::AddReturn(). Both tests are wrapped inside a subtest, and look for AddReturn storing the right itemtype on the 'statistics' table. Note: It also refactors the file a bit, to avoid side effects. And uses TestBuilder to make it independent on already-present db data. It also removes warnings by mocking C4::Context::userenv To test: - Apply the patch - Run the tests: $ prove t/db_dependent/Circulation/Returns.t => FAIL: Tests fail bacause AddReturn is not storing the itemtype - Sign off :-D Sponsored-by: Universidad Empresarial Siglo 21 Signed-off-by: Kyle M Hall <kyle(a)bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12446] Enable an adult to have a guarantor
by bugzilla-daemon＠bugs.koha-community.org 01 Apr '16

01 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446 Charles Farmer <charles.farmer(a)inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46486|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12446] Enable an adult to have a guarantor
by bugzilla-daemon＠bugs.koha-community.org 01 Apr '16

01 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446 Charles Farmer <charles.farmer(a)inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |charles.farmer(a)inlibro.com Attachment #46345|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12446] Enable an adult to have a guarantor
by bugzilla-daemon＠bugs.koha-community.org 01 Apr '16

01 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446 --- Comment #30 from Charles Farmer <charles.farmer(a)inlibro.com> --- Created attachment 49793 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49793&action=ed… Bug 12446 - Enable adult patrons to have a guarantor I have rebased every patch. This includes all the features from the previous patches. Removed the dollar signs and stopped using C4::Category On the patron category page, there is a new field to specify whether patrons can be guarantee or not. The atomic update SQL script adds this new field and sets it to true for categories of type "C" and "P". 1) Apply the patch 2) Run updatedatabase.pl to add AdditionalGuarantorField to preferences and canbeguarantee to categories. 3) Go to patron category administration, edit a category and change the value of Can Be Guarantee to yes (for Child and Professional mostly to set it by default) 4) See below to test various scenarios - Enable an adult to have a guarantor: 0.0) Create or edit a patron category of type 'A'. 0.1) Set the "Can be guarantee" field to "Yes" and save. 1) Select an adult patron -> details tab; 2) Click edit button; 3) validate "guarantor information" fieldset; - Shows guarantees' fines in the guarantor's page: 4) Click Set to patron button and select a guarantor; 5) Generate a fine; 6) Select guarantor patron -> details tab; 7) Validate guarantee's fine information. - Transfer some guarantor's information to the guarantee while adding a guarantiee: 0) Select an adult patron; 1) Insert all information; 2) Click Add guarantiee bouton; 3) Validade Garantor information/Main address/Contact fieldsets filled; - Transfer some guarantor's information to the guarantee while creating a new patron 0) Select an adult patron; 1) Insert all information; 2) Add a new adult patron; 3) Click "Set to patron" button; 4) Select the adult patron from 0); 5) Validade Garantor information/Main address/Contact fieldsets filled; - Transfer some guarantor's information to the guarantee while adding a guarantiee: 0) Select an adult patron; 1) Insert all information; 2) Click Add guarantiee bouton; 3) Validade Garantor information/Main address/Contact fieldsets filled; - Transfer guarantor's alternate address/contact to the guarantee while creating a new patron: 0) Search AdditionalGuarantorField preference; 1) Insert some additional database columns from alternate address/contact to be transferred from guarantor; 2) Select an adult patron; 3) Insert all information; 4) Add a new adult patron; 5) Click "Set to patron" button; 6) Select the adult patron from 0); 7) Validade Garantor information/Main address/Contact fieldsets filled; 8) Validade Garantor additional alternate address/contact filled; - Transfer guarantor's alternate address/contact to the guarantee while adding a guarantiee: 0) Search AdditionalGuarantorField preference; 1) Insert some additional database columns from alternate address/contact to be transferred from guarantor; 3) Select an adult patron; 4) Insert all information; 5) Click Add guarantiee bouton; 6) Validade Garantor information/Main address/Contact fieldsets filled; 7) Validade Garantor additional alternate address/contact filled; -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12446] Enable an adult to have a guarantor
by bugzilla-daemon＠bugs.koha-community.org 01 Apr '16

01 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446 Charles Farmer <charles.farmer(a)inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15006] Need to distinguish client timeout from login timeout
by bugzilla-daemon＠bugs.koha-community.org 01 Apr '16

01 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15006 --- Comment #15 from Colin Campbell <colin.campbell(a)ptfs-europe.com> --- (In reply to Kyle M Hall from comment #13) > I will try to find some time to run some tests. Here is what I will do: > > 1) Revert 13432 on master > 2) Set up a script that continuously makes sip2 calls via sip_cli_emulator.pl > 3) Let that run for a long time > 4) Note whether memory usage increases dramatically > 5) Apply this patch > 6) Repeat steps 2-4 > 6) Apply bug 15006 > 7) Repeat steps 2-4 > > If everything checks out, we should move ahead with this. > > Colin, does that seem like a reasonable test plan? Yes - Would be interested if the same test was run using Netserver::Fork, instead of Netserver::Prefork that should return resources from dead connections (although memory leak may be elsewhere) -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11807] Add categorycode conversions to LDAP authentication.
by bugzilla-daemon＠bugs.koha-community.org 01 Apr '16

01 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11807 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #15 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Happy there no breaking changes here, and a worthwhile addition. :) -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11807] Add categorycode conversions to LDAP authentication.
by bugzilla-daemon＠bugs.koha-community.org 01 Apr '16

01 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11807 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46183|0 |1 is obsolete| | --- Comment #14 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 49790 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49790&action=ed… Bug 11807: (follow-up) remove date conversions To test 1/ Apply both patches 2/ This patch lets you easily configure mappings for categorycode values. These mapping will be used when updating the user's account after a successful LDAP login. Here is an example configuration : <config> <ldapserver id="ldapserver> <mapping> <categorycode is="usertype">STU</categorycode> ... </mapping> <categorycode_mapping> <categorycode value="STU">STUDENT</categorycode> <categorycode value="EMP">EMPLOYEE</categorycode> </categorycode_mapping> </ldapserver> </config> 3/ With this configuration, LDAP users with the usertype value "EMP" on the LDAP server should have the "EMPLOYEE" categorycode in Koha. Signed-off-by: Chris <chris(a)bigballofwax.co.nz> Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11807] Add categorycode conversions to LDAP authentication.
by bugzilla-daemon＠bugs.koha-community.org 01 Apr '16

01 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11807 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46182|0 |1 is obsolete| | --- Comment #13 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 49789 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49789&action=ed… Bug 11807 : Add support for categorycode conversions when updating an user using a LDAP server. To test 1/ Apply both patches 2/ This patch lets you easily configure mappings for categorycode values. These mapping will be used when updating the user's account after a successful LDAP login. Here is an example configuration : <config> <ldapserver id="ldapserver> <mapping> <categorycode is="usertype">STU</categorycode> ... </mapping> <categorycode_mapping> <categorycode value="STU">STUDENT</categorycode> <categorycode value="EMP">EMPLOYEE</categorycode> </categorycode_mapping> </ldapserver> </config> 3/ With this configuration, LDAP users with the usertype value "EMP" on the LDAP server should have the "EMPLOYEE" categorycode in Koha. Signed-off-by: Chris <chris(a)bigballofwax.co.nz> Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

1 0