May 2016 - Koha-bugs - lists.koha-community.org

[Bug 16428] New: The framework is not checked to know if a field is mapped
by bugzilla-daemon＠bugs.koha-community.org 16 Jun '16

16 Jun '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16428 Bug ID: 16428 Summary: The framework is not checked to know if a field is mapped Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart(a)bugs.koha-community.org Reporter: jonathan.druart(a)bugs.koha-community.org QA Contact: testopia(a)bugs.koha-community.org Depends on: 12874 Blocks: 13074 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12874 [Bug 12874] On editing an item, some fields can be set to NULL https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13074 [Bug 13074] C4::Items::_build_default_values_for_mod_marc should use Koha::Cache -- You are receiving this mail because: You are watching all bug changes.

1 19

[Bug 16441] New: C4::Letters::getletter is not plack safe
by bugzilla-daemon＠bugs.koha-community.org 16 Jun '16

16 Jun '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16441 Bug ID: 16441 Summary: C4::Letters::getletter is not plack safe Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart(a)bugs.koha-community.org Reporter: jonathan.druart(a)bugs.koha-community.org QA Contact: testopia(a)bugs.koha-community.org Depends on: 9452 Blocks: 7172 C4::Letters::getletter use a package variable (%letter) to cache letter returned by the subroutine. I have not found any direct issues caused by that but it is safer to remove it. It won't be a big deal to hit the DBMS to get a valid letter when needed. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7172 [Bug 7172] Omnibus for Plack variable scoping problems https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9452 [Bug 9452] C4::Letters does not function under Plack -- You are receiving this mail because: You are watching all bug changes.

1 22

[Bug 16570] New: All checked-in items are said to be part of a rotating collection
by bugzilla-daemon＠bugs.koha-community.org 16 Jun '16

16 Jun '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16570 Bug ID: 16570 Summary: All checked-in items are said to be part of a rotating collection Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Circulation Assignee: koha-bugs(a)lists.koha-community.org Reporter: oleonard(a)myacpl.org QA Contact: testopia(a)bugs.koha-community.org CC: alex.arnaud(a)biblibre.com, benjamin.rokseth(a)kul.oslo.kommune.no, claire.hernandez(a)biblibre.com, gmcharlt(a)gmail.com, jonathan.druart(a)bugs.koha-community.org, julian.maurice(a)biblibre.com, kyle.m.hall(a)gmail.com, kyle(a)bywatersolutions.com, testopia(a)bugs.koha-community.org, veron(a)veron.ch Depends on: 15564 I have no rotating collections defined, but every time I check something in I get a message that the item is part of a rotating collection and needs to be transferred. git bisect blames commit 30dc04c74a2ef00c22667f722746c2c6be1da6b1 (Bug 15564). Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15564 [Bug 15564] Display "print slip" option when returning an item which is in a rotating collection -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 12

[Bug 16443] New: C4::Members::Statistics is not plack safe
by bugzilla-daemon＠bugs.koha-community.org 16 Jun '16

16 Jun '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16443 Bug ID: 16443 Summary: C4::Members::Statistics is not plack safe Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: major Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart(a)bugs.koha-community.org Reporter: jonathan.druart(a)bugs.koha-community.org QA Contact: testopia(a)bugs.koha-community.org Blocks: 7172 If the prefs is updated, the fields won't be. To make sure we already fetch updated values, we should remove the package variable and define it in the subroutine. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7172 [Bug 7172] Omnibus for Plack variable scoping problems -- You are receiving this mail because: You are watching all bug changes.

1 14

[Bug 16455] New: TagsExternalDictionary does not work under Plack
by bugzilla-daemon＠bugs.koha-community.org 16 Jun '16

16 Jun '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16455 Bug ID: 16455 Summary: TagsExternalDictionary does not work under Plack Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart(a)bugs.koha-community.org Reporter: jonathan.druart(a)bugs.koha-community.org QA Contact: testopia(a)bugs.koha-community.org Depends on: 16444 The pref TagsExternalDictionary is used to tell Lingua::Ispell to use an other dictionary, different from the default one (/usr/bin/ispell). To do so we need to set $Lingua::Ispell::path to the expected path. It's currently done in the INIT block. If you try to use C4::Tags, you will get the famous "Too late to run INIT block at C4/Tags.pm line 74." warning. Plack use the INIT block to load functions at run time, when we are using C4::Tags when hitting a pl script, the compilation phase is finished and it's "too late to run INIT block" from C4::Tags. I do not really know if it has an impact on the behavior of Lingua::Ispell (i.e. is the path redefined?), but I know that this INIT block is not executed when we want. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16444 [Bug 16444] C4::Tags is not plack safe -- You are receiving this mail because: You are watching all bug changes.

1 21

[Bug 16508] New: User permission "parameters_remaining_permissions Remaining system parameters permissions" does not allow saving systempreferences.
by bugzilla-daemon＠bugs.koha-community.org 16 Jun '16

16 Jun '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16508 Bug ID: 16508 Summary: User permission "parameters_remaining_permissions Remaining system parameters permissions" does not allow saving systempreferences. Change sponsored?: --- Product: Koha Version: 3.22 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs(a)lists.koha-community.org Reporter: barton(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com A staff borrower with catalogue and "parameters_remaining_permissions Remaining system parameters permissions" cannot save sysprefs. To recreate: 1/ Create a staff user. 2/ Go to details, select more->set permissions. 3/ Set catalogue, Manage Koha system settings (Administration panel), manage circulation rules, and Remaining system parameters permissions. 4/ Log in as the new staff user, go to administration > system preferences. Change a syspref and save it... it will save correctly. 5/ Log back in as superlibrarian 6/ On the 'set permissions' screen, un-check 'manage circulation rules' and save. 7/ Log back in to the new staff user, and try to change the same systemprefrence and save. You will see the following message: Error; your data might not have been saved You need to log in again, your session has timed out. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

2 13

[Bug 16518] New: opac-addbybiblionumber is not plack safe
by bugzilla-daemon＠bugs.koha-community.org 16 Jun '16

16 Jun '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16518 Bug ID: 16518 Summary: opac-addbybiblionumber is not plack safe Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: major Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart(a)bugs.koha-community.org Reporter: jonathan.druart(a)bugs.koha-community.org QA Contact: testopia(a)bugs.koha-community.org Blocks: 7172 The script opac/opac-addbybiblionumber.pl is not plack safe because the variable @biblios is declared with our and is not assigned to an empty array (so not reset). Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7172 [Bug 7172] Omnibus for Plack variable scoping problems -- You are receiving this mail because: You are watching all bug changes.

1 13

[Bug 16458] New: Setting to guarantor: JavaScript error form.branchcode is undefined
by bugzilla-daemon＠bugs.koha-community.org 16 Jun '16

16 Jun '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16458 Bug ID: 16458 Summary: Setting to guarantor: JavaScript error form.branchcode is undefined Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Patrons Assignee: koha-bugs(a)lists.koha-community.org Reporter: veron(a)veron.ch QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com To reproduce: - Go to a child parton's detail page - Edit it using the toolbar item "Edit" - Edit "Guarantor information", "Set to patron" or "Change patron" - Select a patron =>Result OK (patron search window closes, guarantor information is set, e.g. Library changes to Guarantor's library if it is different) - Go back to child patron's detail page - This time do not use toolbar "Edit" but the "Edit" link below "Date of birth" / "Guarantor" - Edit "Guarantor information", "Set to patron" or "Change patron" - Select a patron =>Result NOT OK (patron search window does not close, JavaScript console says: TypeError: form.branchcode is undefined (...)/intranet-tmpl/prog/js/members.js Line: 213 Some of the Guarantor's information is not set, e.g. library if it is different. I found this while testing Bug 16450, this error appears without and with 16450 applied. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 16

[Bug 16442] New: C4::Ris is not plack safe
by bugzilla-daemon＠bugs.koha-community.org 16 Jun '16

16 Jun '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16442 Bug ID: 16442 Summary: C4::Ris is not plack safe Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart(a)bugs.koha-community.org Reporter: jonathan.druart(a)bugs.koha-community.org QA Contact: testopia(a)bugs.koha-community.org Blocks: 7172 C4::Ris incorrectly uses 4 package variables: - $utf: not used, can be removed - $intype: set to marcflavour once, but later it assumes that it is usmarc if not defined our $marcprint: always 0, so set it to 0 our $protoyear: only used in 1 subroutine, let's define it at this level Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7172 [Bug 7172] Omnibus for Plack variable scoping problems -- You are receiving this mail because: You are watching all bug changes.

1 13

[Bug 16582] New: t/Price.t test should pass if Test::DBIx::Class is not available
by bugzilla-daemon＠bugs.koha-community.org 16 Jun '16

16 Jun '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16582 Bug ID: 16582 Summary: t/Price.t test should pass if Test::DBIx::Class is not available Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Test Suite Assignee: chris(a)bigballofwax.co.nz Reporter: mtompset(a)hotmail.com QA Contact: gmcharlt(a)gmail.com I just spent hours doing git clone to attempt the install pain under Ubuntu 16.04 LTS to see what the problem is, and the tests were still bugging me. I'm going to attach 2 commits. The first is just to get the load test to keep going, and should not be used. The second will fill the t/Price.t in a manner similar to t/Members_AttributeTypes.t in bug 15150 was fixed. TEST PLAN --------- 1) try prove t -- load will bomb 2) apply first patch -- prices will fail 3) apply second patch -- prices will "succeed" 4) run koha qa test tools -- You are receiving this mail because: You are watching all bug changes.

1 30