May 2016 - Koha-bugs - lists.koha-community.org

[Bug 13669] Web installer fails to load sample data on MySQL 5.6+
by bugzilla-daemon＠bugs.koha-community.org 31 May '16

31 May '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13669 --- Comment #69 from Julian Maurice <julian.maurice(a)biblibre.com> --- I forgot the last followup in 3.22.7, it will be in 3.22.8 -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15541] Prevent normalization during matching/import process
by bugzilla-daemon＠bugs.koha-community.org 31 May '16

31 May '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15541 --- Comment #21 from David Cook <dcook(a)prosentient.com.au> --- (In reply to Marcel de Rooy from comment #20) > I understand your point hopefully :) > If we start using this field: Since it was meant to add a Normalize class, I > think you should create at least a rudimentary one now. > Moving the _normalize code and add your none/raw normalizations. I'm not sure that I understand your point, unfortunately :(. I think using normalization during matching is a bad idea, as Zebra already normalizes the query before processing it. Here's the problem: Custom normalization: Strip hyphens Zebra normalization: Strip colons Data: "Mont-Royal: it's a mountain" Zebra would index it as "Mont-Royal it's a mountain". You'd retrieve that exact phrase with the query "Mont-Royal: it's a mountain", which would be transformed into "Mont-Royal it's a mountain" by Zebra. However, with the custom normalization, your query would be "MontRoyal: it's a mountain" before going to Zebra, and then it would be "MontRoyal it's a mountain" when processed by Zebra. If you're doing an exact search, your search will fail, even though that same data in the regular Koha search would work. We need to normalize indexing/retrieval consistently, and the way to do that is with Zebra alone. If there needs to be extra normalization, I think it should be done before the record even makes it to Koha... -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12598] New misc/import_borrowers.pl command line tool
by bugzilla-daemon＠bugs.koha-community.org 31 May '16

31 May '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598 Mason James <mtj(a)kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj(a)kohaaloha.com -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14571] using_https check for ssl connections doesn't work in some situations
by bugzilla-daemon＠bugs.koha-community.org 30 May '16

30 May '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14571 --- Comment #22 from Oliver Bock <oliver.bock(a)aei.mpg.de> --- (In reply to Jonathan Druart from comment #21) > Would you please open a new bug report (and link it to this one) to attach > your patch? > This one is marked as "pushed to master" and new patches should go on their > own bug report. Done: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16615 -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 5534] Koha does not ignore punctuation when searching
by bugzilla-daemon＠bugs.koha-community.org 30 May '16

30 May '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5534 Marjorie Barry-Vila <marjorie.barry-vila(a)ccsr.qc.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila(a)ccsr.qc | |.ca -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15541] Prevent normalization during matching/import process
by bugzilla-daemon＠bugs.koha-community.org 30 May '16

30 May '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15541 --- Comment #20 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- (In reply to David Cook from comment #19) > While the matchpoint_component_norms.norm_routine isn't currently used in > the code, I add some code that does use it for the sole purpose of detecting > a "none" or "raw" normalization (ie no normalization). > > Sorry, but I'm still not sure what you're asking, Marcel. Honestly, there > should probably be no normalization at this step. I would remove the > "Normalization rule" from the code, but it affects too many existing > systems. The patch I have here is the lightest change while also providing > the desired functionality. I'm not sure what else a person could do to skip > the normalization in a way that is backwards compatible. I understand your point hopefully :) If we start using this field: Since it was meant to add a Normalize class, I think you should create at least a rudimentary one now. Moving the _normalize code and add your none/raw normalizations. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15630] Make Edifact module pluggable
by bugzilla-daemon＠bugs.koha-community.org 30 May '16

30 May '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15630 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy(a)rijksmuseum.nl --- Comment #14 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- (In reply to David Cook from comment #13) > > +use Module::Pluggable search_path => ['Koha::Plugin'], except => qr/::Edifact(|::Line|::Message|::Order|::Segment|::Transport)$/; > > This seems suboptimal... since any plugin with additional packages would > need an exception. Have the same feeling when I see these lines.. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13528] Ability to search on the different isbn variations
by bugzilla-daemon＠bugs.koha-community.org 30 May '16

30 May '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13528 Magnus Enger <magnus(a)libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=16595 -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14571] using_https check for ssl connections doesn't work in some situations
by bugzilla-daemon＠bugs.koha-community.org 30 May '16

30 May '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14571 Oliver Bock <oliver.bock(a)aei.mpg.de> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=16615 -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15630] Make Edifact module pluggable
by bugzilla-daemon＠bugs.koha-community.org 30 May '16

30 May '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15630 --- Comment #13 from David Cook <dcook(a)prosentient.com.au> --- Comment on attachment 49788 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49788 Bug 15630 - Make Edifact module pluggable Review of attachment 49788: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=156…) ----------------------------------------------------------------- ::: Koha/Plugins.pm @@ +20,4 @@ > use Modern::Perl; > > use Module::Load::Conditional qw(can_load); > +use Module::Pluggable search_path => ['Koha::Plugin'], except => qr/::Edifact(|::Line|::Message|::Order|::Segment|::Transport)$/; This seems suboptimal... since any plugin with additional packages would need an exception. Wouldn't it make more sense to use "only" to only find plugins like ^Koha::Plugin::Com::CompanyName::PluginName$. I suppose it might be too late for that now as there's any number of plugins that can be allowed so perhaps one does have to only use exceptions from now on... I'm thinking of making a plugin, but I'll probably just use a different namespace like Local::PluginName::Submodules... -- You are receiving this mail because: You are watching all bug changes.

1 0