May 2016 - Koha-bugs - lists.koha-community.org

[Bug 10459] borrowers should have a timestamp
by bugzilla-daemon＠bugs.koha-community.org 27 May '16

27 May '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10459 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #51844|0 |1 is obsolete| | --- Comment #51 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 51868 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51868&action=ed… Bug 10459 renamed timestamp to updated_on Signed-off-by: Joy Nelson <joy(a)bywatersolutions.com> Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10459] borrowers should have a timestamp
by bugzilla-daemon＠bugs.koha-community.org 27 May '16

27 May '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10459 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #51843|0 |1 is obsolete| | --- Comment #50 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 51867 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51867&action=ed… Bug 10459: Follow up to update to atomic update methodology Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel(a)gmail.com> New column created, no errors. Signed-off-by: Mark Tompsett <mtompset(a)hotmail.com> Signed-off-by: Joy Nelson <joy(a)bywatersolutions.com> Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7141] The biblio details page in the intranet doesn't work if XSLT is activated and the xsl file contains "  "
by bugzilla-daemon＠bugs.koha-community.org 27 May '16

27 May '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7141 Fridolin SOMERS <fridolin.somers(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |16608 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16608 [Bug 16608] Missing entity nbsp in some XML files -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 5670] Housebound Readers Module
by bugzilla-daemon＠bugs.koha-community.org 27 May '16

27 May '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5670 --- Comment #28 from Alex Sassmannshausen <alex.sassmannshausen(a)ptfs-europe.com> --- Hello, Thank you for the review. A few comments and questions from my side, but will be implementing the rest of your suggestions. > ::: C4/Auth.pm > @@ +435,4 @@ >> ); >> if ( $in->{'type'} eq "intranet" ) { >> $template->param( >> + useHouseboundModule => C4::Context->preference("useHouseboundModule"), > There is no need to do this. The preferences are accessible in the template, see other templates which grab preferences already. Good point, will remove this. > ::: koha-tmpl/intranet-tmpl/prog/en/modules/members/housebound.tt > @@ +110,5 @@ >> + <option value="friday">Friday</option> >> + <option value="saturday">Saturday</option> >> + <option value="sunday">Sunday</option> >> + [% END %] >> + </select> > Couldn't all this select logic be simplified with a loop? I'd be worried about translation — I'm not 100% sure how it works, but aren't simple strings in the UI the way to go for translation? > @@ +122,5 @@ >> + <option value="[% frequency.value %]" selected="selected">[% frequency.label %]</option> >> + [% ELSE %] >> + <option value="[% frequency.value %]">[% frequency.label %]</option> >> + [% END %] >> + [% END %] > Like this. I'm not concerned about translation here, as Frequencies are directly editables as authorized values by end users. > @@ +335,5 @@ >> + [% ELSIF hpd == 'saturday' %] >> + Saturday >> + [% ELSIF hpd == 'sunday' %] >> + Sunday >> + [% END %] > http://template-toolkit.org/docs/manual/VMethods.html#section_ucfirst Again, I would have concerns about translation here — but if this is not a concern for translation, then I'd be happy to implement that. > ::: members/housebound.pl > @@ +82,5 @@ >> + fav_itemtypes => $input->param('fav_itemtypes'), >> + fav_subjects => $input->param('fav_subjects'), >> + fav_authors => $input->param('fav_authors'), >> + referral => $input->param('referral'), >> + notes => $input->param('notes'), > Perhaps // q{} or something similar might be nice, just in case there's undefined parameters. Fair point, will implement :-) > ::: t/db_dependent/Patron/Housebound.t > @@ +64,5 @@ >> +foreach my $cho ( @{$found_choosers} ) { >> + $cho_counter ++ >> + if ( $cho->borrowernumber eq $patron_chooser->{borrowernumber} ); >> +}; >> +is(1, 1, "Return our patron_chooser!"); > What is the point of this test? This is testing that the Extended Borrower Atrributes work as expected in this context: - that our `housebound_choosers` method works as expected - that we, in this controlled environment, only return one chooser patron - and that chooser is the one that we expect it to be. > @@ +73,5 @@ >> +foreach my $del ( @{$found_deliverers} ) { >> + $del_counter ++ >> + if ( $del->borrowernumber eq $patron_deliverer->{borrowernumber} ); >> +}; >> +is(1,1,"Return our patron_deliverer!"); > What is the point of this test? Same as above, but for deliverers. WDYT? Alex -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

1 0

[Bug 5620] Capture Mode of payment
by bugzilla-daemon＠bugs.koha-community.org 27 May '16

27 May '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5620 --- Comment #6 from M. Tompsett <mtompset(a)hotmail.com> --- Comment on attachment 51290 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51290 bug 5620 - Capture Mode of payment, receipt number and notes in pay fines. Review of attachment 51290: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=562…) ----------------------------------------------------------------- ::: C4/Accounts.pm @@ +89,4 @@ > sub recordpayment { > > #here we update the account lines > + my ( $borrowernumber, $data, $sip_paytype, $payment_note, $paymentmode ) = @_; "PERL16: Hashrefs should be used as arguments" Perhaps refactor is in order? There are already too many parameters. ::: installer/data/mysql/atomicupdate/bug5620_Add_Mode_Of_Payment.perl @@ +10,5 @@ > +$dbh->do("alter table accountlines add column paymentmode text not null"); > +$dbh->do("insert into authorised_values (category, authorised_value, lib, lib_opac) values('PAYMODE','CASH','Cash', 'Cash')"); > +$dbh->do("insert into authorised_values (category, authorised_value, lib, lib_opac) values('PAYMODE','CC','Credit Card', 'Credit Card')"); > +$dbh->do("insert into authorised_values (category, authorised_value, lib, lib_opac) values('PAYMODE','DEBIG','Debit', 'Debit')"); > +print "bug5620 - add mode of payment"; Why not do this as a sql file? Also, missing kohastructure.sql patch. ::: members/paycollect.pl @@ +50,5 @@ > +my $sth = $dbh->prepare('SELECT * FROM authorised_values WHERE category = "PAYMODE"'); > +$sth->execute(); > +while ( my $row = $sth->fetchrow_hashref() ) { > + push @paymentmodes, $row; > +} This should probably be some nice function in some authorised value library somewhere. -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.

1 0

[Bug 5670] Housebound Readers Module
by bugzilla-daemon＠bugs.koha-community.org 27 May '16

27 May '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5670 --- Comment #27 from M. Tompsett <mtompset(a)hotmail.com> --- Comment on attachment 51377 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51377 Rebase on master Review of attachment 51377: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=567…) ----------------------------------------------------------------- ::: C4/Auth.pm @@ +435,4 @@ > ); > if ( $in->{'type'} eq "intranet" ) { > $template->param( > + useHouseboundModule => C4::Context->preference("useHouseboundModule"), There is no need to do this. The preferences are accessible in the template, see other templates which grab preferences already. ::: koha-tmpl/intranet-tmpl/prog/en/includes/circ-menu.inc @@ +105,4 @@ > [% IF CAN_user_borrowers && useDischarge %] > [% IF dischargeview %]<li class="active">[% ELSE %]<li>[% END %]<a href="/cgi-bin/koha/members/discharge.pl?borrowernumber=[% borrowernumber %]">Discharge</a></li> > [% END %] > + [% IF Koha.Preference('HouseboundModule') %] See, like here. ::: koha-tmpl/intranet-tmpl/prog/en/modules/members/housebound.tt @@ +110,5 @@ > + <option value="friday">Friday</option> > + <option value="saturday">Saturday</option> > + <option value="sunday">Sunday</option> > + [% END %] > + </select> Couldn't all this select logic be simplified with a loop? @@ +122,5 @@ > + <option value="[% frequency.value %]" selected="selected">[% frequency.label %]</option> > + [% ELSE %] > + <option value="[% frequency.value %]">[% frequency.label %]</option> > + [% END %] > + [% END %] Like this. @@ +335,5 @@ > + [% ELSIF hpd == 'saturday' %] > + Saturday > + [% ELSIF hpd == 'sunday' %] > + Sunday > + [% END %] http://template-toolkit.org/docs/manual/VMethods.html#section_ucfirst ::: members/housebound.pl @@ +82,5 @@ > + fav_itemtypes => $input->param('fav_itemtypes'), > + fav_subjects => $input->param('fav_subjects'), > + fav_authors => $input->param('fav_authors'), > + referral => $input->param('referral'), > + notes => $input->param('notes'), Perhaps // q{} or something similar might be nice, just in case there's undefined parameters. ::: t/db_dependent/Patron/Housebound.t @@ +64,5 @@ > +foreach my $cho ( @{$found_choosers} ) { > + $cho_counter ++ > + if ( $cho->borrowernumber eq $patron_chooser->{borrowernumber} ); > +}; > +is(1, 1, "Return our patron_chooser!"); What is the point of this test? @@ +73,5 @@ > +foreach my $del ( @{$found_deliverers} ) { > + $del_counter ++ > + if ( $del->borrowernumber eq $patron_deliverer->{borrowernumber} ); > +}; > +is(1,1,"Return our patron_deliverer!"); What is the point of this test? -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.

1 0

[Bug 15107] Batch Patron Deletion (Trash) Performance Improvement
by bugzilla-daemon＠bugs.koha-community.org 26 May '16

26 May '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15107 --- Comment #9 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Shame, this one seems to have lost its head of steam :-( -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 0

[Bug 12648] Link patrons to an order
by bugzilla-daemon＠bugs.koha-community.org 26 May '16

26 May '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12648 Christopher Brannon <cbrannon(a)cdalibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cbrannon(a)cdalibrary.org --- Comment #79 from Christopher Brannon <cbrannon(a)cdalibrary.org> --- I'm not finding any reference to this feature in the manual. Is it there? -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12682] Shibboleth attribute manipulation
by bugzilla-daemon＠bugs.koha-community.org 26 May '16

26 May '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12682 --- Comment #2 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- I'm afraid I never got to this one, I had too many other outstanding shibboleth via awaiting signoff and qa to devote time to this. In another ago I wrote shibboleth interactions for however, we use perl config files. It was very easy there to just replace the simple mapping with more complex control statements anonymous subroutine references.. That's likely how I would attempt to impliment such a piece these days -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11375] Patron permission names are untranslatable
by bugzilla-daemon＠bugs.koha-community.org 26 May '16

26 May '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11375 --- Comment #5 from Owen Leonard <oleonard(a)myacpl.org> --- Created attachment 51847 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51847&action=ed… Idea for a patron permissions interface redesign I wonder if we should deemphasize the permission code? As a developer I look for the code because I usually know what I'm looking for. Perhaps it would be friendlier to put the focus on the translatable text? (also I want to get rid of jstree) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 0