May 2016 - Koha-bugs - lists.koha-community.org

[Bug 9836] Filtering sort1 list according to patron category in patron data
by bugzilla-daemon＠bugs.koha-community.org 27 May '16

27 May '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9836 --- Comment #17 from Koha Team Lyon 3 <koha(a)univ-lyon3.fr> --- No, I gave up this patch Olivier Crouzet -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10459] borrowers should have a timestamp
by bugzilla-daemon＠bugs.koha-community.org 27 May '16

27 May '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10459 --- Comment #55 from M. Tompsett <mtompset(a)hotmail.com> --- (In reply to Marcel de Rooy from comment #52) > What about filling created_on once in AddMember ? > Mysql accepts: > `stamp1` timestamp NULL DEFAULT NULL, > `stamp2` timestamp NOT NULL DEFAULT CURRENT_TIMESTAMP ON UPDATE > CURRENT_TIMESTAMP That's a possibility, but the idea was just a structural change. The updated_on is sufficient for the bug's original intention. (In reply to Bernardo Gonzalez Kriegel from comment #54) > Which MySQL version? Whatever is current with Debian 8, I believe. (In reply to Bernardo Gonzalez Kriegel from comment #54) > For example this two columns in virtualshelves give problems on 5.7: > > `lastmodified` timestamp NOT NULL default CURRENT_TIMESTAMP on update > CURRENT_TIMESTAMP, -- date and time the list was last modified > `created_on` TIMESTAMP NOT NULL, -- creation time Well, obviously, because NOT NULL means you need a default value. MySQL is trying to avoid the NULL vs. 0000-00-00 issue. That's why Marcel was suggesting NULL default NULL above. My comment was aimed at the disappointment that the following: `updated_on` timestamp NOT NULL default CURRENT_TIMESTAMP on update CURRENT_TIMESTAMP, -- date and time the list was last modified `created_on` TIMESTAMP NOT NULL default CURRENT_TIMESTAMP, -- creation time Which probably is the equivalent to the less explicit version BKG gave above. QA-wise, this should be just fine. I'd push a secondary patch to add created_on with an update in the appropriate Koha perl code in another bug. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14507] SIP Authentication broken when LDAP Auth Enabled
by bugzilla-daemon＠bugs.koha-community.org 27 May '16

27 May '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14507 Kyle M Hall <kyle(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |16610 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16610 [Bug 16610] Regression in SIP2 user password handling -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15303] Letsencrypt option for Debian package installations
by bugzilla-daemon＠bugs.koha-community.org 27 May '16

27 May '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15303 Mirko Tietgen <mirko(a)abunchofthings.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed for QA |Pushed to Master -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15303] Letsencrypt option for Debian package installations
by bugzilla-daemon＠bugs.koha-community.org 27 May '16

27 May '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15303 Mirko Tietgen <mirko(a)abunchofthings.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Pushed for QA --- Comment #62 from Mirko Tietgen <mirko(a)abunchofthings.net> --- sorry, changed by accident. can somebody set it back to pushed to master? i'm not allowed to -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15303] Letsencrypt option for Debian package installations
by bugzilla-daemon＠bugs.koha-community.org 27 May '16

27 May '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15303 Mirko Tietgen <mirko(a)abunchofthings.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |In Discussion -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 5670] Housebound Readers Module
by bugzilla-daemon＠bugs.koha-community.org 27 May '16

27 May '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5670 --- Comment #29 from Alex Sassmannshausen <alex.sassmannshausen(a)ptfs-europe.com> --- Created attachment 51875 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51875&action=ed… Housebound Schema Updates Apply this patch to no longer have to manually regenerate the Schema files. -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.

1 0

[Bug 10459] borrowers should have a timestamp
by bugzilla-daemon＠bugs.koha-community.org 27 May '16

27 May '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10459 --- Comment #54 from Bernardo Gonzalez Kriegel <bgkriegel(a)gmail.com> --- (In reply to Marcel de Rooy from comment #52) > What about filling created_on once in AddMember ? > Mysql accepts: > `stamp1` timestamp NULL DEFAULT NULL, > `stamp2` timestamp NOT NULL DEFAULT CURRENT_TIMESTAMP ON UPDATE > CURRENT_TIMESTAMP Which MySQL version? For example this two columns in virtualshelves give problems on 5.7: `lastmodified` timestamp NOT NULL default CURRENT_TIMESTAMP on update CURRENT_TIMESTAMP, -- date and time the list was last modified `created_on` TIMESTAMP NOT NULL, -- creation time loading kohastructure fails with line: 2212 `created_on` TIMESTAMP NOT NULL, -- creation time error: (Invalid default value for 'created_on'): CREATE TABLE `virtualshelves` It seems that we will find some problems because of the new version default sql_mode. It's something that we need to address. ATM neither 16.05 nor 3.22 run on Ubuntu 16.04. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10459] borrowers should have a timestamp
by bugzilla-daemon＠bugs.koha-community.org 27 May '16

27 May '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10459 --- Comment #53 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- And another question: We may expect some libraries to have inserted a custom timestamp column already in the borrowers table. They will run into the same problem as Mark described above here. Would it make sense to check in the database revision if that is the case and skip the dbrev with a warning? (They could rename the field manually?) -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10459] borrowers should have a timestamp
by bugzilla-daemon＠bugs.koha-community.org 27 May '16

27 May '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10459 --- Comment #52 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- (In reply to M. Tompsett from comment #49) > I went with an updated_on, as created_on is static, and the point was for > diagnosis to know when something was last done with the borrower record. And > I couldn't figure out how to get two time stamps using MySQL to auto-fill (a > created_on and an updated_on) in the same table. What about filling created_on once in AddMember ? Mysql accepts: `stamp1` timestamp NULL DEFAULT NULL, `stamp2` timestamp NOT NULL DEFAULT CURRENT_TIMESTAMP ON UPDATE CURRENT_TIMESTAMP -- You are receiving this mail because: You are watching all bug changes.

1 0