June 2016 - Koha-bugs - lists.koha-community.org

[Bug 15165] REST API routes to list, edit and pay borrower's accountlines
by bugzilla-daemon＠bugs.koha-community.org 22 Jun '16

22 Jun '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15165 Lari Taskula <larit(a)student.uef.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |In Discussion --- Comment #15 from Lari Taskula <larit(a)student.uef.fi> --- (In reply to Andreas Hedström Mace from comment #10) > Created attachment 50790 [details] [review] > It is not possible to pay specified/partial amounts (for one or more > accountlines). Maybe I misunderstood the problem, but doesn't this do it: PUT /accountlines/123/partialpayment {"amount": 5.00, "description": "payment description"} Or pay payment with specific amount to borrower: PUT /accountlines/:borrowernumber/amountpayment { "amount": 5, "description": "payment description" } Anyway, comments to this bug. I think some fixes are needed. - Payments should be POST instead of PUT (PUT is idempotent, but making multiple payments has different effect than sending just one) - If patron has amountoustanding 0, payment is still possible. Should we return an error instead? Also the same should be considered when making a payment bigger than current amountoutstanding. - /accountlines/:borrowernumber/amountpayment is confusing because of :borrowernumber. How about /accountlines/amountpayment?borrowernumber=X - Do you think it would be useful to return total and currency? e.g. GET /accountlines?borrowernumber=1 { "total": 100.00, "currency": "USD", "rows": [ { // accountline-object with amountoutstanding 25, // accountline-object with amountoutstanding 60, // accountline-object with amountoutstanding 15 } ] } I will switch this back to "In Discussion". -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15165] REST API routes to list, edit and pay borrower's accountlines
by bugzilla-daemon＠bugs.koha-community.org 22 Jun '16

22 Jun '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15165 Lari Taskula <larit(a)student.uef.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #50190|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15165] REST API routes to list, edit and pay borrower's accountlines
by bugzilla-daemon＠bugs.koha-community.org 22 Jun '16

22 Jun '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15165 Lari Taskula <larit(a)student.uef.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #50790|0 |1 is obsolete| | --- Comment #14 from Lari Taskula <larit(a)student.uef.fi> --- Created attachment 52683 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52683&action=ed… Bug 15165 - Add API routes to pay accountlines PUT /accountlines/(:accountlines_id)/payment (pay towards accountline) PUT /accountlines/(:borrowernumber)/amountpayment (pay towards borrower) PUT /accountlines/(:accountlines_id)/partialpayment (pay accountline partially) Test plan: 1. Open a browser tab on Koha staff and log in (to create CGISESSID cookie). You should have permission updatecharges. 2. Create a fine to any patron and get the accountlines_id. 3. Send PUT request to http://yourlibrary/api/v1/accountlines/YYY/payment without body where YYY is the accountlines_id you created in step 2. 4. Check that the accountline that you created in step 2 is paid. 5. Create two payments with amount 5.00 (with no other outstanding payments) 6. Send PUT request to http://yourlibrary/api/v1/accountlines/ZZZ/amountpayment with body defined in definitions/partialpayAccountlineBody.json. Replace ZZZ with the borrowernumber that you created two fines to. Set amount to 10. 7. Check that the two accountlines are paid. 8. Repeat step 2. 9. Send PUT request to http://yourlibrary/api/v1/accountlines/YYY/partialpayment with body defined in definitions/partialpayAccountlineBody.json. Replace YYY with the accountlines_id you created in step 8. Set amount to half of the amount of fine you created in step 8. 10. Check that the fine is still outstanding with half of the original amount. 11. Run unit tests at t/db_dependent/api/v1/accountlines.t -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15165] REST API routes to list, edit and pay borrower's accountlines
by bugzilla-daemon＠bugs.koha-community.org 22 Jun '16

22 Jun '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15165 --- Comment #13 from Lari Taskula <larit(a)student.uef.fi> --- Created attachment 52682 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52682&action=ed… Bug 15165 - Add API route to edit accountlines PUT /accountlines/{accountlines_id} (edit) Test plan: 1. Open a browser tab on Koha staff and log in (to create CGISESSID cookie). You should have permission updatecharges. 2. Send PUT request to http://yourlibrary/api/v1/accountlines/YYY where YYY is one of your accountlines_id. See the body definition in definitions/editAccountlineBody.json and use this in your PUT request. 3. Run unit tests in t/db_dependent/api/v1/accountlines.t -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15165] REST API routes to list, edit and pay borrower's accountlines
by bugzilla-daemon＠bugs.koha-community.org 22 Jun '16

22 Jun '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15165 Lari Taskula <larit(a)student.uef.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #50189|0 |1 is obsolete| | --- Comment #12 from Lari Taskula <larit(a)student.uef.fi> --- Created attachment 52681 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52681&action=ed… Bug 15165 - Add API route to list accountlines GET /accountlines (list) GET /accountlines?borrowernumber=X (list) Test plan: 1. Open a browser tab on Koha staff and log in (to create CGISESSID cookie). You should have permission updatecharges. 2. Go to http://yourlibrary/api/v1/accountlines?borrowernumber=XXX (replace XXX with a borrowernumber that has accountlines) and check you receive correct data 3. Go to http://yourlibrary/api/v1/accountlines and check that you receive all accountlines 4. Run unit tests in t/db_dependent/api/v1/accountlines.t -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15165] REST API routes to list, edit and pay borrower's accountlines
by bugzilla-daemon＠bugs.koha-community.org 22 Jun '16

22 Jun '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15165 Lari Taskula <larit(a)student.uef.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |larit(a)student.uef.fi --- Comment #11 from Lari Taskula <larit(a)student.uef.fi> --- Patch apply failed because of Bug 13903 has been pushed to master and changed specification files. Rebasing on master. Also fixing the following things in patches: - "Bug 15165 - Add API route to edit accoulines" title typo: accoulines->accountlines - definitions/amountpayed.json => definitions/amountpaid.json (also payed => paid where ever it existed) - set amountpaid-object type from integer to number in order to make amountpayment with decimal value as well. - Test plans missing. Adding them. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14060] Remove readonly on date inputs
by bugzilla-daemon＠bugs.koha-community.org 22 Jun '16

22 Jun '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14060 --- Comment #24 from Marc Véron <veron(a)veron.ch> --- For the records: koha-tmpl/intranet-tmpl/prog/js/members.js (...) // this function checks id date is like DD/MM/YYYY function CheckDate(field) (...) Used in: koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt for fields dateenrolled and dateexpiry (only if dateformat == "metric" ) -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14060] Remove readonly on date inputs
by bugzilla-daemon＠bugs.koha-community.org 22 Jun '16

22 Jun '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14060 --- Comment #23 from Marc Véron <veron(a)veron.ch> --- For the records: jQuery Validation Plugin's date method is no option, it would consider 30/30/2008 as a valid date. "Use dateISO instead or one of the locale specific methods (in localizations/ and additional-methods.js)." See: https://jqueryvalidation.org/date-method -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11586] Better default framework for UNIMARC
by bugzilla-daemon＠bugs.koha-community.org 22 Jun '16

22 Jun '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11586 Fridolin SOMERS <fridolin.somers(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |16797 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16797 [Bug 16797] errors in UNIMARC complet sample authorities -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14060] Remove readonly on date inputs
by bugzilla-daemon＠bugs.koha-community.org 22 Jun '16

22 Jun '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14060 Marc Véron <veron(a)veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |16796 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16796 [Bug 16796] Patron categories: Crash if enrolment date is not valid -- You are receiving this mail because: You are watching all bug changes.

1 0