June 2016 - Koha-bugs - lists.koha-community.org

[Bug 14902] Add qualifier menu to staff side "Search the Catalog"
by bugzilla-daemon＠bugs.koha-community.org 22 Jun '16

22 Jun '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14902 Owen Leonard <oleonard(a)myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |16799 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16799 [Bug 16799] header_search is too wide when IntranetCatalogSearchPulldown is enabled. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12509] Untranslatable "Restriction added by overdues process"
by bugzilla-daemon＠bugs.koha-community.org 22 Jun '16

22 Jun '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12509 --- Comment #9 from alonso morgane <morgane.alonso(a)biblibre.com> --- Thank you so much! The author informations are correct. I didn't know why the author informations weren't the good ones because I configured my git and I changed it when I squashed my two patches. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 0

[Bug 12509] Untranslatable "Restriction added by overdues process"
by bugzilla-daemon＠bugs.koha-community.org 22 Jun '16

22 Jun '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12509 --- Comment #8 from Owen Leonard <oleonard(a)myacpl.org> --- Your patch still didn't have accurate author information, but I revised it (correctly, I hope) when I signed off. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 0

[Bug 12509] Untranslatable "Restriction added by overdues process"
by bugzilla-daemon＠bugs.koha-community.org 22 Jun '16

22 Jun '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12509 Owen Leonard <oleonard(a)myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #52634|0 |1 is obsolete| | --- Comment #7 from Owen Leonard <oleonard(a)myacpl.org> --- Created attachment 52685 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52685&action=ed… [SIGNED-OFF] Bug 12509 - Fix Untranslatable Restriction added by overdues process Changes the value of the "comment" column in "borrower_debarments" table from "Restriction added by overdues process yyyy-mm-dd hh:mm:ss" to "OVERDUE_PROCESS yyyy-mm-dd hh:mm:ss" in the overdue_notices.pl. Then in the templates "moremember.tt", "circulation.tt", "memberentrygen.tt", "opac-reserve.tt" and "opac-user.tt" the value of "comment" is check, if it's an automatical comment due to overdue process it'll write "Restriction added by overdues process yyyy-mm-dd hh:mm:ss", then if there is a customizable comment it will be written without modification. Like this, the comment "Restriction added by overdues process" is written in the po files and can be translated later. To test: 1) create a patron with automatical restriction due to overdue process; 2) apply patch; 3) run misc/cronjobs/overdue_notices.pl; 4) verify if the comment "Restriction added by overdues process" is well written and translatable on the following page : - opac patron home page (opac-user.tt); - opac item reservation page (opac-reserve.tt); - pro patron page (moremember.tt); - reservation item for a patron (circulation.tt, memberentrygen.tt); 5) try to translate the comment in po files; 6) sign off. Signed-off-by: Owen Leonard <oleonard(a)myacpl.org> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 0

[Bug 12509] Untranslatable "Restriction added by overdues process"
by bugzilla-daemon＠bugs.koha-community.org 22 Jun '16

22 Jun '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12509 Owen Leonard <oleonard(a)myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 0

[Bug 15165] REST API routes to list, edit and pay borrower's accountlines
by bugzilla-daemon＠bugs.koha-community.org 22 Jun '16

22 Jun '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15165 --- Comment #17 from Lari Taskula <larit(a)student.uef.fi> --- (In reply to Lari Taskula from comment #15) > Anyway, comments to this bug. I think some fixes are needed. One thing that I forgot to mention. I think it's a must to have just one endpoint for making a payment towards an accountline, otherwise it would be very confusing. I know this probably stems from C4::Accounts having multiple subroutines for making a payment, but Bug 15894 is working on unifying them as one. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15762] New: Fields editable in PatronSelfRegistrationBorrowerUnwantedField may be hidden by BorrowerUnwantedField
by bugzilla-daemon＠bugs.koha-community.org 22 Jun '16

22 Jun '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15762 Bug ID: 15762 Summary: Fields editable in PatronSelfRegistrationBorrowerUnwantedField may be hidden by BorrowerUnwantedField Change sponsored?: --- Product: Koha Version: 3.18 Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: OPAC Assignee: oleonard(a)myacpl.org Reporter: barton(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org It is possible for borrowers to create entries in their borrower record in the self registration process (as allowed by the system preference PatronSelfRegistrationBorrowerUnwantedField) that are hidden and un-editable via BorrowerUnwantedField. -- You are receiving this mail because: You are watching all bug changes.

1 7

[Bug 15165] REST API routes to list, edit and pay borrower's accountlines
by bugzilla-daemon＠bugs.koha-community.org 22 Jun '16

22 Jun '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15165 --- Comment #16 from Lari Taskula <larit(a)student.uef.fi> --- (In reply to Lari Taskula from comment #15) > "rows": [ > { > // accountline-object with amountoutstanding 25, > // accountline-object with amountoutstanding 60, > // accountline-object with amountoutstanding 15 > } > ] ...should be of course array of accountline-objects, sorry for the typo! "rows": [ // accountline-object with amountoutstanding 25, // accountline-object with amountoutstanding 60, // accountline-object with amountoutstanding 15 ] -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15165] REST API routes to list, edit and pay borrower's accountlines
by bugzilla-daemon＠bugs.koha-community.org 22 Jun '16

22 Jun '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15165 Lari Taskula <larit(a)student.uef.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |In Discussion --- Comment #15 from Lari Taskula <larit(a)student.uef.fi> --- (In reply to Andreas Hedström Mace from comment #10) > Created attachment 50790 [details] [review] > It is not possible to pay specified/partial amounts (for one or more > accountlines). Maybe I misunderstood the problem, but doesn't this do it: PUT /accountlines/123/partialpayment {"amount": 5.00, "description": "payment description"} Or pay payment with specific amount to borrower: PUT /accountlines/:borrowernumber/amountpayment { "amount": 5, "description": "payment description" } Anyway, comments to this bug. I think some fixes are needed. - Payments should be POST instead of PUT (PUT is idempotent, but making multiple payments has different effect than sending just one) - If patron has amountoustanding 0, payment is still possible. Should we return an error instead? Also the same should be considered when making a payment bigger than current amountoutstanding. - /accountlines/:borrowernumber/amountpayment is confusing because of :borrowernumber. How about /accountlines/amountpayment?borrowernumber=X - Do you think it would be useful to return total and currency? e.g. GET /accountlines?borrowernumber=1 { "total": 100.00, "currency": "USD", "rows": [ { // accountline-object with amountoutstanding 25, // accountline-object with amountoutstanding 60, // accountline-object with amountoutstanding 15 } ] } I will switch this back to "In Discussion". -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15165] REST API routes to list, edit and pay borrower's accountlines
by bugzilla-daemon＠bugs.koha-community.org 22 Jun '16

22 Jun '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15165 Lari Taskula <larit(a)student.uef.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #50190|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

1 0