June 2016 - Koha-bugs - lists.koha-community.org

[Bug 14048] Change RefundLostItemFeeOnReturn to be branch specific
by bugzilla-daemon＠bugs.koha-community.org 21 Jun '16

21 Jun '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048 Nick Clemens <nick(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #52658|0 |1 is obsolete| | --- Comment #49 from Nick Clemens <nick(a)bywatersolutions.com> --- Created attachment 52668 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52668&action=ed… Bug 14048: (followup) Use the original holding branch This patch picks the item's holding branch *before* it gets fixed by using the checkin library instead. This way the RefundLostOnReturnControl syspref set to ItemHoldingBranch is respected (otherwise, as Nick explained this behaves just like if CheckinLibrary was set) Signed-off-by: Tomas Cohen Arazi <tomascohen(a)theke.io> Signed-off-by: Nick Clemens <nick(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14048] Change RefundLostItemFeeOnReturn to be branch specific
by bugzilla-daemon＠bugs.koha-community.org 21 Jun '16

21 Jun '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048 Nick Clemens <nick(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #52482|0 |1 is obsolete| | --- Comment #48 from Nick Clemens <nick(a)bywatersolutions.com> --- Created attachment 52667 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52667&action=ed… Bug 14048: (QA followup) Fix typo on syspref value Signed-off-by: Nick Clemens <nick(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14048] Change RefundLostItemFeeOnReturn to be branch specific
by bugzilla-daemon＠bugs.koha-community.org 21 Jun '16

21 Jun '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048 Nick Clemens <nick(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #52451|0 |1 is obsolete| | --- Comment #47 from Nick Clemens <nick(a)bywatersolutions.com> --- Created attachment 52666 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52666&action=ed… Bug 14048: (QA followup) Update syspref name for HEA Signed-off-by: Nick Clemens <nick(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14048] Change RefundLostItemFeeOnReturn to be branch specific
by bugzilla-daemon＠bugs.koha-community.org 21 Jun '16

21 Jun '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048 Nick Clemens <nick(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #52450|0 |1 is obsolete| | --- Comment #46 from Nick Clemens <nick(a)bywatersolutions.com> --- Created attachment 52665 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52665&action=ed… Bug 14048 [QA Followup] - Delete only the removed system preference Signed-off-by: Nick Clemens <nick(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14048] Change RefundLostItemFeeOnReturn to be branch specific
by bugzilla-daemon＠bugs.koha-community.org 21 Jun '16

21 Jun '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048 Nick Clemens <nick(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #52449|0 |1 is obsolete| | --- Comment #45 from Nick Clemens <nick(a)bywatersolutions.com> --- Created attachment 52664 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52664&action=ed… Bug 14048: Add syspref and atomic update This patch introduces the changes to the sysprefs and the atomic update that creates the new table. It picks the syspref value for RefundLostItemFeeOnReturn and uses it to create a default (branchcode='*') rule on the new table. Sponsored-by: DoverNet Sponsored-by: South-East Kansas Library System Sponsored-by: SWITCH Library Consortium Signed-off-by: Nick Clemens <nick(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14048] Change RefundLostItemFeeOnReturn to be branch specific
by bugzilla-daemon＠bugs.koha-community.org 21 Jun '16

21 Jun '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048 Nick Clemens <nick(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #52448|0 |1 is obsolete| | --- Comment #44 from Nick Clemens <nick(a)bywatersolutions.com> --- Created attachment 52663 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52663&action=ed… Bug 14048: [QA Followup] Signed-off-by: Nick Clemens <nick(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14048] Change RefundLostItemFeeOnReturn to be branch specific
by bugzilla-daemon＠bugs.koha-community.org 21 Jun '16

21 Jun '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048 Nick Clemens <nick(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #52447|0 |1 is obsolete| | --- Comment #43 from Nick Clemens <nick(a)bywatersolutions.com> --- Created attachment 52662 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52662&action=ed… Bug 14048: Hook new rules into C4::Circulation This patch makes AddIssue and AddReturn use the new implementation The behaviour should respect the specification. Sponsored-by: DoverNet Sponsored-by: South-East Kansas Library System Sponsored-by: SWITCH Library Consortium Signed-off-by: Nick Clemens <nick(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14048] Change RefundLostItemFeeOnReturn to be branch specific
by bugzilla-daemon＠bugs.koha-community.org 21 Jun '16

21 Jun '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048 Nick Clemens <nick(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #52446|0 |1 is obsolete| | --- Comment #42 from Nick Clemens <nick(a)bywatersolutions.com> --- Created attachment 52661 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52661&action=ed… Bug 14048: Add a refund rules setting form in smart-rules This patch introduces the CRUD UI for managing the refund lost item fee rules on the general 'Circulation and fines rules' page. Verify that rules can be added and changed. Rules are correctly associated to the chosen branch (or the general default rule). To test: - Apply the patch - Open smart-rules.pl => SUCCESS: The text and refund rules section correctly refers to default global rules. The policy can be set to Yes and No, and works as expected. - Pick a specific branch => SUCCESS: The rule refers to the specific branch => SUCCESS: It detects the default rule is picked => SUCCESS: On changing the rules values are correctly retrieved if entering again to the page. => SUCCESS: The 'Use default' text is suffixed with the correct value set by the user in the 'All libraries' scenario. => Sign off :-D Sponsored-by: DoverNet Sponsored-by: South-East Kansas Library System Sponsored-by: SWITCH Library Consortium Signed-off-by: Nick Clemens <nick(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14048] Change RefundLostItemFeeOnReturn to be branch specific
by bugzilla-daemon＠bugs.koha-community.org 21 Jun '16

21 Jun '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048 Nick Clemens <nick(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #52445|0 |1 is obsolete| | --- Comment #41 from Nick Clemens <nick(a)bywatersolutions.com> --- Created attachment 52660 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52660&action=ed… Bug 14048: Unit tests This patch introduces unit tests for the feature. To test: - Have all patches from this bug applied - Run: $ prove -v t/db_dependent/RefundLostItemFeeRule.t => SUCCESS: All tests pass! Sponsored-by: DoverNet Sponsored-by: South-East Kansas Library System Sponsored-by: SWITCH Library Consortium Signed-off-by: Nick Clemens <nick(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14048] Change RefundLostItemFeeOnReturn to be branch specific
by bugzilla-daemon＠bugs.koha-community.org 21 Jun '16

21 Jun '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048 Nick Clemens <nick(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #52444|0 |1 is obsolete| | --- Comment #40 from Nick Clemens <nick(a)bywatersolutions.com> --- Created attachment 52659 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52659&action=ed… Bug 14048: Add RefundLostItemFeeRule table and classes This patch introduces new classes for handling refund lost item fee rules. It introduces a new table for storing this rules. It is designed so it is possible to define a global rule, and then branch-specific ones. The specific is prefered if available. This behaviour is fully tested by unit tests introduced by the following patches. This cannot be tested on its own. Sponsored-by: DoverNet Sponsored-by: South-East Kansas Library System Sponsored-by: SWITCH Library Consortium Signed-off-by: Nick Clemens <nick(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0