June 2016 - Koha-bugs - lists.koha-community.org

[Bug 12598] New misc/import_borrowers.pl command line tool
by bugzilla-daemon＠bugs.koha-community.org 19 Jun '16

19 Jun '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #121 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- 1/ + use namespace::clean; Why do you need it? 2/ + use Moo; You are going to start a neverending debate using Moo: it is not marked as mandatory and is not used from a CGI script. If you persist, you will have to start the discussion during the next dev meeting. 3/ On bug 15451, I have created a Koha::Exporter::Record file, which will export records. Here you created a Koha::Patrons::Import. We will need to uniformise the namespace. 4/ You should use pod2usage to display the help of the command line script 5/ Doc of the script is wrong: import_patrons.pl -c /path/to/patrons.csv -m cardnumber -f is missing 6/ Data::Dumper is not imported 7/ The pod does not explain that the script supports several levels of verbosity -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12598] New misc/import_borrowers.pl command line tool
by bugzilla-daemon＠bugs.koha-community.org 19 Jun '16

19 Jun '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598 --- Comment #120 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- FAIL t/db_dependent/Koha/Patrons/Import.t FAIL critic "$headerrow_0" is declared but not used at line 313, column 5. Unused variables clutter code and make it harder to read. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12598] New misc/import_borrowers.pl command line tool
by bugzilla-daemon＠bugs.koha-community.org 19 Jun '16

19 Jun '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598 --- Comment #119 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- 2 Tests are failing t/db_dependent/Koha/Patrons/Import.t .. 2/124 # Failed test 'Got the expected array size from set column keys with undef extended' # at t/db_dependent/Koha/Patrons/Import.t line 398. # got: '67' # expected: '66' # Failed test 'Got the expected array size from set column keys with extended' # at t/db_dependent/Koha/Patrons/Import.t line 405. # got: '68' # expected: '67' # Looks like you failed 2 tests of 2 I guess it's because a new column has been added to the borrowers table. Maybe it would be better to test that @columnkeys_1 = @columnkeys_0 + 1 don't you think? It would avoid these 2 tests to fail each time a new column is added/removed to this table. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12598] New misc/import_borrowers.pl command line tool
by bugzilla-daemon＠bugs.koha-community.org 19 Jun '16

19 Jun '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598 --- Comment #118 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 52540 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52540&action=ed… Bug 12598: catch warnings raised by import_patrons in tests -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 16773] New: Deleting an EDIFACT message should ask for confirmation
by bugzilla-daemon＠bugs.koha-community.org 19 Jun '16

19 Jun '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16773 Bug ID: 16773 Summary: Deleting an EDIFACT message should ask for confirmation Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs(a)lists.koha-community.org Reporter: katrin.fischer(a)bsz-bw.de QA Contact: testopia(a)bugs.koha-community.org When deleting an EDIFACT message, it should ask for confirmation. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 0

[Bug 14790] Link to OPAC view from within subscriptions, search and item editor
by bugzilla-daemon＠bugs.koha-community.org 19 Jun '16

19 Jun '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14790 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart(a)bugs.koha-c | |ommunity.org --- Comment #11 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- In catalogue/detail.pl, we already have a "OPAC view" link (only for non-XSLT views (?)). It tests if OPACBaseURL exists. It may be useful to add this test in your patches: a library could use another OPAC and do not want to have this link displayed. Since Owen is going to add another link ("Add to basket") to each entry, I think we will need a new pref to drive this display soon :) -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10760] Use Street Number and Street type in Alternate Address section
by bugzilla-daemon＠bugs.koha-community.org 19 Jun '16

19 Jun '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10760 --- Comment #6 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Thx for the explanation Marc - looks ok to me. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 9259] batch delete marc batches
by bugzilla-daemon＠bugs.koha-community.org 19 Jun '16

19 Jun '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9259 --- Comment #6 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- (In reply to Owen Leonard from comment #5) > What about the eraser icon instead? > > http://fontawesome.io/icon/eraser/ Looks good to me! -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 16761] New: I can not open a staff patron.
by bugzilla-daemon＠bugs.koha-community.org 19 Jun '16

19 Jun '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16761 Bug ID: 16761 Summary: I can not open a staff patron. Change sponsored?: --- Product: Koha Version: 16.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs(a)lists.koha-community.org Reporter: mahmudul.most(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com Created attachment 52475 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52475&action=ed… new patron I am new. I have installed a fresh koha. After that i have logged in with the database administrator. After logging there's showed an warning. On that warning this written that "Please login with a regular staff account" create a library, patron category staff and a new patron. Then give permission...... I have created a library branch. But i could not open a regular staff account when i go to create patron i get the info can not add patron. . there are no categories defined. please add a patron category. though there are a lot of patron category. After that when ever i go to patron category then new category but it does not comes. What is the solution? Please give me the solution. I am totally bored with this. Another thing that i can not open another user. When i go to the tolls>patron list>new patron list> provide my name>save it shows an error message. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 4

[Bug 9543] Show patrons messaging subscription on holds notification
by bugzilla-daemon＠bugs.koha-community.org 18 Jun '16

18 Jun '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9543 --- Comment #31 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- (In reply to Jonathan Druart from comment #30) > Why do you want to backport it? Ok, misread the PRO. I'd say don't backport enhancements, in general. -- You are receiving this mail because: You are watching all bug changes.

1 0