June 2016 - Koha-bugs - lists.koha-community.org

[Bug 12178] Serial claims: exporting late issues with the CSV profile doesn't set the issue claimed
by bugzilla-daemon＠bugs.koha-community.org 19 Jun '16

19 Jun '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12178 --- Comment #10 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- The second patch includes patches that depend on the setting of the dateformat system preference - it has to be set to dd/mm/yyyy to work. It would be better to fix this. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15485] Allow choosing different XSLTs for lists
by bugzilla-daemon＠bugs.koha-community.org 19 Jun '16

19 Jun '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15485 --- Comment #10 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Tomas, I'd prefer to insert the pref with the value of XSLT used for results and default in XSLTParse4Display. We could use "default" as others. What do you think about that? -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14874] Add ability to search for patrons by date of birth from checkout and patron quick searches
by bugzilla-daemon＠bugs.koha-community.org 19 Jun '16

19 Jun '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14874 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer(a)bsz-bw.de Status|Signed Off |In Discussion --- Comment #18 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Hm, this seems a bit like 'magic' behaviour - so it would be something that has to be explained in the manual, as it's not something you might try out on your own ever. So I am not totally persuaded about the usefulness, but also not set against it. But apart from that, I am mostly worried about how this will impact the performance of the patron search - will it make things slower? Apart from this: 1) if you do a search from the check out tab, you end up with a results table that doesn't show the date of birth - I think if it's searchable, it should also show. 2) Patron search page: a combined search for birthdate and part of the name doesn't always seem to work? (comment#14) With the sample data: 19.01.1931 Cherry - no result Cherry 19.01.1931 - result Can you please take a look? -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 16336] New: UX of holds patron search with long lists of results
by bugzilla-daemon＠bugs.koha-community.org 19 Jun '16

19 Jun '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16336 Bug ID: 16336 Summary: UX of holds patron search with long lists of results Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Hold requests Assignee: oleonard(a)myacpl.org Reporter: oleonard(a)myacpl.org QA Contact: testopia(a)bugs.koha-community.org CC: aleishaamohia(a)hotmail.com, brendan(a)bywatersolutions.com, gmcharlt(a)gmail.com, jonathan.druart(a)bugs.koha-community.org, julian.maurice(a)biblibre.com, kyle.m.hall(a)gmail.com, liz(a)catalyst.net.nz, magnus(a)libriotech.no, mirko(a)abunchofthings.net, nick(a)bywatersolutions.com, testopia(a)bugs.koha-community.org, veron(a)veron.ch Depends on: 15793 Bug 15793 made a change to an interface which is also found in request.tt. The same change should be made there. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15793 [Bug 15793] UX of circulation patron search with long lists of returned borrowers -- You are receiving this mail because: You are watching all bug changes.

1 18

[Bug 12598] New misc/import_borrowers.pl command line tool
by bugzilla-daemon＠bugs.koha-community.org 19 Jun '16

19 Jun '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #121 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- 1/ + use namespace::clean; Why do you need it? 2/ + use Moo; You are going to start a neverending debate using Moo: it is not marked as mandatory and is not used from a CGI script. If you persist, you will have to start the discussion during the next dev meeting. 3/ On bug 15451, I have created a Koha::Exporter::Record file, which will export records. Here you created a Koha::Patrons::Import. We will need to uniformise the namespace. 4/ You should use pod2usage to display the help of the command line script 5/ Doc of the script is wrong: import_patrons.pl -c /path/to/patrons.csv -m cardnumber -f is missing 6/ Data::Dumper is not imported 7/ The pod does not explain that the script supports several levels of verbosity -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12598] New misc/import_borrowers.pl command line tool
by bugzilla-daemon＠bugs.koha-community.org 19 Jun '16

19 Jun '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598 --- Comment #120 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- FAIL t/db_dependent/Koha/Patrons/Import.t FAIL critic "$headerrow_0" is declared but not used at line 313, column 5. Unused variables clutter code and make it harder to read. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12598] New misc/import_borrowers.pl command line tool
by bugzilla-daemon＠bugs.koha-community.org 19 Jun '16

19 Jun '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598 --- Comment #119 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- 2 Tests are failing t/db_dependent/Koha/Patrons/Import.t .. 2/124 # Failed test 'Got the expected array size from set column keys with undef extended' # at t/db_dependent/Koha/Patrons/Import.t line 398. # got: '67' # expected: '66' # Failed test 'Got the expected array size from set column keys with extended' # at t/db_dependent/Koha/Patrons/Import.t line 405. # got: '68' # expected: '67' # Looks like you failed 2 tests of 2 I guess it's because a new column has been added to the borrowers table. Maybe it would be better to test that @columnkeys_1 = @columnkeys_0 + 1 don't you think? It would avoid these 2 tests to fail each time a new column is added/removed to this table. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12598] New misc/import_borrowers.pl command line tool
by bugzilla-daemon＠bugs.koha-community.org 19 Jun '16

19 Jun '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598 --- Comment #118 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 52540 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52540&action=ed… Bug 12598: catch warnings raised by import_patrons in tests -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14790] Link to OPAC view from within subscriptions, search and item editor
by bugzilla-daemon＠bugs.koha-community.org 19 Jun '16

19 Jun '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14790 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart(a)bugs.koha-c | |ommunity.org --- Comment #11 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- In catalogue/detail.pl, we already have a "OPAC view" link (only for non-XSLT views (?)). It tests if OPACBaseURL exists. It may be useful to add this test in your patches: a library could use another OPAC and do not want to have this link displayed. Since Owen is going to add another link ("Add to basket") to each entry, I think we will need a new pref to drive this display soon :) -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10760] Use Street Number and Street type in Alternate Address section
by bugzilla-daemon＠bugs.koha-community.org 19 Jun '16

19 Jun '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10760 --- Comment #6 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Thx for the explanation Marc - looks ok to me. -- You are receiving this mail because: You are watching all bug changes.

1 0