June 2016 - Koha-bugs - lists.koha-community.org

[Bug 13074] C4::Items::_build_default_values_for_mod_marc should use Koha::Cache
by bugzilla-daemon＠bugs.koha-community.org 17 Jun '16

17 Jun '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13074 Kyle M Hall <kyle(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle(a)bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #16 from Kyle M Hall <kyle(a)bywatersolutions.com> --- Pushed for 16.11, thanks Jonathan, Tomas! -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12748] Serials - two issues with status of "Expected"
by bugzilla-daemon＠bugs.koha-community.org 17 Jun '16

17 Jun '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12748 Kyle M Hall <kyle(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle(a)bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #31 from Kyle M Hall <kyle(a)bywatersolutions.com> --- Pushed to master for Koha 16.11, thanks Remi, Jonathan! -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14048] Change RefundLostItemFeeOnReturn to be branch specific
by bugzilla-daemon＠bugs.koha-community.org 17 Jun '16

17 Jun '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048 --- Comment #37 from Tomás Cohen Arazi <tomascohen(a)gmail.com> --- (In reply to Nick Clemens from comment #35) > Tested well for syspref RefundLostOnReturnControl with values "homebranch" > and "check-in library" > > When using "item holding branch" I receive the error below: > Software error: ItemHoldingbranch requires the param Nick, it was due to a typo. It should be fixed by the latest followup. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14048] Change RefundLostItemFeeOnReturn to be branch specific
by bugzilla-daemon＠bugs.koha-community.org 17 Jun '16

17 Jun '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048 --- Comment #36 from Tomás Cohen Arazi <tomascohen(a)gmail.com> --- Created attachment 52482 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52482&action=ed… Bug 14048: (QA followup) Fix typo on syspref value -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15006] Need to distinguish client timeout from login timeout
by bugzilla-daemon＠bugs.koha-community.org 17 Jun '16

17 Jun '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15006 --- Comment #23 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- I would appreciate feedback on the questions raised earlier. The counterpatches can be applied on top of the first two. See the restricted handling in the third patch of only logins. And the policy/timeout use in the fourth patch. We should remove some changes to the xml again and add a simple test. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12446] Enable an adult to have a guarantor
by bugzilla-daemon＠bugs.koha-community.org 17 Jun '16

17 Jun '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446 Owen Leonard <oleonard(a)myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #33 from Owen Leonard <oleonard(a)myacpl.org> --- Sorry, this doesn't apply again. Any patch which touches memberentrygen.tt is really hard to keep up to date! -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15006] Need to distinguish client timeout from login timeout
by bugzilla-daemon＠bugs.koha-community.org 17 Jun '16

17 Jun '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15006 --- Comment #22 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 52480 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52480&action=ed… Bug 15006: [COUNTERPATCH] Timeout logic in sip_protocol_loop Instead of adding yet another client timeout, I propose to use the policy timeout that we also communicate in send_acs_status. Although I agree that we perhaps better move it from institution to account/login level, this c/should be done on another report. We may have issues with existing configurations. In order to find a compromise between bug 13432 and the originally proposed 15006 patch, this patch allows you to put a zero in the policy timeout entry in the SIPconfig. The timeout logic is moved to a Sip.pm subroutine. Will add a test :) Test plan: [1] Check timeout after login with policy/timeout > 0. [2] Check timeout after login with policy/timeout = 0. (No timeout!) [3] Check timeout after login with no policy timeout. Fallback to service. [4] Check timeout after login with no policy and service timeout. Should fallback to 30 seconds for both login process and after login. Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15006] Need to distinguish client timeout from login timeout
by bugzilla-daemon＠bugs.koha-community.org 17 Jun '16

17 Jun '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15006 --- Comment #21 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 52479 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52479&action=ed… Bug 15006: [COUNTERPATCH] Add timeout and strikes to raw_transport The code in raw_transport includes setting a $SIG{ALRM}, but did not use it. For consistency, we add an alarm statement here. Similarly, we add the "three strikes" to raw_transport just as telnet_transport does. Note that raw_transport will no longer respond to other requests than login. Test plan: [1] Start sip session with telnet on raw port 6001. Wait until it times out (probably the default 60 seconds). [2] Change SIPconfig.xml: set timeout=5 for service port 6001. Restart SIP and start another telnet 6001 session. Did it timeout within 5 seconds? [3] Start another 6001 session. Give three wrong requests or false login attempts. Does the connection close? Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15006] Need to distinguish client timeout from login timeout
by bugzilla-daemon＠bugs.koha-community.org 17 Jun '16

17 Jun '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15006 --- Comment #20 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Please do not change status yet. Not finished.. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15006] Need to distinguish client timeout from login timeout
by bugzilla-daemon＠bugs.koha-community.org 17 Jun '16

17 Jun '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15006 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45594|0 |1 is obsolete| | --- Comment #19 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 52478 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52478&action=ed… Bug 15006 Sip separate global from login timeouts Timeout logic has been added to the main sip loop However the timeout parameter was initially for the login process which requires a short duration applying such a brief timeout to the main sip loop causes instability in many selfcheck units Most selfchecks have persistent connections and send a periodic status request at intervals (approx every 5mins appears the norm) The timeout was dropping connections by default every 30secs which for the client appears as a very flakey network This patch adds a separate parameter client_timeout that can be used if you do want to force a disconnect if the client sends no requests for a period. By not defining it you can switch off the timeout in the main loop, I recommend this unless you have a good reason not too. If you do want this behaviour you can at least now set it to a more realistic value (see sample config file) Removed the commented out html entry in the config file, this was dead code born of a misconception and was just a source of confusion for users Signed-off-by: Frederic Demians <f.demians(a)tamil.fr> Signed-off-by: Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

1 0