June 2016 - Koha-bugs - lists.koha-community.org

[Bug 15006] Need to distinguish client timeout from login timeout
by bugzilla-daemon＠bugs.koha-community.org 17 Jun '16

17 Jun '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15006 --- Comment #20 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Please do not change status yet. Not finished.. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15006] Need to distinguish client timeout from login timeout
by bugzilla-daemon＠bugs.koha-community.org 17 Jun '16

17 Jun '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15006 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45594|0 |1 is obsolete| | --- Comment #19 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 52478 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52478&action=ed… Bug 15006 Sip separate global from login timeouts Timeout logic has been added to the main sip loop However the timeout parameter was initially for the login process which requires a short duration applying such a brief timeout to the main sip loop causes instability in many selfcheck units Most selfchecks have persistent connections and send a periodic status request at intervals (approx every 5mins appears the norm) The timeout was dropping connections by default every 30secs which for the client appears as a very flakey network This patch adds a separate parameter client_timeout that can be used if you do want to force a disconnect if the client sends no requests for a period. By not defining it you can switch off the timeout in the main loop, I recommend this unless you have a good reason not too. If you do want this behaviour you can at least now set it to a more realistic value (see sample config file) Removed the commented out html entry in the config file, this was dead code born of a misconception and was just a source of confusion for users Signed-off-by: Frederic Demians <f.demians(a)tamil.fr> Signed-off-by: Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15006] Need to distinguish client timeout from login timeout
by bugzilla-daemon＠bugs.koha-community.org 17 Jun '16

17 Jun '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15006 --- Comment #18 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 52477 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52477&action=ed… Bug 15006: [QA Follow-up] Indentation for two subroutines Remove tabs from telnet_transport and sip_protocol_loop. Correct indentation. Test plan: Compare files before and after without whitespace (diff -b). Notice only two split lines. Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15006] Need to distinguish client timeout from login timeout
by bugzilla-daemon＠bugs.koha-community.org 17 Jun '16

17 Jun '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15006 --- Comment #17 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Colin or Kyle: Well, I have some improvements coming hopefully :) Already wrote some patches. Few questions are: Is my impression correct that $config->{timeout} normally does not exist? We do not have/want[?] such entries in SIPconfig. Should we only allow login attempts in raw_transport? We do not now. Or should we allow e.g. SC_STATUS messages too? -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12599] IndependentBranches Holes
by bugzilla-daemon＠bugs.koha-community.org 17 Jun '16

17 Jun '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12599 --- Comment #7 from Owen Leonard <oleonard(a)myacpl.org> --- (In reply to M. Tompsett from comment #6) > (In reply to Kyle M Hall from comment #5) > > Indeed, ... . It's on my todo list ; ) > > TODO lists get lost. How do we get that on a "Doing It Now" list? :) Oh that's easy: You put up some time or money. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 0

[Bug 15006] Need to distinguish client timeout from login timeout
by bugzilla-daemon＠bugs.koha-community.org 17 Jun '16

17 Jun '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15006 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy(a)rijksmuseum.nl --- Comment #16 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- QA: Looking here now. Will probably ask some questions first :) -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15108] OAI-PMH provider improvements
by bugzilla-daemon＠bugs.koha-community.org 17 Jun '16

17 Jun '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15108 Josef Moravec <josef.moravec(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec(a)gmail.com -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14803] Rental and fine fees are not updating on circulation screen
by bugzilla-daemon＠bugs.koha-community.org 17 Jun '16

17 Jun '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14803 --- Comment #9 from Srdjan Jankovic <srdjan(a)catalyst.net.nz> --- This is a bit bigger than expected. Requires testing issue blocking with fines over limit. Also "Patron details" top " Checkouts are BLOCKED" message needs checking because it uses same component. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14803] Rental and fine fees are not updating on circulation screen
by bugzilla-daemon＠bugs.koha-community.org 17 Jun '16

17 Jun '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14803 --- Comment #8 from Srdjan Jankovic <srdjan(a)catalyst.net.nz> --- Created attachment 52474 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52474&action=ed… bug 14803: KOHA.Checkouts js object * Use javascript to: - update fines/checkouts info - show/hide checkouts form and messages * Created svc/patron/fines -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14803] Rental and fine fees are not updating on circulation screen
by bugzilla-daemon＠bugs.koha-community.org 17 Jun '16

17 Jun '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14803 Srdjan Jankovic <srdjan(a)catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #52210|0 |1 is obsolete| | --- Comment #7 from Srdjan Jankovic <srdjan(a)catalyst.net.nz> --- Created attachment 52473 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52473&action=ed… Bug 14803: Reload checkouts table on renewal svc/checkouts: get real rental charges for patron, rather than itemtype indication -- You are receiving this mail because: You are watching all bug changes.

1 0