June 2016 - Koha-bugs - lists.koha-community.org

[Bug 14757] Allow the use of Template Toolkit syntax for slips and notices
by bugzilla-daemon＠bugs.koha-community.org 28 Jun '16

28 Jun '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14757 --- Comment #54 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Kyle, I have marked this patchset as Passed QA but we still need a patch to take into account the 3 following tables: aqorders, aqbooksellers, biblioitems. I think this could be done on another bug report. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14757] Allow the use of Template Toolkit syntax for slips and notices
by bugzilla-daemon＠bugs.koha-community.org 28 Jun '16

28 Jun '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14757 --- Comment #53 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 52928 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52928&action=ed… Bug 14757: Remove obsolete occurrence of is_tt Signed-off-by: Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14757] Allow the use of Template Toolkit syntax for slips and notices
by bugzilla-daemon＠bugs.koha-community.org 28 Jun '16

28 Jun '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14757 --- Comment #52 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 52927 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52927&action=ed… Bug 14757 [QA Followup] - Don't overload new for Modifications Signed-off-by: Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14757] Allow the use of Template Toolkit syntax for slips and notices
by bugzilla-daemon＠bugs.koha-community.org 28 Jun '16

28 Jun '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14757 --- Comment #51 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 52926 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52926&action=ed… Bug 14757: Add tests for new modules Signed-off-by: Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14757] Allow the use of Template Toolkit syntax for slips and notices
by bugzilla-daemon＠bugs.koha-community.org 28 Jun '16

28 Jun '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14757 --- Comment #50 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 52925 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52925&action=ed… Bug 14757 [QA Followup] - Add Unit Tests Signed-off-by: Sean McGarvey <seanm(a)pascolibraries.org> Signed-off-by: Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14757] Allow the use of Template Toolkit syntax for slips and notices
by bugzilla-daemon＠bugs.koha-community.org 28 Jun '16

28 Jun '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14757 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #52805|0 |1 is obsolete| | Attachment #52806|0 |1 is obsolete| | Attachment #52807|0 |1 is obsolete| | Attachment #52895|0 |1 is obsolete| | --- Comment #49 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 52924 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52924&action=ed… Bug 14757 - Allow the use of Template Toolkit syntax for slips and notices This bug is the beginning of a conversion from our current bespoke syntax for slips and notices to Template Toolkit syntax. This patch is the initial seed which will evolve over time. With this addition, we can take advantage of our Koha Objects to greatly simplify the processing of Slips and Notices over time. Test Plan: 1) Apply this patch 2) Ensure you have the default CHECKOUT notice 3) Check out and return an item for a patron 4) Note the text of the CHECKOUT notice 5) Replace your CHECKOUT notice with the following: The following items have been checked out: ---- [% biblio.title %] ---- Thank you for visiting [% branch.branchname %]. 6) Repeat step 3 7) Note the CHECKOUT notice text matches the previous CHECKOUT notice text Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel(a)gmail.com> New notice syntax works, no koha-qa errors Signed-off-by: Sean McGarvey <seanm(a)pascolibraries.org> Bug 14757 [QA Followup] - Change method type() to _type() for Koha objects Signed-off-by: Sean McGarvey <seanm(a)pascolibraries.org> Bug 14757 [QA Followup] - Change all references to Koha::Borrower to Koha::Patron Signed-off-by: Sean McGarvey <seanm(a)pascolibraries.org> Signed-off-by: Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14757] Allow the use of Template Toolkit syntax for slips and notices
by bugzilla-daemon＠bugs.koha-community.org 28 Jun '16

28 Jun '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14757 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14642] Add logging of hold modifications
by bugzilla-daemon＠bugs.koha-community.org 28 Jun '16

28 Jun '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14642 --- Comment #10 from Tomás Cohen Arazi <tomascohen(a)gmail.com> --- (In reply to Colin Campbell from comment #9) > One thing that would be useful is to log if its an opac hold or staff > generated hold. In the UK public libraries standard reporting includes a > requirement to report number of holds placed via opac Ack -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15006] Need to distinguish client timeout from login timeout
by bugzilla-daemon＠bugs.koha-community.org 28 Jun '16

28 Jun '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15006 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com --- Comment #36 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- (In reply to Kyle M Hall from comment #34) > I like this proposal, but I think we should get Colin's testing and input > before setting it to Passed QA. I'll try setting up some tests -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14642] Add logging of hold modifications
by bugzilla-daemon＠bugs.koha-community.org 28 Jun '16

28 Jun '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14642 Colin Campbell <colin.campbell(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |colin.campbell@ptfs-europe. | |com --- Comment #9 from Colin Campbell <colin.campbell(a)ptfs-europe.com> --- One thing that would be useful is to log if its an opac hold or staff generated hold. In the UK public libraries standard reporting includes a requirement to report number of holds placed via opac -- You are receiving this mail because: You are watching all bug changes.

1 0