June 2016 - Koha-bugs - lists.koha-community.org

[Bug 14790] Link to OPAC view from within subscriptions, search and item editor
by bugzilla-daemon＠bugs.koha-community.org 27 Jun '16

27 Jun '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14790 Kyle M Hall <kyle(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #52737|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14066] Koha code does not really use Readonly
by bugzilla-daemon＠bugs.koha-community.org 27 Jun '16

27 Jun '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14066 Mirko Tietgen <mirko(a)abunchofthings.net> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=16588 -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14435] The table saved_reports is never populated
by bugzilla-daemon＠bugs.koha-community.org 27 Jun '16

27 Jun '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14435 --- Comment #27 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- (In reply to Jonathan Druart from comment #26) > (In reply to Marcel de Rooy from comment #25) > > Commit message still says: > > > > This patch is a proof of concept and is not very polished (understood: > > it cannot be pushed like that). > > I do not plan to work more on this one, unless several people are interested. > But I think it's a good start for someone who wants to continue... If this cannot be pushed in this form, could you adjust the status accordingly? -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14296] Introduce upload settings, add quota and translate alerts
by bugzilla-daemon＠bugs.koha-community.org 27 Jun '16

27 Jun '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14296 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |ASSIGNED --- Comment #10 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- (In reply to Katrin Fischer from comment #9) > Should this be unblocked? This will need some adjustments. Back to Assigned -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14296] Introduce upload settings, add quota and translate alerts
by bugzilla-daemon＠bugs.koha-community.org 27 Jun '16

27 Jun '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14296 --- Comment #9 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Should this be unblocked? -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14628] Anonymization of circulation data prevents lost item refunds
by bugzilla-daemon＠bugs.koha-community.org 26 Jun '16

26 Jun '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14628 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|critical |normal -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 0

[Bug 12598] New misc/import_borrowers.pl command line tool
by bugzilla-daemon＠bugs.koha-community.org 26 Jun '16

26 Jun '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598 --- Comment #124 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- (In reply to Jonathan Druart from comment #123) > What you are doing is just initializing them, so you can do that in the > constructor (new). Florent, let me know if you need more info about how to do it. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12598] New misc/import_borrowers.pl command line tool
by bugzilla-daemon＠bugs.koha-community.org 26 Jun '16

26 Jun '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598 --- Comment #123 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- (In reply to Florent Mara from comment #122) > I agree with most of it - also I can't reproduce the failed tests - but I > can fail other tests so some of these need to be reconsidered. > $headerrow_0 shouldn't be there. Namespace uniformity sounds like an > excellent idea, any suggestion/guidance? Actually it was added by bug 14722 which is already pushed. I have added the topic to the next dev meeting, just in case (https://wiki.koha-community.org/wiki/Development_IRC_meeting_13_July_2016) I have already talked about this to someone, but I don't find anything. > The part that confuses me is around Moo usage and I assume the comment > refers to Koha::Patrons::Import. The module has 2 attributes ('today_iso' > and 'text_csv'), can these exist without importing Moo? Yes of course. What you are doing is just initializing them, so you can do that in the constructor (new). -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14048] Change RefundLostItemFeeOnReturn to be branch specific
by bugzilla-daemon＠bugs.koha-community.org 26 Jun '16

26 Jun '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048 --- Comment #76 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- (In reply to Tomás Cohen Arazi from comment #73) > (In reply to Jonathan Druart from comment #72) > > I have squashed the patches for the review, so I won't use the splinter: > > > > 1/ my $item_holding_branch = $item->{ holdingbranch }; > > => would be good to have a comment here to explain the last patch. > > I thought the commit message would be enough. Do u require a comment on the > code? Would be good, but not required. Forget it > > 2/ Koha::Config::SysPrefs->find should not be used, C4::Context->preference > > should continue to be used everywhere, to take advantage of the syspref > > cache. > > Ok, followup coming. I added one also to fix the tests. > > 3/ $schema->resultset('RefundLostItemFeeRule')->search()->delete; > > should use Koha::RefundLostItemFeeRules > > This is done on the tests, instead of the usual DELETE FROM ... The problem > with Koha::RefundLostItemFeeRules is that it explicitly forbis deleting the > default rule. I'd leave it as it is. Correct, and I was wondering if it would not be easier to assume that default is 1 if no rule exist. It will permit to remove the sql file in the mysql/mandatory dir (and then no need to manage it from the installer) and no need to overwrite delete. Why do you think? > > 4/ Tests only cover RefundLostOnReturnControl = 'CheckinLibrary' > > This is incorrect: > > subtest 'Koha::RefundLostItemFeeRules::_choose_branch() tests' > => Tries the three possible values > > subtest 'Koha::RefundLostItemFeeRules::should_refund() tests' > => Tries the three possible values -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14048] Change RefundLostItemFeeOnReturn to be branch specific
by bugzilla-daemon＠bugs.koha-community.org 26 Jun '16

26 Jun '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048 --- Comment #75 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 52883 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52883&action=ed… Bug 14048: Use mock_preference in tests -- You are receiving this mail because: You are watching all bug changes.

1 0