June 2016 - Koha-bugs - lists.koha-community.org

[Bug 14048] Change RefundLostItemFeeOnReturn to be branch specific
by bugzilla-daemon＠bugs.koha-community.org 26 Jun '16

26 Jun '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048 --- Comment #76 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- (In reply to Tomás Cohen Arazi from comment #73) > (In reply to Jonathan Druart from comment #72) > > I have squashed the patches for the review, so I won't use the splinter: > > > > 1/ my $item_holding_branch = $item->{ holdingbranch }; > > => would be good to have a comment here to explain the last patch. > > I thought the commit message would be enough. Do u require a comment on the > code? Would be good, but not required. Forget it > > 2/ Koha::Config::SysPrefs->find should not be used, C4::Context->preference > > should continue to be used everywhere, to take advantage of the syspref > > cache. > > Ok, followup coming. I added one also to fix the tests. > > 3/ $schema->resultset('RefundLostItemFeeRule')->search()->delete; > > should use Koha::RefundLostItemFeeRules > > This is done on the tests, instead of the usual DELETE FROM ... The problem > with Koha::RefundLostItemFeeRules is that it explicitly forbis deleting the > default rule. I'd leave it as it is. Correct, and I was wondering if it would not be easier to assume that default is 1 if no rule exist. It will permit to remove the sql file in the mysql/mandatory dir (and then no need to manage it from the installer) and no need to overwrite delete. Why do you think? > > 4/ Tests only cover RefundLostOnReturnControl = 'CheckinLibrary' > > This is incorrect: > > subtest 'Koha::RefundLostItemFeeRules::_choose_branch() tests' > => Tries the three possible values > > subtest 'Koha::RefundLostItemFeeRules::should_refund() tests' > => Tries the three possible values -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14048] Change RefundLostItemFeeOnReturn to be branch specific
by bugzilla-daemon＠bugs.koha-community.org 26 Jun '16

26 Jun '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048 --- Comment #75 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 52883 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52883&action=ed… Bug 14048: Use mock_preference in tests -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14048] Change RefundLostItemFeeOnReturn to be branch specific
by bugzilla-daemon＠bugs.koha-community.org 25 Jun '16

25 Jun '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048 --- Comment #74 from Tomás Cohen Arazi <tomascohen(a)gmail.com> --- Created attachment 52876 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52876&action=ed… Bug 14048: (QA folloup) C4::Context->preference should be used Signed-off-by: Tomas Cohen Arazi <tomascohen(a)theke.io> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14048] Change RefundLostItemFeeOnReturn to be branch specific
by bugzilla-daemon＠bugs.koha-community.org 25 Jun '16

25 Jun '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048 --- Comment #73 from Tomás Cohen Arazi <tomascohen(a)gmail.com> --- (In reply to Jonathan Druart from comment #72) > I have squashed the patches for the review, so I won't use the splinter: > > 1/ my $item_holding_branch = $item->{ holdingbranch }; > => would be good to have a comment here to explain the last patch. I thought the commit message would be enough. Do u require a comment on the code? > 2/ Koha::Config::SysPrefs->find should not be used, C4::Context->preference > should continue to be used everywhere, to take advantage of the syspref > cache. Ok, followup coming. > 3/ $schema->resultset('RefundLostItemFeeRule')->search()->delete; > should use Koha::RefundLostItemFeeRules This is done on the tests, instead of the usual DELETE FROM ... The problem with Koha::RefundLostItemFeeRules is that it explicitly forbis deleting the default rule. I'd leave it as it is. > 4/ Tests only cover RefundLostOnReturnControl = 'CheckinLibrary' This is incorrect: subtest 'Koha::RefundLostItemFeeRules::_choose_branch() tests' => Tries the three possible values subtest 'Koha::RefundLostItemFeeRules::should_refund() tests' => Tries the three possible values -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11089] Item edit screen should use floating toolbar like cataloging interface
by bugzilla-daemon＠bugs.koha-community.org 25 Jun '16

25 Jun '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11089 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |In Discussion --- Comment #7 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Since bug 16400 is pushed, do we ask for another patch using a floating toolbar? -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15128] Add ability to limit the number of open purchase suggestions a patron can make
by bugzilla-daemon＠bugs.koha-community.org 25 Jun '16

25 Jun '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15128 --- Comment #29 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Code review: 1/ MaxOpenSuggestions = 0 will not work as expected 2/ If a patron tries to force the add, he will get "There are no pending purchase suggestions." even if there are. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15128] Add ability to limit the number of open purchase suggestions a patron can make
by bugzilla-daemon＠bugs.koha-community.org 25 Jun '16

25 Jun '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15128 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |jonathan.druart(a)bugs.koha-c | |ommunity.org --- Comment #28 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- This cannot be signed off, the patchset does not work at all, there is no limitation! -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14048] Change RefundLostItemFeeOnReturn to be branch specific
by bugzilla-daemon＠bugs.koha-community.org 25 Jun '16

25 Jun '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #72 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- I have squashed the patches for the review, so I won't use the splinter: 1/ my $item_holding_branch = $item->{ holdingbranch }; => would be good to have a comment here to explain the last patch. 2/ Koha::Config::SysPrefs->find should not be used, C4::Context->preference should continue to be used everywhere, to take advantage of the syspref cache. 3/ $schema->resultset('RefundLostItemFeeRule')->search()->delete; should use Koha::RefundLostItemFeeRules 4/ Tests only cover RefundLostOnReturnControl = 'CheckinLibrary' -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14902] Add qualifier menu to staff side "Search the Catalog"
by bugzilla-daemon＠bugs.koha-community.org 25 Jun '16

25 Jun '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14902 --- Comment #12 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- (In reply to Nick Clemens from comment #10) > Created attachment 52866 [details] [review] > Bug 14902 (QA Followup) > > Remove unnecessary [% USE Koha %] > > Any remaining were tested and needed Indeed, that's weird. So I prefer to keep the original patch, which has been widely tested. Sorry for the extra work. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14902] Add qualifier menu to staff side "Search the Catalog"
by bugzilla-daemon＠bugs.koha-community.org 25 Jun '16

25 Jun '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14902 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #52763|0 |1 is obsolete| | Attachment #52866|0 |1 is obsolete| | --- Comment #11 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 52874 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52874&action=ed… Bug 14902 - Add qualifier menu to staff side "Search the Catalog" To test: 1 - Apply patch and update dabase 2 - Check that Search the Catalog links throughout the staff interface have not changed 3 - Set "IntranetCatalogSearchPulldown" to 'Show' 4 - Verify that 'Search the catalog' links through staff client now have a dropdwon to select search index I think viewing one file each that includes updated header should be sufficient, but please check as many as you can: cgi-bin/koha/admin/aqbudgetperiods.pl cgi-bin/koha/admin/admin-home.pl cgi-bin/koha/cataloguing/addbooks.pl cgi-bin/koha/circ/returns.pl cgi-bin/koha/circ/circulation-home.pl cgi-bin/koha/admin/cities.pl cgi-bin/koha/admin/aqcontract.pl cgi-bin/koha/admin/currency.pl cgi-bin/koha/mainpage.pl cgi-bin/koha/tools/letter.pl cgi-bin/koha/members/members-home.pl cgi-bin/koha/admin/categories.pl cgi-bin/koha/admin/preferences.pl cgi-bin/koha/admin/printers.pl cgi-bin/koha/serials/serials-home.pl cgi-bin/koha/acqui/newordersuggestion.pl cgi-bin/koha/admin/z3950servers.pl Sponsored by: Northeast Kansas Library System (http://nekls.org/) Signed-off-by: Heather Braum <hbraum(a)nekls.org> Signed-off-by: Barton Chittenden <barton(a)bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

1 0