June 2016 - Koha-bugs - lists.koha-community.org

[Bug 14757] Allow the use of Template Toolkit syntax for slips and notices
by bugzilla-daemon＠bugs.koha-community.org 27 Jun '16

27 Jun '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14757 Kyle M Hall <kyle(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #47 from Kyle M Hall <kyle(a)bywatersolutions.com> --- (In reply to Jonathan Druart from comment #46) > Kyle, > I have squashed some patches (they failed qa tools: FAIL > Koha/Borrower/Modification.pm FAIL git manipulation: The file has been added > and deleted in the same patchset) and added tests for the new modules. > However, I do not understand why you overload the method > Koha::Patron::Modifications->new, this should not be needed > > Moreover, the methods of Koha::Patron::Modifications should now use > snake_case (as they use Koha::Object), but it's outside the scope of this > bug. I also don't know why I did that ; ) I will post a followup to remove the new() method, as it is not needed. We should file a bug to fix the method names fo Koha::Patron::Modifications. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate
by bugzilla-daemon＠bugs.koha-community.org 27 Jun '16

27 Jun '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #134 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- 1/ There are still occurrences of 'aqbasketgroup.closed' in tests. 2/ Use is/isnt instead of ok 3/ Use Koha::DateUtils instead of sprintf in tests -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14048] Change RefundLostItemFeeOnReturn to be branch specific
by bugzilla-daemon＠bugs.koha-community.org 27 Jun '16

27 Jun '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048 Tomás Cohen Arazi <tomascohen(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14048] Change RefundLostItemFeeOnReturn to be branch specific
by bugzilla-daemon＠bugs.koha-community.org 27 Jun '16

27 Jun '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048 --- Comment #79 from Tomás Cohen Arazi <tomascohen(a)gmail.com> --- (In reply to Kyle M Hall from comment #77) > I have a small request, could we move Koha::RefundLostItemFeeRule to a more > refined namespace? I think it would be better long term. I'm thinking > Koha::Circulation::Rules::LostItemFeeRule but am open to other suggestions. > I'd also be happy to write the followup for that myself if you find that > acceptable. Kyle, I don't have a strong opinion on this. I think you can write that followup if this passes QA. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14048] Change RefundLostItemFeeOnReturn to be branch specific
by bugzilla-daemon＠bugs.koha-community.org 27 Jun '16

27 Jun '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048 --- Comment #78 from Tomás Cohen Arazi <tomascohen(a)gmail.com> --- Created attachment 52894 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52894&action=ed… Bug 14048: (QA followup) Default to 1 if no default rule This patch answers Jonathan's request to simplify this patchset a bit. It removes the need for the .sql file, as _default_rule now defaults to a fixed value (1, which was set by the removed .sql file). This allowed to remove the overloaded ->delete method. The tests have been adjusted to reflect this changes, including tests for the new 'default'-if-absent situation. Signed-off-by: Tomas Cohen Arazi <tomascohen(a)theke.io> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13300] EBAF patches
by bugzilla-daemon＠bugs.koha-community.org 27 Jun '16

27 Jun '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13300 Paul Poulain <paul.poulain(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|NEW |RESOLVED -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14048] Change RefundLostItemFeeOnReturn to be branch specific
by bugzilla-daemon＠bugs.koha-community.org 27 Jun '16

27 Jun '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048 --- Comment #77 from Kyle M Hall <kyle(a)bywatersolutions.com> --- I have a small request, could we move Koha::RefundLostItemFeeRule to a more refined namespace? I think it would be better long term. I'm thinking Koha::Circulation::Rules::LostItemFeeRule but am open to other suggestions. I'd also be happy to write the followup for that myself if you find that acceptable. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14908] Item search: Item search results not properly sorted by Date. Date filter also not working
by bugzilla-daemon＠bugs.koha-community.org 27 Jun '16

27 Jun '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14908 --- Comment #8 from Theodoros Theodoropoulos <theod(a)lib.auth.gr> --- @Owen: For me, all the other filters seem to work properly. (Tested with 16.05.x and 3.20.x) -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14790] Link to OPAC view from within subscriptions, search and item editor
by bugzilla-daemon＠bugs.koha-community.org 27 Jun '16

27 Jun '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14790 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |16813 --- Comment #20 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- (In reply to Kyle M Hall from comment #15) > (In reply to Jonathan Druart from comment #14) > > Actually it does not work, if you try and empty OPACBaseURL, it will contain > > "http://", so [% IF OPACBaseURL %] in tt is always true. > > Feel free to postpone this bugfix as it's already buggy in master. > > Done, thanks for letting me know! Actually I have filled bug 16813 and provided a patch. It seems better to fix it and keep your last patch. Hope that makes sense for you. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16813 [Bug 16813] OPACBaseURL cannot be emptied -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14790] Link to OPAC view from within subscriptions, search and item editor
by bugzilla-daemon＠bugs.koha-community.org 27 Jun '16

27 Jun '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14790 --- Comment #19 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 52893 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52893&action=ed… Bug 14790 [QA Followup] - Don't show links unless OPACBaseURL is set Signed-off-by: Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

1 0