June 2016 - Koha-bugs - lists.koha-community.org

[Bug 14048] Change RefundLostItemFeeOnReturn to be branch specific
by bugzilla-daemon＠bugs.koha-community.org 24 Jun '16

24 Jun '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048 Tomás Cohen Arazi <tomascohen(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #52754|0 |1 is obsolete| | --- Comment #67 from Tomás Cohen Arazi <tomascohen(a)gmail.com> --- Created attachment 52841 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52841&action=ed… Bug 14048 [QA Followup] - Delete only the removed system preference Signed-off-by: Nick Clemens <nick(a)bywatersolutions.com> Signed-off-by: Jason Robb <jrobb(a)sekls.org> Signed-off-by: Jennifer Schmidt <jschmidt(a)switchinc.org> Signed-off-by: Margaret Thrasher <p.thrasher(a)dover.nh.gov> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14048] Change RefundLostItemFeeOnReturn to be branch specific
by bugzilla-daemon＠bugs.koha-community.org 24 Jun '16

24 Jun '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048 Tomás Cohen Arazi <tomascohen(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #52753|0 |1 is obsolete| | --- Comment #66 from Tomás Cohen Arazi <tomascohen(a)gmail.com> --- Created attachment 52840 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52840&action=ed… Bug 14048: Add syspref and atomic update This patch introduces the changes to the sysprefs and the atomic update that creates the new table. It picks the syspref value for RefundLostItemFeeOnReturn and uses it to create a default (branchcode='*') rule on the new table. Sponsored-by: DoverNet Sponsored-by: South-East Kansas Library System Sponsored-by: SWITCH Library Consortium Signed-off-by: Nick Clemens <nick(a)bywatersolutions.com> Signed-off-by: Jason Robb <jrobb(a)sekls.org> Signed-off-by: Jennifer Schmidt <jschmidt(a)switchinc.org> Signed-off-by: Margaret Thrasher <p.thrasher(a)dover.nh.gov> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14048] Change RefundLostItemFeeOnReturn to be branch specific
by bugzilla-daemon＠bugs.koha-community.org 24 Jun '16

24 Jun '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048 Tomás Cohen Arazi <tomascohen(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #52752|0 |1 is obsolete| | --- Comment #65 from Tomás Cohen Arazi <tomascohen(a)gmail.com> --- Created attachment 52839 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52839&action=ed… Bug 14048: [QA Followup] Signed-off-by: Nick Clemens <nick(a)bywatersolutions.com> Signed-off-by: Jason Robb <jrobb(a)sekls.org> Signed-off-by: Jennifer Schmidt <jschmidt(a)switchinc.org> Signed-off-by: Margaret Thrasher <p.thrasher(a)dover.nh.gov> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14048] Change RefundLostItemFeeOnReturn to be branch specific
by bugzilla-daemon＠bugs.koha-community.org 24 Jun '16

24 Jun '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048 Tomás Cohen Arazi <tomascohen(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #52751|0 |1 is obsolete| | --- Comment #64 from Tomás Cohen Arazi <tomascohen(a)gmail.com> --- Created attachment 52838 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52838&action=ed… Bug 14048: Hook new rules into C4::Circulation This patch makes AddIssue and AddReturn use the new implementation The behaviour should respect the specification. Sponsored-by: DoverNet Sponsored-by: South-East Kansas Library System Sponsored-by: SWITCH Library Consortium Signed-off-by: Nick Clemens <nick(a)bywatersolutions.com> Signed-off-by: Jason Robb <jrobb(a)sekls.org> Signed-off-by: Jennifer Schmidt <jschmidt(a)switchinc.org> Signed-off-by: Margaret Thrasher <p.thrasher(a)dover.nh.gov> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14048] Change RefundLostItemFeeOnReturn to be branch specific
by bugzilla-daemon＠bugs.koha-community.org 24 Jun '16

24 Jun '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048 Tomás Cohen Arazi <tomascohen(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #52750|0 |1 is obsolete| | --- Comment #63 from Tomás Cohen Arazi <tomascohen(a)gmail.com> --- Created attachment 52837 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52837&action=ed… Bug 14048: Add a refund rules setting form in smart-rules This patch introduces the CRUD UI for managing the refund lost item fee rules on the general 'Circulation and fines rules' page. Verify that rules can be added and changed. Rules are correctly associated to the chosen branch (or the general default rule). To test: - Apply the patch - Open smart-rules.pl => SUCCESS: The text and refund rules section correctly refers to default global rules. The policy can be set to Yes and No, and works as expected. - Pick a specific branch => SUCCESS: The rule refers to the specific branch => SUCCESS: It detects the default rule is picked => SUCCESS: On changing the rules values are correctly retrieved if entering again to the page. => SUCCESS: The 'Use default' text is suffixed with the correct value set by the user in the 'All libraries' scenario. => Sign off :-D Sponsored-by: DoverNet Sponsored-by: South-East Kansas Library System Sponsored-by: SWITCH Library Consortium Signed-off-by: Nick Clemens <nick(a)bywatersolutions.com> Signed-off-by: Jason Robb <jrobb(a)sekls.org> Signed-off-by: Jennifer Schmidt <jschmidt(a)switchinc.org> Signed-off-by: Margaret Thrasher <p.thrasher(a)dover.nh.gov> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14048] Change RefundLostItemFeeOnReturn to be branch specific
by bugzilla-daemon＠bugs.koha-community.org 24 Jun '16

24 Jun '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048 Tomás Cohen Arazi <tomascohen(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #52749|0 |1 is obsolete| | --- Comment #62 from Tomás Cohen Arazi <tomascohen(a)gmail.com> --- Created attachment 52836 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52836&action=ed… Bug 14048: Unit tests This patch introduces unit tests for the feature. To test: - Have all patches from this bug applied - Run: $ prove -v t/db_dependent/RefundLostItemFeeRule.t => SUCCESS: All tests pass! Sponsored-by: DoverNet Sponsored-by: South-East Kansas Library System Sponsored-by: SWITCH Library Consortium Signed-off-by: Nick Clemens <nick(a)bywatersolutions.com> Signed-off-by: Jason Robb <jrobb(a)sekls.org> Signed-off-by: Jennifer Schmidt <jschmidt(a)switchinc.org> Signed-off-by: Margaret Thrasher <p.thrasher(a)dover.nh.gov> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14048] Change RefundLostItemFeeOnReturn to be branch specific
by bugzilla-daemon＠bugs.koha-community.org 24 Jun '16

24 Jun '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048 Tomás Cohen Arazi <tomascohen(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #52748|0 |1 is obsolete| | --- Comment #61 from Tomás Cohen Arazi <tomascohen(a)gmail.com> --- Created attachment 52835 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52835&action=ed… Bug 14048: Add RefundLostItemFeeRule table and classes This patch introduces new classes for handling refund lost item fee rules. It introduces a new table for storing this rules. It is designed so it is possible to define a global rule, and then branch-specific ones. The specific is prefered if available. This behaviour is fully tested by unit tests introduced by the following patches. This cannot be tested on its own. Sponsored-by: DoverNet Sponsored-by: South-East Kansas Library System Sponsored-by: SWITCH Library Consortium Signed-off-by: Nick Clemens <nick(a)bywatersolutions.com> Signed-off-by: Jason Robb <jrobb(a)sekls.org> Signed-off-by: Jennifer Schmidt <jschmidt(a)switchinc.org> Signed-off-by: Margaret Thrasher <p.thrasher(a)dover.nh.gov> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10760] Use Street Number and Street type in Alternate Address section
by bugzilla-daemon＠bugs.koha-community.org 24 Jun '16

24 Jun '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10760 --- Comment #16 from Kyle M Hall <kyle(a)bywatersolutions.com> --- Created attachment 52831 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52831&action=ed… Bug 10760: (followup) Move street type after address As of comment #7 Signed-off-by: Owen Leonard <oleonard(a)myacpl.org> Signed-off-by: Kyle M Hall <kyle(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10760] Use Street Number and Street type in Alternate Address section
by bugzilla-daemon＠bugs.koha-community.org 24 Jun '16

24 Jun '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10760 --- Comment #15 from Kyle M Hall <kyle(a)bywatersolutions.com> --- Created attachment 52830 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52830&action=ed… Bug 10760: Alternate Address: Display street number and street type This patch displays alternate streetnumber and street type on patron's detail page. To test: - Apply patch - Verify that the alternate address information displays follwing the setting in syspref AddressFormat and contains street type and street number (as appropriate) Signed-off-by: Owen Leonard <oleonard(a)myacpl.org> Signed-off-by: Kyle M Hall <kyle(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10760] Use Street Number and Street type in Alternate Address section
by bugzilla-daemon＠bugs.koha-community.org 24 Jun '16

24 Jun '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10760 Kyle M Hall <kyle(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #52598|0 |1 is obsolete| | Attachment #52599|0 |1 is obsolete| | Attachment #52600|0 |1 is obsolete| | --- Comment #14 from Kyle M Hall <kyle(a)bywatersolutions.com> --- Created attachment 52829 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52829&action=ed… Bug 10760: Alternate Address: Make street number and street type editable Table 'borrowers' contain columns B_streetnumber and B_streettype. This patch makes them editable for alternate address. To test: - Apply patch - Edit a patron's details - Verify that in edit mode for Alternate address, the fields 'street type' and 'street number' appear and follow the settings in sysprefs AddressFormat, BorrowerMandatoryField, BorrowerUnwantedField - Verify that the values are saved correctly. Note: A second patch will follow to manage the display of street number and street type Signed-off-by: Owen Leonard <oleonard(a)myacpl.org> Signed-off-by: Kyle M Hall <kyle(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0