June 2016 - Koha-bugs - lists.koha-community.org

[Bug 7441] Search results showing wrong branch
by bugzilla-daemon＠bugs.koha-community.org 24 Jun '16

24 Jun '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7441 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|search results showing |Search results showing |wrong branch? |wrong branch --- Comment #76 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- I have extracted the UNIMARC XSLT changes from the patch (as it was before the last patchset). So if I understand everything correctly, we still need a signoff from an UNIMARC user and the changes to the NORMARC XSLT, that's it? I am wondering if it would not be easier to use something like items.$pref_value instead of the xsl:choose blocks which copy/paste code. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7441] search results showing wrong branch?
by bugzilla-daemon＠bugs.koha-community.org 24 Jun '16

24 Jun '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7441 --- Comment #75 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 52811 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52811&action=ed… Bug 7441 - Followup search results showing wrong branch [UNIMARC] -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7441] search results showing wrong branch?
by bugzilla-daemon＠bugs.koha-community.org 24 Jun '16

24 Jun '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7441 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #52747|0 |1 is obsolete| | --- Comment #74 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 52810 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52810&action=ed… Bug 7441 - search results showing wrong branch? When you search in the OPAC it shows you the HOME branch on the location in XSLT, but if you click through to the detail page it shows you the CURRENT BRANCH in the holdings table which is very confusing to patrons. I don't know what's the right solution - home or holding branch, but they should be the same in both places for the patron's sake. If you do the same search in the staff client you see the right branch info on the search results and on the detail page. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Search the catalog, you search should include results with items that have different home and holding libraries. 4) The results should look the same as before the patch 5) Change the system preference OPACResultsLibrary to "current location" 6) Refresh your page of search results 7) The results show now show the holding library instead of the home library Signed-off-by: Barbara Walters <bwalters(a)ncrl.org> Signed-off-by: Nick Clemens <nick(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12178] Serial claims: exporting late issues with the CSV profile doesn't set the issue claimed
by bugzilla-daemon＠bugs.koha-community.org 24 Jun '16

24 Jun '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12178 Kyle M Hall <kyle(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle(a)bywatersolutions.com Status|Signed Off |Passed QA --- Comment #20 from Kyle M Hall <kyle(a)bywatersolutions.com> --- I think this can go back to passed qa -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12178] Serial claims: exporting late issues with the CSV profile doesn't set the issue claimed
by bugzilla-daemon＠bugs.koha-community.org 24 Jun '16

24 Jun '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12178 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |16808 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16808 [Bug 16808] Serial claims: claiming via CSV export doesn't reload the page -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14757] Allow the use of Template Toolkit syntax for slips and notices
by bugzilla-daemon＠bugs.koha-community.org 24 Jun '16

24 Jun '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14757 --- Comment #46 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Kyle, I have squashed some patches (they failed qa tools: FAIL Koha/Borrower/Modification.pm FAIL git manipulation: The file has been added and deleted in the same patchset) and added tests for the new modules. However, I do not understand why you overload the method Koha::Patron::Modifications->new, this should not be needed Moreover, the methods of Koha::Patron::Modifications should now use snake_case (as they use Koha::Object), but it's outside the scope of this bug. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14757] Allow the use of Template Toolkit syntax for slips and notices
by bugzilla-daemon＠bugs.koha-community.org 24 Jun '16

24 Jun '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14757 --- Comment #45 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 52807 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52807&action=ed… Bug 14757: Add tests for new modules -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14757] Allow the use of Template Toolkit syntax for slips and notices
by bugzilla-daemon＠bugs.koha-community.org 24 Jun '16

24 Jun '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14757 --- Comment #44 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 52806 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52806&action=ed… Bug 14757 [QA Followup] - Add Unit Tests Signed-off-by: Sean McGarvey <seanm(a)pascolibraries.org> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14757] Allow the use of Template Toolkit syntax for slips and notices
by bugzilla-daemon＠bugs.koha-community.org 24 Jun '16

24 Jun '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14757 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #52758|0 |1 is obsolete| | Attachment #52759|0 |1 is obsolete| | Attachment #52760|0 |1 is obsolete| | Attachment #52761|0 |1 is obsolete| | --- Comment #43 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 52805 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52805&action=ed… Bug 14757 - Allow the use of Template Toolkit syntax for slips and notices This bug is the beginning of a conversion from our current bespoke syntax for slips and notices to Template Toolkit syntax. This patch is the initial seed which will evolve over time. With this addition, we can take advantage of our Koha Objects to greatly simplify the processing of Slips and Notices over time. Test Plan: 1) Apply this patch 2) Ensure you have the default CHECKOUT notice 3) Check out and return an item for a patron 4) Note the text of the CHECKOUT notice 5) Replace your CHECKOUT notice with the following: The following items have been checked out: ---- [% biblio.title %] ---- Thank you for visiting [% branch.branchname %]. 6) Repeat step 3 7) Note the CHECKOUT notice text matches the previous CHECKOUT notice text Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel(a)gmail.com> New notice syntax works, no koha-qa errors Signed-off-by: Sean McGarvey <seanm(a)pascolibraries.org> Bug 14757 [QA Followup] - Change method type() to _type() for Koha objects Signed-off-by: Sean McGarvey <seanm(a)pascolibraries.org> Bug 14757 [QA Followup] - Change all references to Koha::Borrower to Koha::Patron Signed-off-by: Sean McGarvey <seanm(a)pascolibraries.org> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12178] Serial claims: exporting late issues with the CSV profile doesn't set the issue claimed
by bugzilla-daemon＠bugs.koha-community.org 24 Jun '16

24 Jun '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12178 --- Comment #19 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- (In reply to Jonathan Druart from comment #15) > (In reply to Katrin Fischer from comment #11) > > But also a question: Would it be possible to reload the page? I accidentally > > ended up with 2 claims, where I was not sure it had worked before. I think > > this could be a trap a lot of libraries fall into. > > It should be possible yes. Is it done? -- You are receiving this mail because: You are watching all bug changes.

1 0