June 2016 - Koha-bugs - lists.koha-community.org

[Bug 14757] Allow the use of Template Toolkit syntax for slips and notices
by bugzilla-daemon＠bugs.koha-community.org 24 Jun '16

24 Jun '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14757 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #52758|0 |1 is obsolete| | Attachment #52759|0 |1 is obsolete| | Attachment #52760|0 |1 is obsolete| | Attachment #52761|0 |1 is obsolete| | --- Comment #43 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 52805 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52805&action=ed… Bug 14757 - Allow the use of Template Toolkit syntax for slips and notices This bug is the beginning of a conversion from our current bespoke syntax for slips and notices to Template Toolkit syntax. This patch is the initial seed which will evolve over time. With this addition, we can take advantage of our Koha Objects to greatly simplify the processing of Slips and Notices over time. Test Plan: 1) Apply this patch 2) Ensure you have the default CHECKOUT notice 3) Check out and return an item for a patron 4) Note the text of the CHECKOUT notice 5) Replace your CHECKOUT notice with the following: The following items have been checked out: ---- [% biblio.title %] ---- Thank you for visiting [% branch.branchname %]. 6) Repeat step 3 7) Note the CHECKOUT notice text matches the previous CHECKOUT notice text Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel(a)gmail.com> New notice syntax works, no koha-qa errors Signed-off-by: Sean McGarvey <seanm(a)pascolibraries.org> Bug 14757 [QA Followup] - Change method type() to _type() for Koha objects Signed-off-by: Sean McGarvey <seanm(a)pascolibraries.org> Bug 14757 [QA Followup] - Change all references to Koha::Borrower to Koha::Patron Signed-off-by: Sean McGarvey <seanm(a)pascolibraries.org> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12178] Serial claims: exporting late issues with the CSV profile doesn't set the issue claimed
by bugzilla-daemon＠bugs.koha-community.org 24 Jun '16

24 Jun '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12178 --- Comment #19 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- (In reply to Jonathan Druart from comment #15) > (In reply to Katrin Fischer from comment #11) > > But also a question: Would it be possible to reload the page? I accidentally > > ended up with 2 claims, where I was not sure it had worked before. I think > > this could be a trap a lot of libraries fall into. > > It should be possible yes. Is it done? -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12509] Untranslatable "Restriction added by overdues process"
by bugzilla-daemon＠bugs.koha-community.org 24 Jun '16

24 Jun '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12509 Kyle M Hall <kyle(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #52685|0 |1 is obsolete| | --- Comment #10 from Kyle M Hall <kyle(a)bywatersolutions.com> --- Created attachment 52804 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52804&action=ed… Bug 12509 - Fix Untranslatable Restriction added by overdues process Changes the value of the "comment" column in "borrower_debarments" table from "Restriction added by overdues process yyyy-mm-dd hh:mm:ss" to "OVERDUE_PROCESS yyyy-mm-dd hh:mm:ss" in the overdue_notices.pl. Then in the templates "moremember.tt", "circulation.tt", "memberentrygen.tt", "opac-reserve.tt" and "opac-user.tt" the value of "comment" is check, if it's an automatical comment due to overdue process it'll write "Restriction added by overdues process yyyy-mm-dd hh:mm:ss", then if there is a customizable comment it will be written without modification. Like this, the comment "Restriction added by overdues process" is written in the po files and can be translated later. To test: 1) create a patron with automatical restriction due to overdue process; 2) apply patch; 3) run misc/cronjobs/overdue_notices.pl; 4) verify if the comment "Restriction added by overdues process" is well written and translatable on the following page : - opac patron home page (opac-user.tt); - opac item reservation page (opac-reserve.tt); - pro patron page (moremember.tt); - reservation item for a patron (circulation.tt, memberentrygen.tt); 5) try to translate the comment in po files; 6) sign off. Signed-off-by: Owen Leonard <oleonard(a)myacpl.org> Signed-off-by: Kyle M Hall <kyle(a)bywatersolutions.com> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 0

[Bug 12509] Untranslatable "Restriction added by overdues process"
by bugzilla-daemon＠bugs.koha-community.org 24 Jun '16

24 Jun '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12509 Kyle M Hall <kyle(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 0

[Bug 12178] Serial claims: exporting late issues with the CSV profile doesn't set the issue claimed
by bugzilla-daemon＠bugs.koha-community.org 24 Jun '16

24 Jun '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12178 --- Comment #18 from Kyle M Hall <kyle(a)bywatersolutions.com> --- Created attachment 52803 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52803&action=ed… Bug 12178: Fix tests not to depend on dateformat syspref Signed-off-by: Kyle M Hall <kyle(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12178] Serial claims: exporting late issues with the CSV profile doesn't set the issue claimed
by bugzilla-daemon＠bugs.koha-community.org 24 Jun '16

24 Jun '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12178 --- Comment #17 from Kyle M Hall <kyle(a)bywatersolutions.com> --- Created attachment 52802 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52802&action=ed… Bug 12178: Tests for changes to claimed serial status Signed-off-by: Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> Amended patch: Remove trailing spaces Signed-off-by: Kyle M Hall <kyle(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12178] Serial claims: exporting late issues with the CSV profile doesn't set the issue claimed
by bugzilla-daemon＠bugs.koha-community.org 24 Jun '16

24 Jun '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12178 Kyle M Hall <kyle(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #52637|0 |1 is obsolete| | Attachment #52638|0 |1 is obsolete| | Attachment #52639|0 |1 is obsolete| | --- Comment #16 from Kyle M Hall <kyle(a)bywatersolutions.com> --- Created attachment 52801 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52801&action=ed… Bug 12178: Update serial status to "claimed" when exporting to CSV On the same way as late issues, the serial status should be updated to 'claimed' when the issues as exported as csv. QA note: The updateClaim and UpdateClaimdateIssues subroutine did almost the same thing, I kick the second on off to centralize the code. Test plan: 1/ Export some late issues as CSV (serials/claims.pl). 2/ Refresh the page (the export does not do it) and confirm that the status, the claim date and the claim count have been updated. 3/ Select some others issues, select a notice and send the notification. Confirm that the behavior is the same. Signed-off-by: Kyle M Hall <kyle(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11144] Fix sequence of cronjobs: automatic renewal - fines - overdue notices
by bugzilla-daemon＠bugs.koha-community.org 24 Jun '16

24 Jun '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11144 Kyle M Hall <kyle(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #51348|0 |1 is obsolete| | --- Comment #34 from Kyle M Hall <kyle(a)bywatersolutions.com> --- Created attachment 52800 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52800&action=ed… Bug 11144: Fix sequence of cronjobs: automatic renewal - fines - overdue notices The patch changes the sequence of cronjobs in the crontab example file and in the cron.daily file of the packages. This is why: 1) Renew automatically ... only when we can't renew, we want to 2) Calculate fines ... once the fine are calculated and charged we can print the amount into the 3) Overdue notices Before the change it could happen that you'd charge for an item, that would then be renewed. Or that you'd try to print fine amounts into the overdue notices, when they would only be charged moments later. To test: - configure your system so you have items that should - be charged with fines - renew automatically - configure your crontabs according to the example file or switch the cron.daily in your package installation with the new one - configure your overdue notices so that one should be generated <<items.fine>> - Wait for the cronjobs or schedule them to run earlier - Verify all is well and as it should be Signed-off-by: Chris Cormack <chrisc(a)catalyst.net.nz> Signed-off-by: Kyle M Hall <kyle(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11144] Fix sequence of cronjobs: automatic renewal - fines - overdue notices
by bugzilla-daemon＠bugs.koha-community.org 24 Jun '16

24 Jun '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11144 Kyle M Hall <kyle(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14435] The table saved_reports is never populated
by bugzilla-daemon＠bugs.koha-community.org 24 Jun '16

24 Jun '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14435 --- Comment #26 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- (In reply to Marcel de Rooy from comment #25) > Commit message still says: > > This patch is a proof of concept and is not very polished (understood: > it cannot be pushed like that). I do not plan to work more on this one, unless several people are interested. But I think it's a good start for someone who wants to continue... -- You are receiving this mail because: You are watching all bug changes.

1 0