June 2016 - Koha-bugs - lists.koha-community.org

[Bug 15006] Need to distinguish client timeout from login timeout
by bugzilla-daemon＠bugs.koha-community.org 24 Jun '16

24 Jun '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15006 --- Comment #26 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Decided to relax the restricted handling in the third patch here. Could be done on another report if we wish to. Still want some feedback on using $server->{policy}->{timeout} in the fourth patch. How do sip2 machines generally respond to that parameter if they do? -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15006] Need to distinguish client timeout from login timeout
by bugzilla-daemon＠bugs.koha-community.org 24 Jun '16

24 Jun '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15006 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #52480|0 |1 is obsolete| | --- Comment #25 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 52785 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52785&action=ed… Bug 15006: [COUNTERPATCH] Timeout logic in sip_protocol_loop Instead of adding yet another client timeout, I propose to use the policy timeout that we also communicate in send_acs_status. Although I agree that we perhaps better move it from institution to account/login level, this c/should be done on another report. We may have issues with existing configurations. In order to find a compromise between bug 13432 and the originally proposed 15006 patch, this patch allows you to put a zero in the policy timeout entry in the SIPconfig. The timeout logic is moved to a Sip.pm subroutine. Will add a test :) Test plan: [1] Check timeout after login with policy/timeout > 0. [2] Check timeout after login with policy/timeout = 0. (No timeout!) [3] Check timeout after login with no policy timeout. Fallback to service. [4] Check timeout after login with no policy and service timeout. Should fallback to 30 seconds for both login process and after login. Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15006] Need to distinguish client timeout from login timeout
by bugzilla-daemon＠bugs.koha-community.org 24 Jun '16

24 Jun '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15006 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #52479|0 |1 is obsolete| | --- Comment #24 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 52784 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52784&action=ed… Bug 15006: [COUNTERPATCH] Add timeout and strikes to raw_transport The code in raw_transport includes setting a $SIG{ALRM}, but did not use it. For consistency, we add an alarm statement here. Similarly, we add the "three strikes" to raw_transport just as telnet_transport does. Note that raw_transport still responds to other requests, but will exit if there is no valid login within three attempts. (If we want more restrictions, add them later?) Test plan: [1] Start sip session with telnet on raw port 6001. Wait until it times out (probably the default 60 seconds). [2] Change SIPconfig.xml: set timeout=5 for service port 6001. Restart SIP and start another telnet 6001 session. Did it timeout within 5 seconds? [3] Start another 6001 session. Give three wrong requests or false login attempts. Does the connection close? Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11490] MaxItemsForBatch should be split into two new prefs
by bugzilla-daemon＠bugs.koha-community.org 24 Jun '16

24 Jun '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11490 Kyle M Hall <kyle(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |kyle(a)bywatersolutions.com --- Comment #14 from Kyle M Hall <kyle(a)bywatersolutions.com> --- Pushed to master for 16.11, thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14435] The table saved_reports is never populated
by bugzilla-daemon＠bugs.koha-community.org 24 Jun '16

24 Jun '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14435 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy(a)rijksmuseum.nl --- Comment #25 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Commit message still says: This patch is a proof of concept and is not very polished (understood: it cannot be pushed like that). -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 16597] Reflected XSS in [opac-]shelves and [opac-]shareshelf
by bugzilla-daemon＠bugs.koha-community.org 24 Jun '16

24 Jun '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16597 Julian Maurice <julian.maurice(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice(a)biblibre.com --- Comment #12 from Julian Maurice <julian.maurice(a)biblibre.com> --- (In reply to Chris Cormack from comment #11) > is in 3.22.7 No, but it will be in 3.22.8 -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 16599] XSS found in opac-shareshelf.pl
by bugzilla-daemon＠bugs.koha-community.org 24 Jun '16

24 Jun '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16599 Julian Maurice <julian.maurice(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice(a)biblibre.com --- Comment #15 from Julian Maurice <julian.maurice(a)biblibre.com> --- (In reply to Chris Cormack from comment #14) > (Is in 3.22.7 already) No, but it will be in 3.22.8 -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15261] Verify if checkouts or reserves requests periods overlap with existing reserves
by bugzilla-daemon＠bugs.koha-community.org 24 Jun '16

24 Jun '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15261 Marc Véron <veron(a)veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron(a)veron.ch -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 3311] Statistical reports should error if row and column aren't selected
by bugzilla-daemon＠bugs.koha-community.org 24 Jun '16

24 Jun '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3311 M. Tompsett <mtompset(a)hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Hardware|PC |All Version|rel_3_0 |master -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 16456] New: Add Font Awesome icons to some buttons in Tools module, section Patrons and circulation
by bugzilla-daemon＠bugs.koha-community.org 24 Jun '16

24 Jun '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16456 Bug ID: 16456 Summary: Add Font Awesome icons to some buttons in Tools module, section Patrons and circulation Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard(a)myacpl.org Reporter: hector.hecaxmmx(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org Depends on: 16438, 16439 Add Font Awesome Icons to section Patrons and circulation in Tools module (Save, Upload, Filter, Import) Also the Tag and Comments tools has been revised to fit with others interfaces in Koha. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16438 [Bug 16438] Use Font Awesome icons in batch templates https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16439 [Bug 16439] Allow styling to button for upload local cover images (Font Awesome Icons) -- You are receiving this mail because: You are watching all bug changes.

1 48